Skip to content

SUMO-278456 | Changes to fix arn fidings with ESC AWS region. Changes… - #31

Merged
sumoanema merged 4 commits into
mainfrom
arnfindingfix
Apr 3, 2026
Merged

SUMO-278456 | Changes to fix arn fidings with ESC AWS region. Changes…#31
sumoanema merged 4 commits into
mainfrom
arnfindingfix

Conversation

@sumoanema

Copy link
Copy Markdown
Contributor

… script to print the correct ARN based on dynamically fetching partition by aws cli command

PR Details

SUMO-278456 | Changes to fix arn fidings with ESC AWS region. Changes script to print the correct ARN based on dynamically fetching partition by aws cli command

Description

SUMO-278456 | Changes to fix arn fidings with ESC AWS region. Changes script to print the correct ARN based on dynamically fetching partition by aws cli command

Related Issue

https://sumologic.atlassian.net/browse/SUMO-278456

Checklist

  • Updated CHANGELOG.md. - NA
  • Ran unit tests locally. - NA

… script to print the correct ARN based on dynamically fetching partition by aws cli command
@sumoanema
sumoanema requested a review from a team as a code ownerMarch 31, 2026 08:26
@sumoanema
sumoanema requested review from akhil-sumologic, Copilot and npande and removed request for a teamMarch 31, 2026 08:29

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates deployment/cleanup scripts to print Lambda Layer ARNs with the correct AWS partition (e.g., aws, aws-cn, aws-us-gov) by deriving the partition dynamically via AWS CLI.

Changes:

  • scripts/zip.sh: Derives AWS partition from sts get-caller-identity and uses it when printing the deployed Layer ARN.
  • scripts/delete_old_layer_versions.sh: Derives AWS partition similarly and uses it when printing the deleted Layer ARN.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
scripts/zip.shBuilds/publishes layers and now prints ARNs using a dynamically-derived partition.
scripts/delete_old_layer_versions.shDeletes layer versions and now prints ARNs using a dynamically-derived partition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadscripts/zip.sh Outdated
Comment threadscripts/delete_old_layer_versions.sh Outdated

@akhil-sumologicakhil-sumologic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumoanema
sumoanema merged commit 539e258 into mainApr 3, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sumoanema@akhil-sumologic