Uh oh!
There was an error while loading. Please reload this page.
fix(ci): target production from DFW runners - #24
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:3c372be825
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Both must return kubectl's literal "no" AND status 1. Status alone is not proof: | ||
| # timeouts, TLS failures and killed processes are all non-zero too, so an | ||
| # unreachable cluster would otherwise be reported as verified isolation. | ||
| for probe in "get secrets:kube-system" "get deployments:beacon-prod"; do |
There was a problem hiding this comment.
Check every dangerous verb before declaring isolation
If RBAC drift grants a different verb—such as list/watch on kube-system Secrets or create/delete on beacon-prod Deployments—these two get checks still return no, so the action reports verified isolation and deploys with a credential capable of exposing secrets or altering sibling production resources. Kubernetes authorizes RBAC verbs independently and explicitly warns that listing or watching Secrets reveals their contents; probe the relevant read and mutation verbs rather than treating one denied get as resource isolation.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Completes TaskForge #20663 production deployment after the DFW migration exposed the old in-cluster kubeconfig assumption.
The Vault token is minted by the a1-ops-prd Kubernetes secrets engine, but
kubernetes.default.svcand the projected CA now identify stackeye-ci-dfw01. This ports TaskForge’s tested cross-cluster action and configures KubeTTY-specific credentials.Validation:
Failure evidence: main run 33055562906 built/pushed successfully, then rejected the production token against the DFW in-cluster API.
TaskForge: #20663