feat(js): take a form registration back

[66Ton99]

Problem

addModel() keeps every render in forms and formInstances, and nothing takes one back out. A page that swaps rendered forms in and out of the document — a single page CRUD, a modal that loads its form — registers a model per render, so:

• the registry grows with elements whose markup has already been removed, and getFormInstances(id) answers with them;
• those elements keep the removed nodes alive through element.domNode and domNode.jsFormValidator;
• initModel() calls attachDefaultEvent() unconditionally, so re-initializing the same markup stacks a second submit listener on the form and runs the whole validation twice for one submit.

Change

Three public methods, each detaching the model from the DOM nodes of the element and its children and removing the submit listener this library put on the form:

SvarohJsFormValidator.removeModel('user');// every render of one model idSvarohJsFormValidator.removeForm(document.getElementById('user'));// one rendered formSvarohJsFormValidator.removeDetachedForms();// every form no longer in the document

removeModel() answers with the number of removed registrations, removeForm() with whether it removed one, removeDetachedForms() with the number it removed. When the last registration of an id is removed, the id leaves forms as well, so the registry never answers with an element it no longer holds.

attachDefaultEvent() now keeps its listener on the node and replaces it, so initializing the same markup again validates the form once per submit instead of twice.

Nothing changes for a page that never removes a form.

Docs

New src/Resources/doc/3_24.md, linked from the README list.

Tests

Seven Jest tests in SvarohJsFormValidator.test.js covering each method, the unknown-id and unknown-node cases, that a removed form no longer runs validation on submit, and that a second initialization of the same markup does not validate twice.

npx jest — 615 tests pass (608 before). PHP checks are untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

🤖 Generated with Claude Code

[66Ton99]

Review

Reviewed in a separate worktree, with every finding reproduced by running the code rather than by reading it. Four defects and one regression, all with the same root cause.

The seven new tests and both doc examples are built on <form id="profile">. That is not what Symfony renders: form_start() writes <form name="profile" method="post"> with no id, and form_widget() puts the id of the model on the container it writes inside the form (form_widget_compound → widget_container_attributes). The e2e fixture of this repository, {{ form(testForm) }}, renders exactly that.

So findDomElement() matches the container, and initModel() then moves the root element to the form. The element is attached to two nodes, and detachElement() only took one of them back.

1. The documented "remove, then initialize again" flow throws.removeModel() left jsFormValidator on the container, and the next addModel() read it back through attachElement(), which re-reads element.domNode.jsFormValidator on every iteration while the loop itself overwrites domNode — TypeError: Cannot read properties of undefined (reading 'callbacks').

2. removeForm(document.getElementById('user')) removed nothing.getElementById() answers with the container; the registry held the form. The call in 3_24.md returned false.

3. removeModel() left the container attached to the removed element, which is the reference the description of this PR says is taken back.

4. removeDetachedForms() dropped live registrations. A model rendered outside of any <form> has no root node at all — initModel() allows it — and domNode && document.contains(domNode) counted it as detached while its widgets were in the document.

5. Regression: the submit listener went with the first element removed from a form. Two models rooted in one <form> validated twice per submit before this PR and once after it, which is the improvement; after removeModel() of either one, the form was validated zero times. The listener resolves its element from the node at submit time, so it belongs to the node, not to one of its models.

Fixed in e75a67a

• SvarohJsFormElement.widgetDomNode holds the node the model id matched, written after attachElement() so a second model in the same form cannot hand this element its container.
• detachElement() takes both nodes back through detachNode(), which keeps the submit listener for as long as an element is attached to the node.
• removeForm() answers to either node; removeDetachedForms() asks isElementInDocument(), which looks at the whole element and its children.
• attachElement() reads the attached element once instead of re-reading it through a domNode it has already overwritten.
• keepFormInstances() is replaceFormInstances(), the internal helpers say so in their docblocks, and an id nothing was removed from keeps the array the registry already handed out.
• 3_24.md explains why getElementById() answers with the container and what removeDetachedForms() looks at.

Ten more tests, on the markup Symfony renders: attachment to both nodes, removeModel() clearing both, re-initialization of the same markup, removeForm() by the container, a model with no form tag (as a container and rendered row by row), two models in one form, plus the forms[id] repointing branch that no test reached and detachElement(null).

npx jest: 625 pass (615 before). npm run test:coverage: JavaScript line coverage 94.96%, threshold 80%, no uncovered line left in the new code. PHP is untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

[66Ton99]

Problem

addModel() keeps every render in forms and formInstances, and nothing takes one back out. A page that swaps rendered forms in and out of the document — a single page CRUD, a modal that loads its form — registers a model per render, so:

• the registry grows with elements whose markup has already been removed, and getFormInstances(id) answers with them;
• those elements keep the removed nodes alive through element.domNode and domNode.jsFormValidator;
• initModel() calls attachDefaultEvent() unconditionally, so re-initializing the same markup stacks a second submit listener on the form and runs the whole validation twice for one submit.

Change

Three public methods, each detaching the model from the DOM nodes of the element and its children and removing the submit listener this library put on the form:

SvarohJsFormValidator.removeModel('user');// every render of one model idSvarohJsFormValidator.removeForm(document.getElementById('user'));// one rendered formSvarohJsFormValidator.removeDetachedForms();// every form no longer in the document

removeModel() answers with the number of removed registrations, removeForm() with whether it removed one, removeDetachedForms() with the number it removed. When the last registration of an id is removed, the id leaves forms as well, so the registry never answers with an element it no longer holds.

attachDefaultEvent() now keeps its listener on the node and replaces it, so initializing the same markup again validates the form once per submit instead of twice.

Nothing changes for a page that never removes a form.

Docs

New src/Resources/doc/3_24.md, linked from the README list.

Tests

Seven Jest tests in SvarohJsFormValidator.test.js covering each method, the unknown-id and unknown-node cases, that a removed form no longer runs validation on submit, and that a second initialization of the same markup does not validate twice.

npx jest — 615 tests pass (608 before). PHP checks are untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

🤖 Generated with Claude Code

[66Ton99]

Review

Reviewed in a separate worktree, with every finding reproduced by running the code rather than by reading it. Four defects and one regression, all with the same root cause.

The seven new tests and both doc examples are built on <form id="profile">. That is not what Symfony renders: form_start() writes <form name="profile" method="post"> with no id, and form_widget() puts the id of the model on the container it writes inside the form (form_widget_compound → widget_container_attributes). The e2e fixture of this repository, {{ form(testForm) }}, renders exactly that.

So findDomElement() matches the container, and initModel() then moves the root element to the form. The element is attached to two nodes, and detachElement() only took one of them back.

1. The documented "remove, then initialize again" flow throws.removeModel() left jsFormValidator on the container, and the next addModel() read it back through attachElement(), which re-reads element.domNode.jsFormValidator on every iteration while the loop itself overwrites domNode — TypeError: Cannot read properties of undefined (reading 'callbacks').

2. removeForm(document.getElementById('user')) removed nothing.getElementById() answers with the container; the registry held the form. The call in 3_24.md returned false.

3. removeModel() left the container attached to the removed element, which is the reference the description of this PR says is taken back.

4. removeDetachedForms() dropped live registrations. A model rendered outside of any <form> has no root node at all — initModel() allows it — and domNode && document.contains(domNode) counted it as detached while its widgets were in the document.

5. Regression: the submit listener went with the first element removed from a form. Two models rooted in one <form> validated twice per submit before this PR and once after it, which is the improvement; after removeModel() of either one, the form was validated zero times. The listener resolves its element from the node at submit time, so it belongs to the node, not to one of its models.

Fixed in e75a67a

• SvarohJsFormElement.widgetDomNode holds the node the model id matched, written after attachElement() so a second model in the same form cannot hand this element its container.
• detachElement() takes both nodes back through detachNode(), which keeps the submit listener for as long as an element is attached to the node.
• removeForm() answers to either node; removeDetachedForms() asks isElementInDocument(), which looks at the whole element and its children.
• attachElement() reads the attached element once instead of re-reading it through a domNode it has already overwritten.
• keepFormInstances() is replaceFormInstances(), the internal helpers say so in their docblocks, and an id nothing was removed from keeps the array the registry already handed out.
• 3_24.md explains why getElementById() answers with the container and what removeDetachedForms() looks at.

Ten more tests, on the markup Symfony renders: attachment to both nodes, removeModel() clearing both, re-initialization of the same markup, removeForm() by the container, a model with no form tag (as a container and rendered row by row), two models in one form, plus the forms[id] repointing branch that no test reached and detachElement(null).

npx jest: 625 pass (615 before). npm run test:coverage: JavaScript line coverage 94.96%, threshold 80%, no uncovered line left in the new code. PHP is untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

[66Ton99]

Problem

addModel() keeps every render in forms and formInstances, and nothing takes one back out. A page that swaps rendered forms in and out of the document — a single page CRUD, a modal that loads its form — registers a model per render, so:

• the registry grows with elements whose markup has already been removed, and getFormInstances(id) answers with them;
• those elements keep the removed nodes alive through element.domNode and domNode.jsFormValidator;
• initModel() calls attachDefaultEvent() unconditionally, so re-initializing the same markup stacks a second submit listener on the form and runs the whole validation twice for one submit.

Change

Three public methods, each detaching the model from the DOM nodes of the element and its children and removing the submit listener this library put on the form:

SvarohJsFormValidator.removeModel('user');// every render of one model idSvarohJsFormValidator.removeForm(document.getElementById('user'));// one rendered formSvarohJsFormValidator.removeDetachedForms();// every form no longer in the document

removeModel() answers with the number of removed registrations, removeForm() with whether it removed one, removeDetachedForms() with the number it removed. When the last registration of an id is removed, the id leaves forms as well, so the registry never answers with an element it no longer holds.

attachDefaultEvent() now keeps its listener on the node and replaces it, so initializing the same markup again validates the form once per submit instead of twice.

Nothing changes for a page that never removes a form.

Docs

New src/Resources/doc/3_24.md, linked from the README list.

Tests

Seven Jest tests in SvarohJsFormValidator.test.js covering each method, the unknown-id and unknown-node cases, that a removed form no longer runs validation on submit, and that a second initialization of the same markup does not validate twice.

npx jest — 615 tests pass (608 before). PHP checks are untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

🤖 Generated with Claude Code

[66Ton99]

Review

Reviewed in a separate worktree, with every finding reproduced by running the code rather than by reading it. Four defects and one regression, all with the same root cause.

The seven new tests and both doc examples are built on <form id="profile">. That is not what Symfony renders: form_start() writes <form name="profile" method="post"> with no id, and form_widget() puts the id of the model on the container it writes inside the form (form_widget_compound → widget_container_attributes). The e2e fixture of this repository, {{ form(testForm) }}, renders exactly that.

So findDomElement() matches the container, and initModel() then moves the root element to the form. The element is attached to two nodes, and detachElement() only took one of them back.

1. The documented "remove, then initialize again" flow throws.removeModel() left jsFormValidator on the container, and the next addModel() read it back through attachElement(), which re-reads element.domNode.jsFormValidator on every iteration while the loop itself overwrites domNode — TypeError: Cannot read properties of undefined (reading 'callbacks').

2. removeForm(document.getElementById('user')) removed nothing.getElementById() answers with the container; the registry held the form. The call in 3_24.md returned false.

3. removeModel() left the container attached to the removed element, which is the reference the description of this PR says is taken back.

4. removeDetachedForms() dropped live registrations. A model rendered outside of any <form> has no root node at all — initModel() allows it — and domNode && document.contains(domNode) counted it as detached while its widgets were in the document.

5. Regression: the submit listener went with the first element removed from a form. Two models rooted in one <form> validated twice per submit before this PR and once after it, which is the improvement; after removeModel() of either one, the form was validated zero times. The listener resolves its element from the node at submit time, so it belongs to the node, not to one of its models.

Fixed in e75a67a

• SvarohJsFormElement.widgetDomNode holds the node the model id matched, written after attachElement() so a second model in the same form cannot hand this element its container.
• detachElement() takes both nodes back through detachNode(), which keeps the submit listener for as long as an element is attached to the node.
• removeForm() answers to either node; removeDetachedForms() asks isElementInDocument(), which looks at the whole element and its children.
• attachElement() reads the attached element once instead of re-reading it through a domNode it has already overwritten.
• keepFormInstances() is replaceFormInstances(), the internal helpers say so in their docblocks, and an id nothing was removed from keeps the array the registry already handed out.
• 3_24.md explains why getElementById() answers with the container and what removeDetachedForms() looks at.

Ten more tests, on the markup Symfony renders: attachment to both nodes, removeModel() clearing both, re-initialization of the same markup, removeForm() by the container, a model with no form tag (as a container and rendered row by row), two models in one form, plus the forms[id] repointing branch that no test reached and detachElement(null).

npx jest: 625 pass (615 before). npm run test:coverage: JavaScript line coverage 94.96%, threshold 80%, no uncovered line left in the new code. PHP is untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

[66Ton99]

Problem

addModel() keeps every render in forms and formInstances, and nothing takes one back out. A page that swaps rendered forms in and out of the document — a single page CRUD, a modal that loads its form — registers a model per render, so:

• the registry grows with elements whose markup has already been removed, and getFormInstances(id) answers with them;
• those elements keep the removed nodes alive through element.domNode and domNode.jsFormValidator;
• initModel() calls attachDefaultEvent() unconditionally, so re-initializing the same markup stacks a second submit listener on the form and runs the whole validation twice for one submit.

Change

Three public methods, each detaching the model from the DOM nodes of the element and its children and removing the submit listener this library put on the form:

SvarohJsFormValidator.removeModel('user');// every render of one model idSvarohJsFormValidator.removeForm(document.getElementById('user'));// one rendered formSvarohJsFormValidator.removeDetachedForms();// every form no longer in the document

removeModel() answers with the number of removed registrations, removeForm() with whether it removed one, removeDetachedForms() with the number it removed. When the last registration of an id is removed, the id leaves forms as well, so the registry never answers with an element it no longer holds.

attachDefaultEvent() now keeps its listener on the node and replaces it, so initializing the same markup again validates the form once per submit instead of twice.

Nothing changes for a page that never removes a form.

Docs

New src/Resources/doc/3_24.md, linked from the README list.

Tests

Seven Jest tests in SvarohJsFormValidator.test.js covering each method, the unknown-id and unknown-node cases, that a removed form no longer runs validation on submit, and that a second initialization of the same markup does not validate twice.

npx jest — 615 tests pass (608 before). PHP checks are untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

🤖 Generated with Claude Code

[66Ton99]

Review

Reviewed in a separate worktree, with every finding reproduced by running the code rather than by reading it. Four defects and one regression, all with the same root cause.

The seven new tests and both doc examples are built on <form id="profile">. That is not what Symfony renders: form_start() writes <form name="profile" method="post"> with no id, and form_widget() puts the id of the model on the container it writes inside the form (form_widget_compound → widget_container_attributes). The e2e fixture of this repository, {{ form(testForm) }}, renders exactly that.

So findDomElement() matches the container, and initModel() then moves the root element to the form. The element is attached to two nodes, and detachElement() only took one of them back.

1. The documented "remove, then initialize again" flow throws.removeModel() left jsFormValidator on the container, and the next addModel() read it back through attachElement(), which re-reads element.domNode.jsFormValidator on every iteration while the loop itself overwrites domNode — TypeError: Cannot read properties of undefined (reading 'callbacks').

2. removeForm(document.getElementById('user')) removed nothing.getElementById() answers with the container; the registry held the form. The call in 3_24.md returned false.

3. removeModel() left the container attached to the removed element, which is the reference the description of this PR says is taken back.

4. removeDetachedForms() dropped live registrations. A model rendered outside of any <form> has no root node at all — initModel() allows it — and domNode && document.contains(domNode) counted it as detached while its widgets were in the document.

5. Regression: the submit listener went with the first element removed from a form. Two models rooted in one <form> validated twice per submit before this PR and once after it, which is the improvement; after removeModel() of either one, the form was validated zero times. The listener resolves its element from the node at submit time, so it belongs to the node, not to one of its models.

Fixed in e75a67a

• SvarohJsFormElement.widgetDomNode holds the node the model id matched, written after attachElement() so a second model in the same form cannot hand this element its container.
• detachElement() takes both nodes back through detachNode(), which keeps the submit listener for as long as an element is attached to the node.
• removeForm() answers to either node; removeDetachedForms() asks isElementInDocument(), which looks at the whole element and its children.
• attachElement() reads the attached element once instead of re-reading it through a domNode it has already overwritten.
• keepFormInstances() is replaceFormInstances(), the internal helpers say so in their docblocks, and an id nothing was removed from keeps the array the registry already handed out.
• 3_24.md explains why getElementById() answers with the container and what removeDetachedForms() looks at.

Ten more tests, on the markup Symfony renders: attachment to both nodes, removeModel() clearing both, re-initialization of the same markup, removeForm() by the container, a model with no form tag (as a container and rendered row by row), two models in one form, plus the forms[id] repointing branch that no test reached and detachElement(null).

npx jest: 625 pass (615 before). npm run test:coverage: JavaScript line coverage 94.96%, threshold 80%, no uncovered line left in the new code. PHP is untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

[66Ton99]

Problem

addModel() keeps every render in forms and formInstances, and nothing takes one back out. A page that swaps rendered forms in and out of the document — a single page CRUD, a modal that loads its form — registers a model per render, so:

• the registry grows with elements whose markup has already been removed, and getFormInstances(id) answers with them;
• those elements keep the removed nodes alive through element.domNode and domNode.jsFormValidator;
• initModel() calls attachDefaultEvent() unconditionally, so re-initializing the same markup stacks a second submit listener on the form and runs the whole validation twice for one submit.

Change

Three public methods, each detaching the model from the DOM nodes of the element and its children and removing the submit listener this library put on the form:

SvarohJsFormValidator.removeModel('user');// every render of one model idSvarohJsFormValidator.removeForm(document.getElementById('user'));// one rendered formSvarohJsFormValidator.removeDetachedForms();// every form no longer in the document

removeModel() answers with the number of removed registrations, removeForm() with whether it removed one, removeDetachedForms() with the number it removed. When the last registration of an id is removed, the id leaves forms as well, so the registry never answers with an element it no longer holds.

attachDefaultEvent() now keeps its listener on the node and replaces it, so initializing the same markup again validates the form once per submit instead of twice.

Nothing changes for a page that never removes a form.

Docs

New src/Resources/doc/3_24.md, linked from the README list.

Tests

Seven Jest tests in SvarohJsFormValidator.test.js covering each method, the unknown-id and unknown-node cases, that a removed form no longer runs validation on submit, and that a second initialization of the same markup does not validate twice.

npx jest — 615 tests pass (608 before). PHP checks are untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

🤖 Generated with Claude Code

[66Ton99]

Review

Reviewed in a separate worktree, with every finding reproduced by running the code rather than by reading it. Four defects and one regression, all with the same root cause.

The seven new tests and both doc examples are built on <form id="profile">. That is not what Symfony renders: form_start() writes <form name="profile" method="post"> with no id, and form_widget() puts the id of the model on the container it writes inside the form (form_widget_compound → widget_container_attributes). The e2e fixture of this repository, {{ form(testForm) }}, renders exactly that.

So findDomElement() matches the container, and initModel() then moves the root element to the form. The element is attached to two nodes, and detachElement() only took one of them back.

1. The documented "remove, then initialize again" flow throws.removeModel() left jsFormValidator on the container, and the next addModel() read it back through attachElement(), which re-reads element.domNode.jsFormValidator on every iteration while the loop itself overwrites domNode — TypeError: Cannot read properties of undefined (reading 'callbacks').

2. removeForm(document.getElementById('user')) removed nothing.getElementById() answers with the container; the registry held the form. The call in 3_24.md returned false.

3. removeModel() left the container attached to the removed element, which is the reference the description of this PR says is taken back.

4. removeDetachedForms() dropped live registrations. A model rendered outside of any <form> has no root node at all — initModel() allows it — and domNode && document.contains(domNode) counted it as detached while its widgets were in the document.

5. Regression: the submit listener went with the first element removed from a form. Two models rooted in one <form> validated twice per submit before this PR and once after it, which is the improvement; after removeModel() of either one, the form was validated zero times. The listener resolves its element from the node at submit time, so it belongs to the node, not to one of its models.

Fixed in e75a67a

• SvarohJsFormElement.widgetDomNode holds the node the model id matched, written after attachElement() so a second model in the same form cannot hand this element its container.
• detachElement() takes both nodes back through detachNode(), which keeps the submit listener for as long as an element is attached to the node.
• removeForm() answers to either node; removeDetachedForms() asks isElementInDocument(), which looks at the whole element and its children.
• attachElement() reads the attached element once instead of re-reading it through a domNode it has already overwritten.
• keepFormInstances() is replaceFormInstances(), the internal helpers say so in their docblocks, and an id nothing was removed from keeps the array the registry already handed out.
• 3_24.md explains why getElementById() answers with the container and what removeDetachedForms() looks at.

Ten more tests, on the markup Symfony renders: attachment to both nodes, removeModel() clearing both, re-initialization of the same markup, removeForm() by the container, a model with no form tag (as a container and rendered row by row), two models in one form, plus the forms[id] repointing branch that no test reached and detachElement(null).

npx jest: 625 pass (615 before). npm run test:coverage: JavaScript line coverage 94.96%, threshold 80%, no uncovered line left in the new code. PHP is untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

[66Ton99]

Problem

addModel() keeps every render in forms and formInstances, and nothing takes one back out. A page that swaps rendered forms in and out of the document — a single page CRUD, a modal that loads its form — registers a model per render, so:

• the registry grows with elements whose markup has already been removed, and getFormInstances(id) answers with them;
• those elements keep the removed nodes alive through element.domNode and domNode.jsFormValidator;
• initModel() calls attachDefaultEvent() unconditionally, so re-initializing the same markup stacks a second submit listener on the form and runs the whole validation twice for one submit.

Change

Three public methods, each detaching the model from the DOM nodes of the element and its children and removing the submit listener this library put on the form:

SvarohJsFormValidator.removeModel('user');// every render of one model idSvarohJsFormValidator.removeForm(document.getElementById('user'));// one rendered formSvarohJsFormValidator.removeDetachedForms();// every form no longer in the document

removeModel() answers with the number of removed registrations, removeForm() with whether it removed one, removeDetachedForms() with the number it removed. When the last registration of an id is removed, the id leaves forms as well, so the registry never answers with an element it no longer holds.

attachDefaultEvent() now keeps its listener on the node and replaces it, so initializing the same markup again validates the form once per submit instead of twice.

Nothing changes for a page that never removes a form.

Docs

New src/Resources/doc/3_24.md, linked from the README list.

Tests

Seven Jest tests in SvarohJsFormValidator.test.js covering each method, the unknown-id and unknown-node cases, that a removed form no longer runs validation on submit, and that a second initialization of the same markup does not validate twice.

npx jest — 615 tests pass (608 before). PHP checks are untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

🤖 Generated with Claude Code

[66Ton99]

Review

Reviewed in a separate worktree, with every finding reproduced by running the code rather than by reading it. Four defects and one regression, all with the same root cause.

The seven new tests and both doc examples are built on <form id="profile">. That is not what Symfony renders: form_start() writes <form name="profile" method="post"> with no id, and form_widget() puts the id of the model on the container it writes inside the form (form_widget_compound → widget_container_attributes). The e2e fixture of this repository, {{ form(testForm) }}, renders exactly that.

So findDomElement() matches the container, and initModel() then moves the root element to the form. The element is attached to two nodes, and detachElement() only took one of them back.

1. The documented "remove, then initialize again" flow throws.removeModel() left jsFormValidator on the container, and the next addModel() read it back through attachElement(), which re-reads element.domNode.jsFormValidator on every iteration while the loop itself overwrites domNode — TypeError: Cannot read properties of undefined (reading 'callbacks').

2. removeForm(document.getElementById('user')) removed nothing.getElementById() answers with the container; the registry held the form. The call in 3_24.md returned false.

3. removeModel() left the container attached to the removed element, which is the reference the description of this PR says is taken back.

4. removeDetachedForms() dropped live registrations. A model rendered outside of any <form> has no root node at all — initModel() allows it — and domNode && document.contains(domNode) counted it as detached while its widgets were in the document.

5. Regression: the submit listener went with the first element removed from a form. Two models rooted in one <form> validated twice per submit before this PR and once after it, which is the improvement; after removeModel() of either one, the form was validated zero times. The listener resolves its element from the node at submit time, so it belongs to the node, not to one of its models.

Fixed in e75a67a

• SvarohJsFormElement.widgetDomNode holds the node the model id matched, written after attachElement() so a second model in the same form cannot hand this element its container.
• detachElement() takes both nodes back through detachNode(), which keeps the submit listener for as long as an element is attached to the node.
• removeForm() answers to either node; removeDetachedForms() asks isElementInDocument(), which looks at the whole element and its children.
• attachElement() reads the attached element once instead of re-reading it through a domNode it has already overwritten.
• keepFormInstances() is replaceFormInstances(), the internal helpers say so in their docblocks, and an id nothing was removed from keeps the array the registry already handed out.
• 3_24.md explains why getElementById() answers with the container and what removeDetachedForms() looks at.

Ten more tests, on the markup Symfony renders: attachment to both nodes, removeModel() clearing both, re-initialization of the same markup, removeForm() by the container, a model with no form tag (as a container and rendered row by row), two models in one form, plus the forms[id] repointing branch that no test reached and detachElement(null).

npx jest: 625 pass (615 before). npm run test:coverage: JavaScript line coverage 94.96%, threshold 80%, no uncovered line left in the new code. PHP is untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

[66Ton99]

Problem

addModel() keeps every render in forms and formInstances, and nothing takes one back out. A page that swaps rendered forms in and out of the document — a single page CRUD, a modal that loads its form — registers a model per render, so:

• the registry grows with elements whose markup has already been removed, and getFormInstances(id) answers with them;
• those elements keep the removed nodes alive through element.domNode and domNode.jsFormValidator;
• initModel() calls attachDefaultEvent() unconditionally, so re-initializing the same markup stacks a second submit listener on the form and runs the whole validation twice for one submit.

Change

Three public methods, each detaching the model from the DOM nodes of the element and its children and removing the submit listener this library put on the form:

SvarohJsFormValidator.removeModel('user');// every render of one model idSvarohJsFormValidator.removeForm(document.getElementById('user'));// one rendered formSvarohJsFormValidator.removeDetachedForms();// every form no longer in the document

removeModel() answers with the number of removed registrations, removeForm() with whether it removed one, removeDetachedForms() with the number it removed. When the last registration of an id is removed, the id leaves forms as well, so the registry never answers with an element it no longer holds.

attachDefaultEvent() now keeps its listener on the node and replaces it, so initializing the same markup again validates the form once per submit instead of twice.

Nothing changes for a page that never removes a form.

Docs

New src/Resources/doc/3_24.md, linked from the README list.

Tests

Seven Jest tests in SvarohJsFormValidator.test.js covering each method, the unknown-id and unknown-node cases, that a removed form no longer runs validation on submit, and that a second initialization of the same markup does not validate twice.

npx jest — 615 tests pass (608 before). PHP checks are untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

🤖 Generated with Claude Code

[66Ton99]

Review

Reviewed in a separate worktree, with every finding reproduced by running the code rather than by reading it. Four defects and one regression, all with the same root cause.

The seven new tests and both doc examples are built on <form id="profile">. That is not what Symfony renders: form_start() writes <form name="profile" method="post"> with no id, and form_widget() puts the id of the model on the container it writes inside the form (form_widget_compound → widget_container_attributes). The e2e fixture of this repository, {{ form(testForm) }}, renders exactly that.

So findDomElement() matches the container, and initModel() then moves the root element to the form. The element is attached to two nodes, and detachElement() only took one of them back.

1. The documented "remove, then initialize again" flow throws.removeModel() left jsFormValidator on the container, and the next addModel() read it back through attachElement(), which re-reads element.domNode.jsFormValidator on every iteration while the loop itself overwrites domNode — TypeError: Cannot read properties of undefined (reading 'callbacks').

2. removeForm(document.getElementById('user')) removed nothing.getElementById() answers with the container; the registry held the form. The call in 3_24.md returned false.

3. removeModel() left the container attached to the removed element, which is the reference the description of this PR says is taken back.

4. removeDetachedForms() dropped live registrations. A model rendered outside of any <form> has no root node at all — initModel() allows it — and domNode && document.contains(domNode) counted it as detached while its widgets were in the document.

5. Regression: the submit listener went with the first element removed from a form. Two models rooted in one <form> validated twice per submit before this PR and once after it, which is the improvement; after removeModel() of either one, the form was validated zero times. The listener resolves its element from the node at submit time, so it belongs to the node, not to one of its models.

Fixed in e75a67a

• SvarohJsFormElement.widgetDomNode holds the node the model id matched, written after attachElement() so a second model in the same form cannot hand this element its container.
• detachElement() takes both nodes back through detachNode(), which keeps the submit listener for as long as an element is attached to the node.
• removeForm() answers to either node; removeDetachedForms() asks isElementInDocument(), which looks at the whole element and its children.
• attachElement() reads the attached element once instead of re-reading it through a domNode it has already overwritten.
• keepFormInstances() is replaceFormInstances(), the internal helpers say so in their docblocks, and an id nothing was removed from keeps the array the registry already handed out.
• 3_24.md explains why getElementById() answers with the container and what removeDetachedForms() looks at.

Ten more tests, on the markup Symfony renders: attachment to both nodes, removeModel() clearing both, re-initialization of the same markup, removeForm() by the container, a model with no form tag (as a container and rendered row by row), two models in one form, plus the forms[id] repointing branch that no test reached and detachElement(null).

npx jest: 625 pass (615 before). npm run test:coverage: JavaScript line coverage 94.96%, threshold 80%, no uncovered line left in the new code. PHP is untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

[66Ton99]

Problem

addModel() keeps every render in forms and formInstances, and nothing takes one back out. A page that swaps rendered forms in and out of the document — a single page CRUD, a modal that loads its form — registers a model per render, so:

• the registry grows with elements whose markup has already been removed, and getFormInstances(id) answers with them;
• those elements keep the removed nodes alive through element.domNode and domNode.jsFormValidator;
• initModel() calls attachDefaultEvent() unconditionally, so re-initializing the same markup stacks a second submit listener on the form and runs the whole validation twice for one submit.

Change

Three public methods, each detaching the model from the DOM nodes of the element and its children and removing the submit listener this library put on the form:

SvarohJsFormValidator.removeModel('user');// every render of one model idSvarohJsFormValidator.removeForm(document.getElementById('user'));// one rendered formSvarohJsFormValidator.removeDetachedForms();// every form no longer in the document

removeModel() answers with the number of removed registrations, removeForm() with whether it removed one, removeDetachedForms() with the number it removed. When the last registration of an id is removed, the id leaves forms as well, so the registry never answers with an element it no longer holds.

attachDefaultEvent() now keeps its listener on the node and replaces it, so initializing the same markup again validates the form once per submit instead of twice.

Nothing changes for a page that never removes a form.

Docs

New src/Resources/doc/3_24.md, linked from the README list.

Tests

Seven Jest tests in SvarohJsFormValidator.test.js covering each method, the unknown-id and unknown-node cases, that a removed form no longer runs validation on submit, and that a second initialization of the same markup does not validate twice.

npx jest — 615 tests pass (608 before). PHP checks are untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.

🤖 Generated with Claude Code

[66Ton99]

Review

Reviewed in a separate worktree, with every finding reproduced by running the code rather than by reading it. Four defects and one regression, all with the same root cause.

The seven new tests and both doc examples are built on <form id="profile">. That is not what Symfony renders: form_start() writes <form name="profile" method="post"> with no id, and form_widget() puts the id of the model on the container it writes inside the form (form_widget_compound → widget_container_attributes). The e2e fixture of this repository, {{ form(testForm) }}, renders exactly that.

So findDomElement() matches the container, and initModel() then moves the root element to the form. The element is attached to two nodes, and detachElement() only took one of them back.

1. The documented "remove, then initialize again" flow throws.removeModel() left jsFormValidator on the container, and the next addModel() read it back through attachElement(), which re-reads element.domNode.jsFormValidator on every iteration while the loop itself overwrites domNode — TypeError: Cannot read properties of undefined (reading 'callbacks').

2. removeForm(document.getElementById('user')) removed nothing.getElementById() answers with the container; the registry held the form. The call in 3_24.md returned false.

3. removeModel() left the container attached to the removed element, which is the reference the description of this PR says is taken back.

4. removeDetachedForms() dropped live registrations. A model rendered outside of any <form> has no root node at all — initModel() allows it — and domNode && document.contains(domNode) counted it as detached while its widgets were in the document.

5. Regression: the submit listener went with the first element removed from a form. Two models rooted in one <form> validated twice per submit before this PR and once after it, which is the improvement; after removeModel() of either one, the form was validated zero times. The listener resolves its element from the node at submit time, so it belongs to the node, not to one of its models.

Fixed in e75a67a

• SvarohJsFormElement.widgetDomNode holds the node the model id matched, written after attachElement() so a second model in the same form cannot hand this element its container.
• detachElement() takes both nodes back through detachNode(), which keeps the submit listener for as long as an element is attached to the node.
• removeForm() answers to either node; removeDetachedForms() asks isElementInDocument(), which looks at the whole element and its children.
• attachElement() reads the attached element once instead of re-reading it through a domNode it has already overwritten.
• keepFormInstances() is replaceFormInstances(), the internal helpers say so in their docblocks, and an id nothing was removed from keeps the array the registry already handed out.
• 3_24.md explains why getElementById() answers with the container and what removeDetachedForms() looks at.

Ten more tests, on the markup Symfony renders: attachment to both nodes, removeModel() clearing both, re-initialization of the same markup, removeForm() by the container, a model with no form tag (as a container and rendered row by row), two models in one form, plus the forms[id] repointing branch that no test reached and detachElement(null).

npx jest: 625 pass (615 before). npm run test:coverage: JavaScript line coverage 94.96%, threshold 80%, no uncovered line left in the new code. PHP is untouched by this change; the host PHP here is 8.3, below the ^8.4 requirement, so composer test was not run.