Skip to content

GH-744 - Self Review - #1

Open
Syther007 wants to merge 113 commits into
masterfrom
GH-744
Open

GH-744 - Self Review#1
Syther007 wants to merge 113 commits into
masterfrom
GH-744

Conversation

@Syther007

@Syther007Syther007 commented Sep 3, 2024

Copy link
Copy Markdown
Owner

No description provided.

@Syther007
Added base comments
e908666
@Syther007
MASQ-ProjectGH-744: removed .wait() from handle_request_balances_to_p…
8b71081
…ay_payables
@Syther007
MASQ-ProjectGH-744: added future return type to get_transaction_fee_b…
99e36a5
…alance
@Syther007
Fixed error mapping for .get_token_balance
4fba6f1
@Syther007
MASQ-ProjectGH-744: Fixed failing tests, all tests passing
7d0d075
@Syther007
MASQ-ProjectGH-744: Added future return to ReportAccountsPayable
159ad22
@Syther007
MASQ-ProjectGH-744: Fixed more errors
5b25bce
@Syther007
MASQ-ProjectGH-744: Added batch lifetime
ffe6b81
@Syther007
Revert "MASQ-ProjectGH-744: Added batch lifetime"
cb2f3e4
This reverts commit ffe6b81.
@Syther007
MASQ-ProjectGH-744: Fixed more errors
e5482f7
@Syther007
MASQ-ProjectGH-744: small clean up
8093caf
@Syther007
MASQ-ProjectGH-744: Moved batch_payable_tools functions
85529d0
@Syther007
MASQ-ProjectGH-744: send_payables_within_batch accounts changed to Vec
aa811db
@Syther007
MASQ-ProjectGH-744: added blockchain_interface_slim
d1659ec
@Syther007
Added blockchain_interface_utils.js
0877056
@Syther007
MASQ-ProjectGH-744: process_payments is working with futures
a075b5d
@Syther007
MASQ-ProjectGH-744: Fixed a few more tests in blockchain_interface_utils
70ee731
@Syther007
MASQ-ProjectGH-744: Fixed test useing test_gas_limit_is_between_limits
2f03dbe
@Syther007
Changed sign_transaction_data amount data type to u128
ba6a7f9
@Syther007
MASQ-ProjectGH-744converted handle_retrieve_transactions return type…
c7725b1
… to future
@Syther007
MASQ-ProjectGH-744: Fixed some error with handle_retrieve_transactions
2a16982
@Syther007
MASQ-ProjectGH-744: update_start_block_message_works test works
93189ec
@Syther007
MASQ-ProjectGH-744: Added get_batch_web3 Mock
231cce3
@Syther007
MASQ-ProjectGH-744: Fixed test report_accounts_payable_returns_error_…
25593c5
…fetching_pending_nonce
@Syther007
MASQ-ProjectGH-744: fixed test process_payments_returns_error_from_se…
c313533
…nding_batch
@Syther007
MASQ-ProjectGH-744: fixed test handle_report_accounts_payable_transmi…
e771cd5
…ts_eleventh_hour_error_back_to_accountant
@Syther007
MASQ-ProjectGH-744: Edited test handle_report_accounts_payable_transa…
d3a3694
…cts_and_sends_finished_payments_back_to_accountant
@Syther007
MASQ-ProjectGH-744: updated test handle_report_accounts_payable_trans…
6c6a146
…acts_and_sends_finished_payments_back_to_accountant
@Syther007
MASQ-ProjectGH-744: FIxed test handle_retrieve_transactions_sends_rec…
e645549
…eived_payments_back_to_accountant
@Syther007
MASQ-ProjectGH-744: Update to test processing_of_received_payments_co…
5e1dac1
…ntinues_even_if_no_payments_are_detected
@Syther007
MASQ-ProjectGH-744: all tests within lower_level_interface are now wo…
7fb5a3b
…rking
@Syther007
MASQ-ProjectGH-744: Moved get_transaction_receipt_batch to lower_leve…
a32fabe
…l_interface
@Syther007
MASQ-ProjectGH-744: Added tests for transaction_receipt_batch
cee7825
@Syther007
MASQ-ProjectGH-744: All tests passing on blockchain_birdge
df499b6
@Syther007
MASQ-ProjectGH-744: added fn get_transaction_logs to lower_level_inte…
c6c79f4
…rface
@Syther007
MASQ-ProjectGH-744: added fn submit_payables_in_batch to lower_level_…
591e074
…interface
@Syther007
MASQ-ProjectGH-744: removed unnecessary functions from BlockchainInte…
1d9dffc
…rface
@Syther007
MASQ-ProjectGH-744: Todo clean up
236247c
@Syther007
MASQ-ProjectGH-744: test: pending_transaction_is_registered_and_monit…
3108a0b
…ored_until_it_gets_confirmed_or_canceled is working
@Syther007
MASQ-ProjectGH-744: clean up & all tests pasing
00661b8
@Syther007
MASQ-ProjectGH-744: cleanup of more todos
108fbaa
@Syther007
Merge branch 'master' ofhttps://github.com/MASQ-Project/NodeintoMA…
ff74544
…SQ-ProjectGH-744-merge-test
@Syther007
MASQ-ProjectGH-744: Compiling after merge
2288287
@Syther007
MASQ-ProjectGH-744: all but 1 tests are passing after merge
00cc396
@Syther007
MASQ-ProjectGH-744: Fixed pending_transaction_is_registered_and_monit…
f904a71
…ored_until_it_gets_confirmed_or_canceled again
@Syther007
MASQ-ProjectGH-744: Removed all warnings
b60a6a8
@Syther007
MASQ-ProjectGH-744: Formatting
5598918
@Syther007
MASQ-ProjectGH-744: fixed all clippys warnings
01ff73c
@Syther007
MASQ-ProjectGH-744: multinode tests running, but failing on MBCS
8a3f1e7
@Syther007
MASQ-ProjectGH-744fixed more multinode tests
fed2a85
@Syther007
MASQ-ProjectGH-744: Added check for wildcard ip inside neighborhood
cfdb772
@Syther007
MASQ-ProjectGH-744: Fixed all multinode intergration tests
d54a3d0
@Syther007
MASQ-ProjectGH-744: All tests are passing!
e677373
@Syther007
MASQ-ProjectGH-744: fixed test send_payables_within_batch_fails_on_su…
1f5940d
…bmit_batch_call for windows
@Syther007
MASQ-ProjectGH-744: fixed handle_scan_future tests
0ea951c
@Syther007
MASQ-ProjectGH-744: Added a fallback blockchain_service_url
aee1544
Syther007
Syther007 commented Sep 3, 2024
View reviewed changes

@Syther007Syther007 left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed files with small changes

Comment threadmultinode_integration_tests/docker/blockchain/arm64_linux/entrypoint.sh
Comment threadmultinode_integration_tests/docker/blockchain/amd64_linux/entrypoint.sh
Comment threadmultinode_integration_tests/src/blockchain.rs
Comment threadmultinode_integration_tests/src/utils.rs
Comment threadnode/src/accountant/db_access_objects/pending_payable_dao.rs
Comment threadnode/src/blockchain/blockchain_interface/lower_level_interface.rs
Comment threadnode/src/blockchain/blockchain_interface/mod.rs
Comment threadnode/src/neighborhood/mod.rs
Comment threadnode/src/sub_lib/blockchain_bridge.rs
Comment threadnode/src/test_utils/http_test_server.rs
Syther007
Syther007 commented Sep 4, 2024
View reviewed changes

@Syther007Syther007 left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node/src/blockchain/blockchain_bridge.rs Line: 157

Comment threadmultinode_integration_tests/src/mock_blockchain_client_server.rs
Comment threadnode/src/accountant/mod.rs
Comment threadnode/src/accountant/mod.rs
Comment threadnode/src/accountant/mod.rs
Comment threadnode/src/accountant/mod.rs
Comment threadnode/src/accountant/scanners/mod.rs
Syther007
Syther007 commented Sep 4, 2024
View reviewed changes

@Syther007Syther007 left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop at node/src/blockchain/blockchain_bridge.rs 1565

Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Syther007
Syther007 commented Sep 9, 2024
View reviewed changes
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_bridge.rs
Comment threadnode/src/blockchain/blockchain_interface_utils.rs
Comment threadnode/src/blockchain/blockchain_interface_utils.rs
Comment threadnode/src/blockchain/blockchain_interface_utils.rs
Comment threadnode/src/blockchain/blockchain_interface_utils.rs
Comment threadnode/src/blockchain/blockchain_interface_utils.rs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Syther007@utkarshg6