Uh oh!
There was an error while loading. Please reload this page.
Add crs and bin size metadata fields to VariableMetadata - #794
Conversation
Add crs, bin_inl, and bin_xl optional fields to support coordinate reference system and bin size metadata for seismic data variables. Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #794 +/- ##
==========================================
+ Coverage 85.30% 92.99% +7.68%
==========================================
Files 46 143 +97 Lines 2219 8162 +5943 Branches 306 462 +156 ==========================================
+ Hits 1893 7590 +5697 - Misses 281 498 +217 - Partials 45 74 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| description="Minimal summary statistics.", | ||
| ) | ||
| crs: str | None = Field( |
There was a problem hiding this comment.
I don't think a string CRS will be sufficient here. We should have support for the most common expected systems. An example of making it more usable might be:
{
"CRS": {
"type": "EPSG",
"code": 1234
}
}There are probably several projection systems that we should support, if you could please take a look.
You can see how we might want to structure this as a set of enums similar to unitsV1. We will want to leave an escape hatch for custom free-form CRS data as well.
| description="Coordinate Reference System as an EPSG code (e.g., 'EPSG:4326').", | ||
| ) | ||
| bin_inl: float | None = Field( |
There was a problem hiding this comment.
bin_inl and bin_xl are too specific to a use-cases with 3D poststack data. I would recommend looking into adding it in dimensions.py and updating its key to be nominal_bin to support non-binned data as well.
Adds three optional fields to VariableMetadata for seismic survey geometry:
Includes test coverage.