Skip to content

Add single node CRG template - #861

Merged
BrianMichell merged 2 commits into
TGSAI:mainfrom
BrianMichell:feat/single-node-cont-recvr-gathers
Aug 21, 2026
Merged

Add single node CRG template#861
BrianMichell merged 2 commits into
TGSAI:mainfrom
BrianMichell:feat/single-node-cont-recvr-gathers

Conversation

@BrianMichell

Copy link
Copy Markdown
Collaborator

Implements the CRG template. Currently uses a placeholder name until a better one can be settled on.

@BrianMichellBrianMichell added the enhancement New feature or request label Aug 5, 2026
@codecov

codecovBot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.06%. Comparing base (c3ba558) to head (00f7054).
⚠️ Report is 250 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #861 +/- ##
==========================================
+ Coverage 85.30% 93.06% +7.75% 
==========================================
Files 46 147 +101 Lines 2219 8406 +6187 Branches 306 469 +163 ==========================================
+ Hits 1893 7823 +5930 - Misses 281 509 +228 - Partials 45 74 +29 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andgineer

Copy link
Copy Markdown

Default chunk is (1, 512, 4096) — that splits our ~30k-sample CRG traces on time.

We're on (1, 512, 32768) so a whole trace stays one chunk. Can you flip the template default to that?

@andgineer

Copy link
Copy Markdown

Hit the BloscCname / pydantic import crash on this tip with zarr>=3.3.0.

Looks like the zarr pin (or the #852 Blosc fix) made it onto the multi-node CRG PR but not this one.
Can you carry it here too?

@BrianMichell

Copy link
Copy Markdown
CollaboratorAuthor

Hit the BloscCname / pydantic import crash on this tip with zarr>=3.3.0.

Looks like the zarr pin (or the #852 Blosc fix) made it onto the multi-node CRG PR but not this one. Can you carry it here too?

Problem resolved offline.

This particular issue seems to have been an environment issue and is unrelated to the actual PR.

@BrianMichell
BrianMichell merged commit a2895b5 into TGSAI:mainAug 21, 2026
10 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BrianMichell@andgineer