Uh oh!
There was an error while loading. Please reload this page.
feat: error handling for pretty-printer (local and remote); detect duplicate formula names - #5
Merged
Merged
Conversation
… move cursor to position if the error message contains a position
- It takes up too much space in editor that could be used to display open tabs. - The command `TPTP: Format Document` will eventually be removed in favor of `TPTP: Format TPTP File` which calls JJParser locally. But at present, the former command should be kept as it supports range formatting (albeit with known bugs) while the latter doesn't.
CollaboratorAuthor
I'm removing the button for "TPTP: Format Document" because:
|
…handling for remote pretty-printer
…display error message and jump to position of syntax error.
…acter "."` emitted by JJParser's `CharacterError`
…s on edits or new pretty-printer runs.
…me command from `tptp.formatProblem` to `tptp.prettyPrint`
…eck Syntax and Format TPTP File"; move icons into `images/icons`
…ax and Format TPTP File"; improved error handling for pretty-printer.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user executes command "TPTP: Format TPTP File", JJParser runs locally to pretty-print the source file. Currently, JJParser's error messages are ignored.
This pull request handles these error messages so that whenever the local JJParser reports an error, it is shown as a toast in VSCode, the cursor is moved to the position of the error (if the error contains the description of a location), and a diagnostic (i.e., a hoverable squiggle) is shown under the problematic token or character. Stale diagnostic is cleared on any edit or new pretty-printer run in the current document.