Skip to content

Abstract tabular dataset loading - #274

Open
mttk wants to merge 10 commits into
masterfrom
abstract_tabular_loading
Open

Abstract tabular dataset loading#274
mttk wants to merge 10 commits into
masterfrom
abstract_tabular_loading

Conversation

@mttk

@mttkmttk commented Jan 14, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Closes#273

Draft, function calls and names subject to change, but the gist is here.

@mttkmttk mentioned this pull request Jan 14, 2021
Open
@mttkmttk self-assigned this Jan 14, 2021
ivansmokovic
ivansmokovic requested changes Jan 14, 2021
View reviewed changes

@ivansmokovicivansmokovic left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Some nitpicks.
Not an actual review, just wanted to point some things out.

Comment threadpodium/datasets/arrow_tabular_dataset.py Outdated
Comment threadpodium/datasets/tabular_dataset.py Outdated
Comment threadpodium/datasets/tabular_dataset.py
Comment threadpodium/datasets/tabular_dataset.py Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariosaskomariosaskoAwaiting requested review from mariosasko
@FilipBoltFilipBoltAwaiting requested review from FilipBolt
@ivansmokovicivansmokovicAwaiting requested review from ivansmokovic

Requested changes must be addressed to merge this pull request.

Assignees

@mttkmttk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove from_tabular_file in ArrowDataset

2 participants

@mttk@ivansmokovic