docs(contract): sync open items and behavior with the shipped firmware - #48
Open
TalkingJupiter wants to merge 1 commit into
Open
docs(contract): sync open items and behavior with the shipped firmware#48TalkingJupiter wants to merge 1 commit into
TalkingJupiter wants to merge 1 commit into
Conversation
#18 (config mac self-check) and #19 (accept enabled:false) are both implemented and closed, but §10 still listed them as open and §4 still warned that the firmware rejects enabled:false. Three other places had drifted from the code: - §5 omitted firmware_version, which the hello payload has carried since the OTA work, and gave the cadence as 60 s where HELLO_INTERVAL_MS is 10 s. - §7 said provisioning answers an unknown device with configured:false. It now records the mac in unknown_devices and sends no reply, so the device stays unconfigured and keeps helloing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contract had drifted from the shipped firmware in five places.
Closed issues still listed as open
#18 (config
macself-check) and #19 (acceptenabled: false) are both implemented and closed, but §10 still had them unchecked and §4 still carried the warning that "current firmware still rejectsenabled: falseand must be changed to match".Hello message was wrong
§5 omitted
firmware_version, which the payload has carried since the OTA work and which provisioning reads on every hello, and gave the cadence as 60 s whereHELLO_INTERVAL_MSis 10 s.Unknown-device behavior changed
§7 said provisioning answers an unknown device with
configured:false. It now records the MAC inunknown_devicesand sends no reply, so the device stays unconfigured and keeps helloing. That silence is intentional, so the doc should say so.Docs only, no code changes.