Skip to content

feat(ai-byteplus): add 1080p support for Seedance 2.5 - #1149

Merged
AlemTuzlak merged 1 commit into
mainfrom
1146-1080p-support-for-seedance-25
Aug 19, 2026
Merged

feat(ai-byteplus): add 1080p support for Seedance 2.5#1149
AlemTuzlak merged 1 commit into
mainfrom
1146-1080p-support-for-seedance-25

Conversation

@tombeckenham

@tombeckenhamtombeckenham commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Allow 1080p on Seedance 2.5 (dreamina-seedance-2-5-260628). BytePlus previously treated this model as 480p/720p only and rejected size: '16:9_1080p' locally.
  • Keep rejecting 4k on 2.5. Default remains 720p.
  • Update docs, Seedance Studio blurb, unit tests, and an e2e wire check that the create-task body sends resolution: "1080p".

Source of truth: BytePlus ModelArk plus the live fal Seedance 2.5 spec on modelschemas.com (resolution enum 480p | 720p | 1080p). OpenRouter's catalog still reports 480p/720p only, so that generated table is left alone.

Fixes#1146

Test plan

  • pnpm --filter @tanstack/ai-byteplus test:lib (282 passed)
  • pnpm --filter @tanstack/ai-byteplus test:types
  • pnpm --filter @tanstack/ai-e2e test:e2e -- tests/byteplus-seedance-1080p-wire.spec.ts
  • pnpm test:docs
  • pnpm test:pr on CI

Summary by CodeRabbit

  • New Features

    • Seedance 2.5 now supports native 1080p video generation.
    • Available resolutions include 480p, 720p, and 1080p; 720p remains the default.
    • Seedance 2.5 continues to exclude 2K and 4K output.
  • Documentation

    • Updated BytePlus, video generation, and model catalog documentation with the latest resolution and capability details.
  • Tests

    • Added coverage validating successful Seedance 2.5 1080p requests and continued 4K rejection.

Seedance 2.5 now accepts native 480p/720p/1080p (default 720p). 4k
remains exclusive to dreamina-seedance-2-0-260128.
@tombeckenhamtombeckenham linked an issue Aug 19, 2026 that may be closed by this pull request
@coderabbitai

coderabbitaiBot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a655a1d-6a0e-4b74-9789-c0e9eae6b132

📥 Commits

Reviewing files that changed from the base of the PR and between 2822885 and ce4f5e8.

📒 Files selected for processing (11)
  • .changeset/seedance-25-1080p.md
  • docs/adapters/byteplus.md
  • docs/config.json
  • docs/media/video-generation.md
  • examples/ts-react-media/src/lib/seedance.ts
  • packages/ai-byteplus/src/model-meta.ts
  • packages/ai-byteplus/src/video/video-provider-options.ts
  • packages/ai-byteplus/tests/video.test.ts
  • testing/e2e/src/routeTree.gen.ts
  • testing/e2e/src/routes/api.byteplus-seedance-1080p-wire.ts
  • testing/e2e/tests/byteplus-seedance-1080p-wire.spec.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Seedance 2.5 now supports native 1080p in BytePlus metadata, types, validation, documentation, examples, and tests. A new end-to-end route verifies that 16:9_1080p reaches BytePlus and returns the captured wire request.

Changes

Seedance 2.5 1080p support

Layer / File(s)Summary
Capability contracts and documentation
packages/ai-byteplus/src/model-meta.ts, packages/ai-byteplus/src/video/video-provider-options.ts, packages/ai-byteplus/tests/video.test.ts, docs/adapters/byteplus.md, docs/media/video-generation.md, examples/ts-react-media/src/lib/seedance.ts, .changeset/seedance-25-1080p.md, docs/config.json
Adds 1080p to the Seedance 2.5 resolution type and capability metadata. Tests accept 1080p and continue to reject 4K. Documentation and examples retain 720p as the default.
1080p wire regression route
testing/e2e/src/routes/api.byteplus-seedance-1080p-wire.ts, testing/e2e/src/routeTree.gen.ts, testing/e2e/tests/byteplus-seedance-1080p-wire.spec.ts
Adds a BytePlus wire route that invokes Seedance 2.5 with 16:9_1080p, captures model and resolution, and exposes the result for Playwright validation. The generated route tree registers the endpoint.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk:⚪ Minimal · up to ce4f5

This is a localized Seedance 2.5 resolution-support change with focused tests and documentation updates; no actionable merge-blocking risk remains at the current head after normal checks.

Sequence Diagram(s)

sequenceDiagram
participant Playwright
participant Seedance1080pRoute
participant BytePlusAdapter
participant BytePlusAPI
Playwright->>Seedance1080pRoute: POST 1080p wire-check request
Seedance1080pRoute->>BytePlusAdapter: generateVideo with 16:9_1080p
BytePlusAdapter->>BytePlusAPI: create-task request
BytePlusAPI-->>Seedance1080pRoute: job ID and request result
Seedance1080pRoute-->>Playwright: JSON with model, resolution, status, and job ID
Loading

Possibly related PRs

  • TanStack/ai#1035: Introduced the Seedance model metadata, provider options, documentation, and tests extended by this change.
  • TanStack/ai#1060: Added related Seedance 2.5 capability definitions, examples, documentation, and tests.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the primary change: adding 1080p support for Seedance 2.5.
Description check✅ PassedThe description explains the change, scope, tests, linked issue, and pending CI test; it is mostly complete despite different section headings.
Linked Issues check✅ PassedThe PR satisfies issue #1146 by adding 1080p support, preserving 720p defaults, rejecting 4K on 2.5, and updating tests and documentation.
Out of Scope Changes check✅ PassedThe changes remain within scope and do not alter duration, reference limits, or unrelated OpenRouter and fal catalogs.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1146-1080p-support-for-seedance-25

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloudBot commented Aug 19, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit ce4f5e8

CommandStatusDurationResult
nx run-many --targets=build --exclude=examples/...✅ Succeeded3sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-19 03:04:17 UTC

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@tanstack/ai

npm i https://pkg.pr.new/@tanstack/ai@1149

@tanstack/ai-acp

npm i https://pkg.pr.new/@tanstack/ai-acp@1149

@tanstack/ai-angular

npm i https://pkg.pr.new/@tanstack/ai-angular@1149

@tanstack/ai-anthropic

npm i https://pkg.pr.new/@tanstack/ai-anthropic@1149

@tanstack/ai-bedrock

npm i https://pkg.pr.new/@tanstack/ai-bedrock@1149

@tanstack/ai-byteplus

npm i https://pkg.pr.new/@tanstack/ai-byteplus@1149

@tanstack/ai-claude-code

npm i https://pkg.pr.new/@tanstack/ai-claude-code@1149

@tanstack/ai-client

npm i https://pkg.pr.new/@tanstack/ai-client@1149

@tanstack/ai-code-mode

npm i https://pkg.pr.new/@tanstack/ai-code-mode@1149

@tanstack/ai-code-mode-snippets

npm i https://pkg.pr.new/@tanstack/ai-code-mode-snippets@1149

@tanstack/ai-codex

npm i https://pkg.pr.new/@tanstack/ai-codex@1149

@tanstack/ai-cohere

npm i https://pkg.pr.new/@tanstack/ai-cohere@1149

@tanstack/ai-devtools-core

npm i https://pkg.pr.new/@tanstack/ai-devtools-core@1149

@tanstack/ai-durable-stream

npm i https://pkg.pr.new/@tanstack/ai-durable-stream@1149

@tanstack/ai-elevenlabs

npm i https://pkg.pr.new/@tanstack/ai-elevenlabs@1149

@tanstack/ai-event-client

npm i https://pkg.pr.new/@tanstack/ai-event-client@1149

@tanstack/ai-fal

npm i https://pkg.pr.new/@tanstack/ai-fal@1149

@tanstack/ai-gemini

npm i https://pkg.pr.new/@tanstack/ai-gemini@1149

@tanstack/ai-grok

npm i https://pkg.pr.new/@tanstack/ai-grok@1149

@tanstack/ai-grok-build

npm i https://pkg.pr.new/@tanstack/ai-grok-build@1149

@tanstack/ai-groq

npm i https://pkg.pr.new/@tanstack/ai-groq@1149

@tanstack/ai-isolate-cloudflare

npm i https://pkg.pr.new/@tanstack/ai-isolate-cloudflare@1149

@tanstack/ai-isolate-daytona

npm i https://pkg.pr.new/@tanstack/ai-isolate-daytona@1149

@tanstack/ai-isolate-node

npm i https://pkg.pr.new/@tanstack/ai-isolate-node@1149

@tanstack/ai-isolate-quickjs

npm i https://pkg.pr.new/@tanstack/ai-isolate-quickjs@1149

@tanstack/ai-isolate-quickjs-bun

npm i https://pkg.pr.new/@tanstack/ai-isolate-quickjs-bun@1149

@tanstack/ai-mcp

npm i https://pkg.pr.new/@tanstack/ai-mcp@1149

@tanstack/ai-memory

npm i https://pkg.pr.new/@tanstack/ai-memory@1149

@tanstack/ai-mistral

npm i https://pkg.pr.new/@tanstack/ai-mistral@1149

@tanstack/ai-ollama

npm i https://pkg.pr.new/@tanstack/ai-ollama@1149

@tanstack/ai-openai

npm i https://pkg.pr.new/@tanstack/ai-openai@1149

@tanstack/ai-opencode

npm i https://pkg.pr.new/@tanstack/ai-opencode@1149

@tanstack/ai-openrouter

npm i https://pkg.pr.new/@tanstack/ai-openrouter@1149

@tanstack/ai-perplexity

npm i https://pkg.pr.new/@tanstack/ai-perplexity@1149

@tanstack/ai-persistence

npm i https://pkg.pr.new/@tanstack/ai-persistence@1149

@tanstack/ai-preact

npm i https://pkg.pr.new/@tanstack/ai-preact@1149

@tanstack/ai-react

npm i https://pkg.pr.new/@tanstack/ai-react@1149

@tanstack/ai-react-ui

npm i https://pkg.pr.new/@tanstack/ai-react-ui@1149

@tanstack/ai-sandbox

npm i https://pkg.pr.new/@tanstack/ai-sandbox@1149

@tanstack/ai-sandbox-cloudflare

npm i https://pkg.pr.new/@tanstack/ai-sandbox-cloudflare@1149

@tanstack/ai-sandbox-daytona

npm i https://pkg.pr.new/@tanstack/ai-sandbox-daytona@1149

@tanstack/ai-sandbox-docker

npm i https://pkg.pr.new/@tanstack/ai-sandbox-docker@1149

@tanstack/ai-sandbox-local-process

npm i https://pkg.pr.new/@tanstack/ai-sandbox-local-process@1149

@tanstack/ai-sandbox-sprites

npm i https://pkg.pr.new/@tanstack/ai-sandbox-sprites@1149

@tanstack/ai-sandbox-vercel

npm i https://pkg.pr.new/@tanstack/ai-sandbox-vercel@1149

@tanstack/ai-solid

npm i https://pkg.pr.new/@tanstack/ai-solid@1149

@tanstack/ai-solid-ui

npm i https://pkg.pr.new/@tanstack/ai-solid-ui@1149

@tanstack/ai-svelte

npm i https://pkg.pr.new/@tanstack/ai-svelte@1149

@tanstack/ai-utils

npm i https://pkg.pr.new/@tanstack/ai-utils@1149

@tanstack/ai-vercel-gateway

npm i https://pkg.pr.new/@tanstack/ai-vercel-gateway@1149

@tanstack/ai-vue

npm i https://pkg.pr.new/@tanstack/ai-vue@1149

@tanstack/ai-vue-ui

npm i https://pkg.pr.new/@tanstack/ai-vue-ui@1149

@tanstack/openai-base

npm i https://pkg.pr.new/@tanstack/openai-base@1149

@tanstack/preact-ai-devtools

npm i https://pkg.pr.new/@tanstack/preact-ai-devtools@1149

@tanstack/react-ai-devtools

npm i https://pkg.pr.new/@tanstack/react-ai-devtools@1149

@tanstack/solid-ai-devtools

npm i https://pkg.pr.new/@tanstack/solid-ai-devtools@1149

commit: ce4f5e8

@github-actionsgithub-actionsBot added the waiting-on: maintainer The ball is in the maintainers’ court label Aug 19, 2026
@AlemTuzlak
AlemTuzlak merged commit 870e5cc into mainAug 19, 2026
9 checks passed
@AlemTuzlak
AlemTuzlak deleted the 1146-1080p-support-for-seedance-25 branch August 19, 2026 08:35
@github-actionsgithub-actionsBot mentioned this pull request Aug 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on: maintainerThe ball is in the maintainers’ court

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1080p support for seedance 2.5

2 participants

@tombeckenham@AlemTuzlak