Uh oh!
There was an error while loading. Please reload this page.
chore(ai-event-client): drop unused @tanstack/ai peerDependency - #694
Conversation
ai-event-client mirrors the middleware types it needs locally and imports nothing from @tanstack/ai, so the peer dependency only manufactured a package-manifest cycle (@tanstack/ai already depends on ai-event-client). Remove it along with the matching `!@tanstack/ai` Nx implicitDependencies workaround so the build graph stays a clean DAG. Verified: pnpm install no longer warns about cyclic workspace dependencies; build, test:types, test:lib, and publint --strict pass, and nx affected build is clean across all consumers. ClosesTanStack#552
📝 WalkthroughWalkthroughThe PR removes the unused ChangesDrop unused peer dependency
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@tanstack/ai@tanstack/ai-anthropic@tanstack/ai-client@tanstack/ai-code-mode@tanstack/ai-code-mode-skills@tanstack/ai-devtools-core@tanstack/ai-elevenlabs@tanstack/ai-event-client@tanstack/ai-fal@tanstack/ai-gemini@tanstack/ai-grok@tanstack/ai-groq@tanstack/ai-isolate-cloudflare@tanstack/ai-isolate-node@tanstack/ai-isolate-quickjs@tanstack/ai-ollama@tanstack/ai-openai@tanstack/ai-openrouter@tanstack/ai-preact@tanstack/ai-react@tanstack/ai-react-ui@tanstack/ai-solid@tanstack/ai-solid-ui@tanstack/ai-svelte@tanstack/ai-utils@tanstack/ai-vue@tanstack/ai-vue-ui@tanstack/openai-base@tanstack/preact-ai-devtools@tanstack/react-ai-devtools@tanstack/solid-ai-devtoolscommit: |
tombeckenham
left a comment
There was a problem hiding this comment.
I've been wanting to fix this for ages. Thank you!!
Uh oh!
There was an error while loading. Please reload this page.
Closes#552.
@tanstack/ai-event-clientdeclared@tanstack/aias apeerDependencybut imports nothing from it — the middleware/usage types are mirrored locally. The only real edge runs the other way (@tanstack/aidepends onai-event-client), so the peer dep just manufactured a manifest cycle that had to be neutralised with a!@tanstack/aiNximplicitDependencieshack. This drops both.Why not
linked/fixedchangesets instead: the changeset config keeps both empty — independent versioning is the convention — andupdateInternalDependencies: patchalready bumpsaiwhenai-event-clientchanges. So straight removal; happy to revisit if you'd prefer lockstep.Verified:
pnpm installno longer warns about the cyclic workspace dependency, andbuild/test:types/test:lib(14 passing) /publint --strict/nx affected buildall pass.