fix: resolve skipLibCheck-masked dangling .d.ts imports (+ test:dts guardrail) by tombeckenham · Pull Request #924 · TanStack/ai

tombeckenham · 2026-07-10T04:21:59Z

Summary

Fix directory-barrel imports that emit as dangling ../utils.js / ../tools.js / ../middleware.js in published .d.ts (no /index fallback under bundler/node16/nodenext). Under consumer skipLibCheck those symbols silently became any — same root cause as fix(ai-gemini): resolve GeminiClientConfig from concrete module in adapter types #919, swept across 10 packages including the Gemini experimental adapter fix(ai-gemini): resolve GeminiClientConfig from concrete module in adapter types #919 missed.
Add pnpm test:dts (scripts/scan-dangling-dts.mjs) and wire it into test:pr / test:ci so regressions fail on the producer side.
Fix remaining @arethetypeswrong/cliInternalResolutionErrors under --profile esm-only: bare '.' (anthropic), extensionless model-catalog.generated (bedrock), version-dot meta basenames like model-meta-llama3.1 (ollama).

Closes#920

Test plan

pnpm test:dts clean after build:all (692 .d.ts files)
test:types green on affected packages
attw --pack --profile esm-only exit 0 for ai-anthropic, ai-bedrock, ai-ollama, ai-fal, ai-gemini
CI test:pr / full PR checks green

Summary by CodeRabbit

Bug Fixes
- Fixed published TypeScript declarations so imports resolve correctly in Node ESM and modern bundlers.
- Prevented unresolved type references from being incorrectly treated as any.
- Improved module compatibility across Anthropic, Bedrock, and Ollama integrations.
Tests
- Added automated validation to detect unresolved imports in generated declaration files before release.
- Enhanced checks for common TypeScript and ESM resolution patterns.

coderabbitai · 2026-07-10T04:24:32Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7183cada-d892-484b-ba43-23eac2719225

📥 Commits

Reviewing files that changed from the base of the PR and between d2b1e5f and 569e768.

📒 Files selected for processing (6)

.changeset/fix-dangling-dts-barrel-imports.md
nx.json
packages/ai-anthropic/src/tools/tool-converter.ts
packages/ai-bedrock/src/model-meta.ts
packages/ai-ollama/src/model-meta.ts
scripts/scan-dangling-dts.mjs

✅ Files skipped from review due to trivial changes (3)

packages/ai-bedrock/src/model-meta.ts
packages/ai-anthropic/src/tools/tool-converter.ts
.changeset/fix-dangling-dts-barrel-imports.md

🚧 Files skipped from review as they are similar to previous changes (3)

nx.json
packages/ai-ollama/src/model-meta.ts
scripts/scan-dangling-dts.mjs

📝 Walkthrough

Walkthrough

Provider package imports now use resolvable ESM and declaration paths. A recursive scanner validates built .d.ts imports, and Nx caches the new test:dts target. A Changesets entry records patch releases for the affected packages.

Changes

DTS resolution cleanup

Layer / File(s)	Summary
Provider package import paths `packages/ai-anthropic/src/tools/tool-converter.ts`, `packages/ai-bedrock/src/model-meta.ts`, `packages/ai-ollama/src/model-meta.ts`	Provider imports now reference explicit `./index` or `.js` module paths for generated models and model metadata types.
Dangling DTS scanner and test wiring `scripts/scan-dangling-dts.mjs`, `nx.json`	The scanner recursively checks built declarations using Node/bundler resolution rules, reports sorted dangling imports, and runs through a cached `test:dts` target.
Release metadata `.changeset/fix-dangling-dts-barrel-imports.md`	Patch releases and the declaration import fix are recorded for the listed packages.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

TanStack/ai#919: Both update generated declaration imports to concrete module specifiers.
TanStack/ai#922: Both involve dangling declaration imports and scanner-based test:dts verification.

Suggested reviewers:AlemTuzlak, KevinVandy

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description covers the change summary and test plan, but it does not follow the template's checklist and release-impact sections.	Add the checklist items and explicit release-impact section to match the repository template.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main fix and added guardrail.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 920-sweep-fix-skiplibcheck-masked-dangling-dts-imports-across-packages-+-add-a-guardrail

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Bare imports of utils/tools/middleware barrels were emitted as ../utils.js (etc.), which do not resolve under bundler/node16/nodenext (no /index fallback). With consumer skipLibCheck, those symbols silently became any. Point imports at concrete modules or explicit /index paths, and add pnpm test:dts to scan built declarations so this class cannot regress.

Bare '.', extensionless '.generated', and version-dot basenames (model-meta-llama3.1, etc.) emit declaration imports that node16 mis-resolves by stripping the wrong extension. Point them at explicit ./index or .js paths so attw --profile esm-only is clean for ai-anthropic, ai-bedrock, and ai-ollama.

github-actions · 2026-07-10T07:27:09Z

🚀 Changeset Version Preview

13 package(s) bumped directly, 32 bumped as dependents.

🟥 Major bumps

Package	Version	Reason
`@tanstack/ai-anthropic`	0.16.1 → 1.0.0	Changeset
`@tanstack/ai-bedrock`	0.1.2 → 1.0.0	Changeset
`@tanstack/ai-fal`	0.9.10 → 1.0.0	Changeset
`@tanstack/ai-gemini`	0.19.1 → 1.0.0	Changeset
`@tanstack/ai-grok`	0.14.7 → 1.0.0	Changeset
`@tanstack/ai-groq`	0.5.1 → 1.0.0	Changeset
`@tanstack/ai-mistral`	0.2.1 → 1.0.0	Changeset
`@tanstack/ai-ollama`	0.8.14 → 1.0.0	Changeset
`@tanstack/ai-openai`	0.16.0 → 1.0.0	Changeset
`@tanstack/ai-openrouter`	0.15.8 → 1.0.0	Changeset
`@tanstack/ai-react`	0.16.4 → 1.0.0	Changeset
`@tanstack/ai-acp`	0.2.1 → 1.0.0	Dependent
`@tanstack/ai-angular`	0.2.3 → 1.0.0	Dependent
`@tanstack/ai-claude-code`	0.2.1 → 1.0.0	Dependent
`@tanstack/ai-code-mode`	0.3.6 → 1.0.0	Dependent
`@tanstack/ai-code-mode-skills`	0.3.9 → 1.0.0	Dependent
`@tanstack/ai-codex`	0.2.1 → 1.0.0	Dependent
`@tanstack/ai-elevenlabs`	0.2.32 → 1.0.0	Dependent
`@tanstack/ai-grok-build`	0.2.1 → 1.0.0	Dependent
`@tanstack/ai-isolate-node`	0.1.45 → 1.0.0	Dependent
`@tanstack/ai-isolate-quickjs`	0.1.45 → 1.0.0	Dependent
`@tanstack/ai-opencode`	0.2.1 → 1.0.0	Dependent
`@tanstack/ai-preact`	0.10.3 → 1.0.0	Dependent
`@tanstack/ai-react-ui`	0.8.13 → 1.0.0	Dependent
`@tanstack/ai-sandbox`	0.2.2 → 1.0.0	Dependent
`@tanstack/ai-sandbox-cloudflare`	0.2.2 → 1.0.0	Dependent
`@tanstack/ai-sandbox-daytona`	0.2.0 → 1.0.0	Dependent
`@tanstack/ai-sandbox-docker`	0.2.0 → 1.0.0	Dependent
`@tanstack/ai-sandbox-local-process`	0.2.0 → 1.0.0	Dependent
`@tanstack/ai-sandbox-sprites`	0.2.1 → 1.0.0	Dependent
`@tanstack/ai-sandbox-vercel`	0.2.0 → 1.0.0	Dependent
`@tanstack/ai-solid`	0.14.3 → 1.0.0	Dependent
`@tanstack/ai-solid-ui`	0.7.12 → 1.0.0	Dependent
`@tanstack/ai-svelte`	0.14.3 → 1.0.0	Dependent
`@tanstack/ai-vue`	0.14.3 → 1.0.0	Dependent
`@tanstack/openai-base`	0.9.7 → 1.0.0	Dependent

🟨 Minor bumps

Package	Version	Reason
`@tanstack/ai`	0.40.0 → 0.41.0	Changeset
`@tanstack/ai-client`	0.20.0 → 0.21.0	Changeset

🟩 Patch bumps

Package	Version	Reason
`@tanstack/ai-devtools-core`	0.4.22 → 0.4.23	Dependent
`@tanstack/ai-isolate-cloudflare`	0.2.36 → 0.2.37	Dependent
`@tanstack/ai-mcp`	0.2.3 → 0.2.4	Dependent
`@tanstack/ai-vue-ui`	0.2.31 → 0.2.32	Dependent
`@tanstack/preact-ai-devtools`	0.1.65 → 0.1.66	Dependent
`@tanstack/react-ai-devtools`	0.2.65 → 0.2.66	Dependent
`@tanstack/solid-ai-devtools`	0.2.65 → 0.2.66	Dependent

nx-cloud · 2026-07-10T07:28:40Z

View your CI Pipeline Execution ↗ for commit 569e768

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-10 11:00:15 UTC

pkg-pr-new · 2026-07-10T07:29:32Z

Open in StackBlitz

@tanstack/ai

npm i https://pkg.pr.new/@tanstack/ai@924

@tanstack/ai-acp

npm i https://pkg.pr.new/@tanstack/ai-acp@924

@tanstack/ai-angular

npm i https://pkg.pr.new/@tanstack/ai-angular@924

@tanstack/ai-anthropic

npm i https://pkg.pr.new/@tanstack/ai-anthropic@924

@tanstack/ai-bedrock

npm i https://pkg.pr.new/@tanstack/ai-bedrock@924

@tanstack/ai-claude-code

npm i https://pkg.pr.new/@tanstack/ai-claude-code@924

@tanstack/ai-client

npm i https://pkg.pr.new/@tanstack/ai-client@924

@tanstack/ai-code-mode

npm i https://pkg.pr.new/@tanstack/ai-code-mode@924

@tanstack/ai-code-mode-skills

npm i https://pkg.pr.new/@tanstack/ai-code-mode-skills@924

@tanstack/ai-codex

npm i https://pkg.pr.new/@tanstack/ai-codex@924

@tanstack/ai-devtools-core

npm i https://pkg.pr.new/@tanstack/ai-devtools-core@924

@tanstack/ai-elevenlabs

npm i https://pkg.pr.new/@tanstack/ai-elevenlabs@924

@tanstack/ai-event-client

npm i https://pkg.pr.new/@tanstack/ai-event-client@924

@tanstack/ai-fal

npm i https://pkg.pr.new/@tanstack/ai-fal@924

@tanstack/ai-gemini

npm i https://pkg.pr.new/@tanstack/ai-gemini@924

@tanstack/ai-grok

npm i https://pkg.pr.new/@tanstack/ai-grok@924

@tanstack/ai-grok-build

npm i https://pkg.pr.new/@tanstack/ai-grok-build@924

@tanstack/ai-groq

npm i https://pkg.pr.new/@tanstack/ai-groq@924

@tanstack/ai-isolate-cloudflare

npm i https://pkg.pr.new/@tanstack/ai-isolate-cloudflare@924

@tanstack/ai-isolate-node

npm i https://pkg.pr.new/@tanstack/ai-isolate-node@924

@tanstack/ai-isolate-quickjs

npm i https://pkg.pr.new/@tanstack/ai-isolate-quickjs@924

@tanstack/ai-mcp

npm i https://pkg.pr.new/@tanstack/ai-mcp@924

@tanstack/ai-mistral

npm i https://pkg.pr.new/@tanstack/ai-mistral@924

@tanstack/ai-ollama

npm i https://pkg.pr.new/@tanstack/ai-ollama@924

@tanstack/ai-openai

npm i https://pkg.pr.new/@tanstack/ai-openai@924

@tanstack/ai-opencode

npm i https://pkg.pr.new/@tanstack/ai-opencode@924

@tanstack/ai-openrouter

npm i https://pkg.pr.new/@tanstack/ai-openrouter@924

@tanstack/ai-preact

npm i https://pkg.pr.new/@tanstack/ai-preact@924

@tanstack/ai-react

npm i https://pkg.pr.new/@tanstack/ai-react@924

@tanstack/ai-react-ui

npm i https://pkg.pr.new/@tanstack/ai-react-ui@924

@tanstack/ai-sandbox

npm i https://pkg.pr.new/@tanstack/ai-sandbox@924

@tanstack/ai-sandbox-cloudflare

npm i https://pkg.pr.new/@tanstack/ai-sandbox-cloudflare@924

@tanstack/ai-sandbox-daytona

npm i https://pkg.pr.new/@tanstack/ai-sandbox-daytona@924

@tanstack/ai-sandbox-docker

npm i https://pkg.pr.new/@tanstack/ai-sandbox-docker@924

@tanstack/ai-sandbox-local-process

npm i https://pkg.pr.new/@tanstack/ai-sandbox-local-process@924

@tanstack/ai-sandbox-sprites

npm i https://pkg.pr.new/@tanstack/ai-sandbox-sprites@924

@tanstack/ai-sandbox-vercel

npm i https://pkg.pr.new/@tanstack/ai-sandbox-vercel@924

@tanstack/ai-solid

npm i https://pkg.pr.new/@tanstack/ai-solid@924

@tanstack/ai-solid-ui

npm i https://pkg.pr.new/@tanstack/ai-solid-ui@924

@tanstack/ai-svelte

npm i https://pkg.pr.new/@tanstack/ai-svelte@924

@tanstack/ai-utils

npm i https://pkg.pr.new/@tanstack/ai-utils@924

@tanstack/ai-vue

npm i https://pkg.pr.new/@tanstack/ai-vue@924

@tanstack/ai-vue-ui

npm i https://pkg.pr.new/@tanstack/ai-vue-ui@924

@tanstack/openai-base

npm i https://pkg.pr.new/@tanstack/openai-base@924

@tanstack/preact-ai-devtools

npm i https://pkg.pr.new/@tanstack/preact-ai-devtools@924

@tanstack/react-ai-devtools

npm i https://pkg.pr.new/@tanstack/react-ai-devtools@924

@tanstack/solid-ai-devtools

npm i https://pkg.pr.new/@tanstack/solid-ai-devtools@924

commit: 569e768

…952) test:pr runs `nx affected ... build && pnpm test:dts`. On a docs/skill/CI-only PR, `nx affected` builds no packages, so there are zero packages/*/dist dirs. The dangling-dts guardrail (#924) treated that as a hard failure (exit 1), turning every unaffected PR red even though there are no declarations to scan and nothing could have regressed. Treat "no dist directories" as a no-op skip (exit 0) instead. When packages are built the scan runs and catches regressions exactly as before. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tombeckenham requested a review from a team as a code owner July 10, 2026 04:22

tombeckenham linked an issue Jul 10, 2026 that may be closed by this pull request
Sweep: fix skipLibCheck-masked dangling .d.ts imports across packages (+ add a guardrail) #920
Closed
3 tasks

tombeckenham added 2 commits July 10, 2026 17:25

tombeckenham force-pushed the 920-sweep-fix-skiplibcheck-masked-dangling-dts-imports-across-packages-+-add-a-guardrail branch from d2b1e5f to 569e768Compare July 10, 2026 07:25

AlemTuzlak approved these changes Jul 10, 2026
View reviewed changes

tombeckenham merged commit 5fcaf90 into mainJul 10, 2026
12 of 13 checks passed

tombeckenham deleted the 920-sweep-fix-skiplibcheck-masked-dangling-dts-imports-across-packages-+-add-a-guardrail branch July 10, 2026 11:10

github-actionsBot mentioned this pull request Jul 10, 2026
ci: Version Packages #913
Merged

tombeckenham mentioned this pull request Jul 16, 2026
fix(ci): scan-dangling-dts skips cleanly when no packages were built #952
Merged
4 tasks

Navigation Menu

Uh oh!

Uh oh!

fix: resolve skipLibCheck-masked dangling .d.ts imports (+ test:dts guardrail) - #924

fix: resolve skipLibCheck-masked dangling .d.ts imports (+ test:dts guardrail)#924
tombeckenham merged 2 commits into
mainfrom
920-sweep-fix-skiplibcheck-masked-dangling-dts-imports-across-packages-+-add-a-guardrail

tombeckenham commented Jul 10, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Jul 10, 2026•
edited
Loading

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Uh oh!

github-actionsBot commented Jul 10, 2026

Uh oh!

nx-cloudBot commented Jul 10, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Jul 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

tombeckenham commented Jul 10, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Jul 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Uh oh!

github-actionsBot commented Jul 10, 2026

🚀 Changeset Version Preview

🟥 Major bumps

🟨 Minor bumps

🟩 Patch bumps

Uh oh!

nx-cloudBot commented Jul 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Jul 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tombeckenham commented Jul 10, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jul 10, 2026•
edited
Loading

nx-cloudBot commented Jul 10, 2026•
edited
Loading