Uh oh!
There was an error while loading. Please reload this page.
Migrate catalog examples to React - #84
Conversation
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (56)
📝 WalkthroughWalkthroughThe conformance catalog and 14 chart cases now use React TSX views. Mounting, controls, lifecycle handling, accessibility output, source rendering, and conformance tests were updated for React integration. ChangesReact conformance migration
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
58718e6 to
107bd20CompareUh oh!
There was an error while loading. Please reload this page.
Summary
Why
The catalog and example shells mixed chart definitions with manual element creation, mutation, selector rebinding, and listener cleanup. That obscured the intended React ownership boundary and made the examples poor copy-paste material.
Validation
pnpm exec tsc --noEmit --pretty falsepnpm --filter @charts-poc/conformance-example buildnode scripts/catalog-index.mjs --checkSummary by CodeRabbit
New Features
Bug Fixes
Tests