Uh oh!
There was an error while loading. Please reload this page.
Fix arc animation and Angular SSR - #85
Merged
Merged
Conversation
Co-authored-by: Marc Stammerjohann <8985933+marcjulian@users.noreply.github.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (8)
📝 WalkthroughWalkthroughThe change fixes discrete SVG arc-flag animation, defers Angular adapter mounting until browser rendering, adds Angular SSR coverage, and refreshes release, benchmark, comparison, and conformance evidence. ChangesChart Rendering Fixes
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant renderApplication
participant Chart
participant afterNextRender
participant SVGHost
renderApplication->>Chart: instantiate chart host
Chart->>afterNextRender: schedule adapter mount
renderApplication->>SVGHost: render complete SVG during SSR
afterNextRender->>Chart: invoke browser callback
Chart->>SVGHost: mount adapter in browser
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
View your CI Pipeline Execution ↗ for commit db05020
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/angular-charts/src/Chart.ssr.test.ts (1)
46-47: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winStrengthen the SSR content assertion.
The current assertions prove that an SVG shell and ARIA label exist. They do not prove that the line mark was rendered. Add one stable mark assertion so an empty
<svg>cannot satisfy the complete-SVG regression test.Proposed assertion
expect(html).toContain('<svg') + expect(html).toContain('<path') expect(html).toContain('aria-label="Server revenue"')🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/angular-charts/src/Chart.ssr.test.ts` around lines 46 - 47, Strengthen the SSR test assertions in Chart.ssr.test.ts by adding a stable assertion for the rendered line mark alongside the existing SVG and aria-label checks. Use a deterministic mark attribute or element produced by the chart so an empty SVG cannot satisfy the complete-SVG regression test.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/charts-core/src/reconcile.ts`:
- Around line 264-290: Update the path-number extraction flow around
markSvgArcFlags so adjacent SVG arc flags are separated before numeric
placeholders are generated, preserving arc-command context and correct
placeholder positions for inputs such as “00” and “01”. Adjust the relevant
tokenizer/extraction logic and add coverage for both adjacent flag pairs,
ensuring tweened arc geometry remains correct.
---
Nitpick comments:
In `@packages/angular-charts/src/Chart.ssr.test.ts`:
- Around line 46-47: Strengthen the SSR test assertions in Chart.ssr.test.ts by
adding a stable assertion for the rendered line mark alongside the existing SVG
and aria-label checks. Use a deterministic mark attribute or element produced by
the chart so an empty SVG cannot satisfy the complete-SVG regression test.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 03c9c031-b6f5-4a7c-91f9-9eb91123dd7a
⛔ Files ignored due to path filters (2)
benchmarks/conformance/previews/87-echarts-synchronized-cursors.svgis excluded by!**/*.svgpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (20)
.changeset/calm-arcs-render.mdAPI-FRICTION.mdbenchmarks/bundle-size/README.mdbenchmarks/bundle-size/universal-baseline.jsonbenchmarks/comparison/bundle-baseline.jsonbenchmarks/conformance/DEFINITION-COVERAGE-AUDIT.mdbenchmarks/conformance/definition-coverage-roadmap.jsonbenchmarks/conformance/definition-coverage-roadmap.test.tsbenchmarks/conformance/previews/manifest.jsondocs/comparison.mddocs/framework/angular/adapter.mdpackages/angular-charts/package.jsonpackages/angular-charts/src/Chart.ssr.test.tspackages/angular-charts/src/Chart.tspackages/charts-core/docs/comparison.mdpackages/charts-core/docs/framework/angular/adapter.mdpackages/charts-core/src/reconcile.test.tspackages/charts-core/src/reconcile.tsscripts/measure-bundles.mjsscripts/public-callback-contract.mjs
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
afterNextRenderwhile retaining complete server-rendered SVGmainand refresh affected bundle evidenceThe Angular mounting approach builds on #57 by @marcjulian and adds SSR regression coverage, documentation, and release integration.
Verification
pnpm validatepnpm changeset statusCloses#71
Closes#56
Summary by CodeRabbit
Bug Fixes
Documentation
Tests