Skip to content

Fix return value from refetch in query collection - #1132

Merged
kevin-dp merged 3 commits into
mainfrom
kevin/fix-refetch
Jan 15, 2026
Merged

Fix return value from refetch in query collection#1132
kevin-dp merged 3 commits into
mainfrom
kevin/fix-refetch

Conversation

@kevin-dp

Copy link
Copy Markdown
Contributor

Fixes#1108.
The refetch function was awaiting the promise but we were never returning it:

constrefetch: RefetchFn=async(opts)=>{constallQueryKeys=[...hashToQueryKey.values()]constrefetchPromises=allQueryKeys.map((qKey)=>{constqueryObserver=state.observers.get(hashKey(qKey))!returnqueryObserver.refetch({throwOnError: opts?.throwOnError,})})awaitPromise.all(refetchPromises)// we should return this promise}

Then i also had to fix the type of RefetchFn to return a promise that resolves to an array of query observer results.

@changeset-bot

changeset-botBot commented Jan 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6de427e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@tanstack/query-db-collectionPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevin-dpkevin-dp changed the title Kevin/fix refetchFix return value from refetch in query collectionJan 14, 2026
@pkg-pr-new

Copy link
Copy Markdown
More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@1132

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@1132

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@1132

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@1132

@tanstack/offline-transactions

npm i https://pkg.pr.new/@tanstack/offline-transactions@1132

@tanstack/powersync-db-collection

npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1132

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@1132

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@1132

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1132

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@1132

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@1132

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1132

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@1132

commit: 6de427e

@github-actions

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 90.5 kB

ℹ️ View Unchanged
FilenameSize
./packages/db/dist/esm/collection/change-events.js1.39 kB
./packages/db/dist/esm/collection/changes.js1.19 kB
./packages/db/dist/esm/collection/events.js388 B
./packages/db/dist/esm/collection/index.js3.32 kB
./packages/db/dist/esm/collection/indexes.js1.1 kB
./packages/db/dist/esm/collection/lifecycle.js1.67 kB
./packages/db/dist/esm/collection/mutations.js2.34 kB
./packages/db/dist/esm/collection/state.js3.46 kB
./packages/db/dist/esm/collection/subscription.js3.62 kB
./packages/db/dist/esm/collection/sync.js2.38 kB
./packages/db/dist/esm/deferred.js207 B
./packages/db/dist/esm/errors.js4.49 kB
./packages/db/dist/esm/event-emitter.js748 B
./packages/db/dist/esm/index.js2.69 kB
./packages/db/dist/esm/indexes/auto-index.js742 B
./packages/db/dist/esm/indexes/base-index.js766 B
./packages/db/dist/esm/indexes/btree-index.js1.93 kB
./packages/db/dist/esm/indexes/lazy-index.js1.1 kB
./packages/db/dist/esm/indexes/reverse-index.js513 B
./packages/db/dist/esm/local-only.js837 B
./packages/db/dist/esm/local-storage.js2.1 kB
./packages/db/dist/esm/optimistic-action.js359 B
./packages/db/dist/esm/paced-mutations.js496 B
./packages/db/dist/esm/proxy.js3.75 kB
./packages/db/dist/esm/query/builder/functions.js733 B
./packages/db/dist/esm/query/builder/index.js4.08 kB
./packages/db/dist/esm/query/builder/ref-proxy.js1.05 kB
./packages/db/dist/esm/query/compiler/evaluators.js1.42 kB
./packages/db/dist/esm/query/compiler/expressions.js430 B
./packages/db/dist/esm/query/compiler/group-by.js1.87 kB
./packages/db/dist/esm/query/compiler/index.js1.96 kB
./packages/db/dist/esm/query/compiler/joins.js2 kB
./packages/db/dist/esm/query/compiler/order-by.js1.45 kB
./packages/db/dist/esm/query/compiler/select.js1.06 kB
./packages/db/dist/esm/query/expression-helpers.js1.43 kB
./packages/db/dist/esm/query/ir.js673 B
./packages/db/dist/esm/query/live-query-collection.js360 B
./packages/db/dist/esm/query/live/collection-config-builder.js5.4 kB
./packages/db/dist/esm/query/live/collection-registry.js264 B
./packages/db/dist/esm/query/live/collection-subscriber.js1.93 kB
./packages/db/dist/esm/query/live/internal.js145 B
./packages/db/dist/esm/query/optimizer.js2.56 kB
./packages/db/dist/esm/query/predicate-utils.js2.97 kB
./packages/db/dist/esm/query/subset-dedupe.js921 B
./packages/db/dist/esm/scheduler.js1.3 kB
./packages/db/dist/esm/SortedMap.js1.3 kB
./packages/db/dist/esm/strategies/debounceStrategy.js247 B
./packages/db/dist/esm/strategies/queueStrategy.js428 B
./packages/db/dist/esm/strategies/throttleStrategy.js246 B
./packages/db/dist/esm/transactions.js2.9 kB
./packages/db/dist/esm/utils.js924 B
./packages/db/dist/esm/utils/browser-polyfills.js304 B
./packages/db/dist/esm/utils/btree.js5.61 kB
./packages/db/dist/esm/utils/comparison.js852 B
./packages/db/dist/esm/utils/cursor.js457 B
./packages/db/dist/esm/utils/index-optimization.js1.51 kB
./packages/db/dist/esm/utils/type-guards.js157 B

compressed-size-action::db-package-size

@github-actions

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 3.47 kB

ℹ️ View Unchanged
FilenameSize
./packages/react-db/dist/esm/index.js225 B
./packages/react-db/dist/esm/useLiveInfiniteQuery.js1.17 kB
./packages/react-db/dist/esm/useLiveQuery.js1.12 kB
./packages/react-db/dist/esm/useLiveSuspenseQuery.js559 B
./packages/react-db/dist/esm/usePacedMutations.js401 B

compressed-size-action::react-db-package-size

@kevin-dp
kevin-dp merged commit f32246a into mainJan 15, 2026
7 checks passed
@kevin-dp
kevin-dp deleted the kevin/fix-refetch branch January 15, 2026 16:17
@github-actionsgithub-actionsBot mentioned this pull request Jan 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR has been released!

Thank you for your contribution!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

collection.utils.refetch() returns undefined

2 participants

@kevin-dp@KyleAMathews