Uh oh!
There was an error while loading. Please reload this page.
Fix useLiveQuery loading status in on-demand sync - #962
Closed
KyleAMathews wants to merge 22 commits into
Closed
Conversation
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For live queries using on-demand sync mode, the collection was being marked as ready immediately when source collections were ready, even though the initial loadSubset hadn't completed yet. This meant
isLoadingwas false while data was still being fetched.This fix ensures that:
isLoading: trueuntil it completesloadinguntil the first data load finishesChanges:
hasMarkedReadyandhasSetupLoadingListenerflags to track initial ready state in CollectionConfigBuilderupdateLiveQueryStatus()to wait for first loadSubset to complete before callingmarkReady()subscribeToMatchingChanges()in CollectionSubscriber to track the initial loadSubset promise for on-demand sources🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact