refactor(react-query/useQueries): remove unreachable 'willFetch' branch in suspense promise collection by sukvvon · Pull Request #10082 · TanStack/query

sukvvon · 2026-01-31T04:52:27Z

🎯 Changes

Remove the unreachable willFetch branch in useQueries suspense promise collection.

In v4, useQueries allowed individual queries to set suspense: true/false, so a mix of suspense and non-suspense queries was possible. The willFetch branch handled prefetching for non-suspense queries within a suspense batch.

In v5, suspense was omitted from UseQueryOptions and useSuspenseQueries applies suspense: true to all queries uniformly. This makes the mixed suspense/non-suspense scenario unreachable through the public API, leaving the willFetch branch as dead code.

This PR removes:

The willFetch branch (else if (willFetch(result, isRestoring)))
The unused willFetch import from ./suspense

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Refactor
- Simplified suspense-related query fetching: reduced conditional paths and consolidated optimistic fetch scheduling to be more predictable and maintainable.
- Added a patch changeset reflecting the refactor and resulting package version adjustment.

…ch in suspense promise collection

changeset-bot · 2026-01-31T04:52:31Z

🦋 Changeset detected

Latest commit: 2b494ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@tanstack/react-query	Patch
@tanstack/react-query-devtools	Patch
@tanstack/react-query-next-experimental	Patch
@tanstack/react-query-persist-client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-31T04:52:34Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Removed the willFetch branch and simplified suspense preparation in useQueries so fetchOptimistic is only invoked when opts exists and shouldSuspend(opts, result) is true.

Changes

Cohort / File(s)	Summary
Suspense Logic Simplification `packages/react-query/src/useQueries.ts`	Removed `willFetch` import and collapsed nested if/else into `if (opts && shouldSuspend(opts, result))`, removing the secondary `willFetch`-driven `fetchOptimistic` path.
Release Metadata `.changeset/wise-guests-hope.md`	Added changeset noting a patch bump and the refactor that removes the unreachable `willFetch` branch in `useQueries`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

refactor(react-query/useQueries): remove unreachable 'willFetch' branch in suspense promise collection #10082 — applies the same code-level change in packages/react-query/src/useQueries.ts, removing the willFetch branch and collapsing the suspense conditional.

Suggested reviewers

manudeli

Poem

🐰 Branches folded, code made light,
One clear path through morning bright.
willFetch tiptoes off the lawn,
shouldSuspend leads on and on.
A tiny hop — the hook feels right.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removing an unreachable 'willFetch' branch from suspense promise collection in useQueries.
Description check	✅ Passed	The PR description comprehensively covers all required sections: detailed explanation of changes, clear motivation/context, completed checklist items, and proper release impact assessment.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-01-31T04:52:55Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit 2b494ce

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	❌ Failed	4m 4s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-11 08:46:56 UTC

pkg-pr-new · 2026-01-31T04:54:05Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10082

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10082

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10082

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10082

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10082

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10082

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10082

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10082

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10082

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10082

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10082

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10082

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10082

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10082

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10082

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10082

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10082

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10082

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10082

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10082

commit: 6c4763d

Refactor the useQueries function to improve code clarity by removing an unreachable 'willFetch' branch in the suspense promise collection.

github-actions · 2026-02-11T09:17:33Z

🎉 This PR has been released!

@tanstack/react-query@5.90.21

Thank you for your contribution!

refactor(react-query/useQueries): remove unreachable 'willFetch' bran…
6c4763d
…ch in suspense promise collection

github-actionsBot added the package: react-query label Jan 31, 2026

sukvvon marked this pull request as ready for review January 31, 2026 05:01

TkDodo approved these changes Feb 11, 2026
View reviewed changes

Refactor useQueries to remove unreachable code
2b494ce
Refactor the useQueries function to improve code clarity by removing an unreachable 'willFetch' branch in the suspense promise collection.

TkDodo merged commit c5def66 into TanStack:mainFeb 11, 2026
4 of 6 checks passed

github-actionsBot mentioned this pull request Feb 11, 2026
ci: Version Packages #10115
Merged

coderabbitaiBot mentioned this pull request Feb 13, 2026
test(react-query/useSuspenseQueries): add test for suspending only pending queries when some already have cached data #10126
Merged
4 tasks

claudeBot mentioned this pull request Feb 13, 2026
chore(deps): update dependency @tanstack/react-query to v5.90.21 typestreamio/typestream#241
Merged
1 task

coderabbitaiBot mentioned this pull request Feb 14, 2026
test(preact-query/useSuspenseQueries): add test for suspending only pending queries when some already have cached data #10133
Merged
4 tasks

sukvvon mentioned this pull request Feb 26, 2026
refactor(preact-query/useQueries): remove unreachable 'willFetch' branch in suspense promise collection #10188
Merged
4 tasks

coderabbitaiBot mentioned this pull request Mar 2, 2026
test({react,preact}-query/useSuspenseQueries): add test for not suspending but refetching when all queries have stale cached data #10209
Merged
4 tasks

sukvvon self-assigned this Mar 19, 2026

electrohyun mentioned this pull request Jul 24, 2026
refactor(eslint-plugin-query): remove unused ast-utils helpers #11115
Merged
3 tasks

Navigation Menu

Uh oh!

Uh oh!

refactor(react-query/useQueries): remove unreachable 'willFetch' branch in suspense promise collection - #10082

refactor(react-query/useQueries): remove unreachable 'willFetch' branch in suspense promise collection#10082
TkDodo merged 2 commits into
TanStack:mainfrom
sukvvon:refactor/useQueries-remove-willFetch

sukvvon commented Jan 31, 2026•
edited
Loading

Uh oh!

changeset-botBot commented Jan 31, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented Jan 31, 2026•
edited
Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloudBot commented Jan 31, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Jan 31, 2026

Uh oh!

Uh oh!

github-actionsBot commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

sukvvon commented Jan 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-botBot commented Jan 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitaiBot commented Jan 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

nx-cloudBot commented Jan 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix Eligible

Uh oh!

pkg-pr-newBot commented Jan 31, 2026

Uh oh!

Uh oh!

github-actionsBot commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Jan 31, 2026•
edited
Loading

changeset-botBot commented Jan 31, 2026•
edited
Loading

coderabbitaiBot commented Jan 31, 2026•
edited
Loading

nx-cloudBot commented Jan 31, 2026•
edited
Loading