Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(query-core): add structuralSharing option to useQueries#10101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dagstuan
wants to merge
11
commits into
TanStack:mainChoose a base branch
from
dagstuan:main
base:main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Uh oh!
There was an error while loading. Please reload this page.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1956f42
feat(query-core): add structuralSharing option to useQueries
dagstuan f9b6982
Merge branch 'TanStack:main' into main
dagstuan 4a13c69
Add structuralSharing to useQueries in the preact-adapter.
dagstuan 9950db7
Refactor structuralSharing for useQueries to accept a function.
dagstuan f1815fc
Add tests for the structuralSharing option in QueriesObserver.
dagstuan c6399f0
Add preact adapter to changeset.
dagstuan eabd1fc
Fix docs nitpicks from coderabbit for structuralSharing for useQueries.
dagstuan c231e0f
Merge remote-tracking branch 'upstream/main'
dagstuan 69e7fda
Use replaceData util to replace combined result.
dagstuan e75f069
Pass complete queries options to getOptimisticResult.
dagstuan e7a7214
Merge branch 'main' into main
dagstuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| '@tanstack/angular-query-experimental': minor | ||
| '@tanstack/svelte-query': minor | ||
| '@tanstack/react-query': minor | ||
| '@tanstack/preact-query': minor | ||
| '@tanstack/solid-query': minor | ||
| '@tanstack/query-core': minor | ||
| '@tanstack/vue-query': minor | ||
| --- | ||
| feat(query-core): Allow disabling structuralSharing for useQueries. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -24,6 +24,12 @@ The `useQueries` hook accepts an options object with a **queries** key whose val | ||
| - Use this to provide a custom QueryClient. Otherwise, the one from the nearest context will be used. | ||
| - `combine?: (result: UseQueriesResults) => TCombinedResult` | ||
| - Use this to combine the results of the queries into a single value. | ||
| - `structuralSharing?: boolean | ((oldData: unknown | undefined, newData: unknown) => unknown)` | ||
| - Optional | ||
| - Defaults to `true`. | ||
| - Only applies when `combine` is provided. | ||
| - If set to `false`, structural sharing between query results will be disabled. | ||
| - If set to a function, the old and new data values will be passed through this function, which should combine them into resolved data for the query. This way, you can retain references from the old data to improve performance even when that data contains non-serializable values. | ||
coderabbitai[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| > Having the same query key more than once in the array of query objects may cause some data to be shared between queries. To avoid this, consider de-duplicating the queries and map the results back to the desired structure. | ||
| @@ -37,7 +43,7 @@ The `useQueries` hook returns an array with all the query results. The order ret | ||
| ## Combine | ||
| If you want to combine `data` (or other Query information) from the results into a single value, you can use the `combine` option. The result will be structurally shared to be as referentially stable as possible. | ||
| If you want to combine `data` (or other Query information) from the results into a single value, you can use the `combine` option. The result will be structurally shared to be as referentially stable as possible. If you want to disable structural sharing for the combined result, you can set the `structuralSharing` option to `false`, or provide a custom function to implement your own structural sharing logic. | ||
| ```tsx | ||
| const ids = [1, 2, 3] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.