test(query-core/queryObserver): add test for rejecting promise when 'experimental_prefetchInRender' is disabled by sukvvon · Pull Request #10249 · TanStack/query

sukvvon · 2026-03-06T04:41:00Z

🎯 Changes

Add a test for queryObserver.ts lines 272-277 — trackResult rejecting the pending thenable when experimental_prefetchInRender is disabled and .promise is accessed.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added test coverage verifying that when the experimental prefetch feature is disabled, in-flight thenables are rejected with a clear, specific error message.

changeset-bot · 2026-03-06T04:41:07Z

⚠️ No Changeset found

Latest commit: df8f53a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-06T04:41:18Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd78d545-004e-4c58-818b-fe8c522abec1

📥 Commits

Reviewing files that changed from the base of the PR and between bcbaa6d and df8f53a.

📒 Files selected for processing (1)

packages/query-core/src/__tests__/queryObserver.test.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

packages/query-core/src/tests/queryObserver.test.tsx

📝 Walkthrough

Walkthrough

Adds two identical tests to QueryObserver's test suite asserting that when experimental_prefetchInRender is disabled and the query function returns a pending thenable, the observer's tracked promise rejects with "experimental_prefetchInRender feature flag is not enabled".

Changes

Cohort / File(s)	Summary
QueryObserver tests `packages/query-core/src/__tests__/queryObserver.test.tsx`	Adds two identical test cases that construct a `QueryClient` with `experimental_prefetchInRender` disabled, create a `QueryObserver` whose `queryFn` returns a pending thenable, call `getCurrentResult()`/`trackResult()` and assert the tracked `result.promise` rejects with the feature-flag error message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I nibbled at flags in the test-tree light,
A thenable hung, refusing to take flight,
Two gentle checks to catch the silent plea,
"Feature off," it sighed — the promise set me free,
🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a test for promise rejection when the experimental_prefetchInRender feature flag is disabled.
Description check	✅ Passed	The description follows the repository template with all required sections completed: Changes are clearly described, checklist items are marked as completed, and release impact is properly documented as dev-only.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-06T04:41:32Z

View your CI Pipeline Execution ↗ for commit df8f53a

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 43s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-06 04:57:12 UTC

pkg-pr-new · 2026-03-06T04:44:11Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10249

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10249

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10249

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10249

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10249

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10249

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10249

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10249

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10249

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10249

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10249

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10249

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10249

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10249

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10249

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10249

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10249

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10249

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10249

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10249

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10249

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10249

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10249

commit: 5e1bc1f

coderabbitai

🧹 Nitpick comments (1)

packages/query-core/src/__tests__/queryObserver.test.tsx (1)

1399-1403: Assert on tracked.promise directly to make the test precise

This keeps the assertion aligned with the behavior under test (trackResult) and avoids the extra void access pattern.

Proposed diff

- void tracked.promise-- await expect(result.promise).rejects.toThrow(+ await expect(tracked.promise).rejects.toThrow(
'experimental_prefetchInRender feature flag is not enabled',
)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/query-core/src/__tests__/queryObserver.test.tsx` around lines 1399 -
1403, The test currently uses a redundant `void tracked.promise` and then
asserts `result.promise`; update it to assert `tracked.promise` directly to
accurately test the behavior of `trackResult` — remove the `void
tracked.promise` line and change the expectation from
`expect(result.promise).rejects.toThrow(...)` to
`expect(tracked.promise).rejects.toThrow(...)`, keeping the same error message
assertion.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/query-core/src/__tests__/queryObserver.test.tsx`:
- Around line 1399-1403: The test currently uses a redundant `void
tracked.promise` and then asserts `result.promise`; update it to assert
`tracked.promise` directly to accurately test the behavior of `trackResult` —
remove the `void tracked.promise` line and change the expectation from
`expect(result.promise).rejects.toThrow(...)` to
`expect(tracked.promise).rejects.toThrow(...)`, keeping the same error message
assertion.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dbcc6ceb-e941-4f52-9dd3-c9788ca19816

📥 Commits

Reviewing files that changed from the base of the PR and between fe25edc and 6bc99ca.

📒 Files selected for processing (1)

packages/query-core/src/__tests__/queryObserver.test.tsx

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/query-core/src/__tests__/queryObserver.test.tsx`:
- Around line 1381-1402: The test creates a local QueryClient instance
(queryClient2) but never clears it; add cleanup by calling await
queryClient2.clear() (or queryClient2.clear() in a finally block) at the end of
the test so the QueryClient is torn down after the assertions; locate the test
that instantiates QueryClient(queryClient2) and insert the clear call (using the
same queryClient2 identifier) so resources are released.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 72235061-8450-47e4-9bb4-bba61e9bae7e

📥 Commits

Reviewing files that changed from the base of the PR and between 6bc99ca and bcbaa6d.

📒 Files selected for processing (1)

packages/query-core/src/__tests__/queryObserver.test.tsx

…experimental_prefetchInRender' is disabled

github-actionsBot added the package: query-core label Mar 6, 2026

coderabbitaiBot reviewed Mar 6, 2026
View reviewed changes

sukvvon force-pushed the test/query-core-queryObserver-reject-promise-without-prefetchInRender branch from 6bc99ca to bcbaa6dCompare March 6, 2026 04:47

coderabbitaiBot reviewed Mar 6, 2026
View reviewed changes

Comment threadpackages/query-core/src/__tests__/queryObserver.test.tsx

test(query-core/queryObserver): add test for rejecting promise when '…
df8f53a
…experimental_prefetchInRender' is disabled

sukvvon force-pushed the test/query-core-queryObserver-reject-promise-without-prefetchInRender branch from bcbaa6d to df8f53aCompare March 6, 2026 04:52

TkDodo merged commit db663de into TanStack:mainMar 11, 2026
6 checks passed

sukvvon self-assigned this Mar 19, 2026

coderabbitaiBot mentioned this pull request Jun 5, 2026
test(query-core/queryObserver): add test for promise not rejecting when 'experimental_prefetchInRender' is enabled #10887
Merged
4 tasks

Navigation Menu

Uh oh!

Uh oh!

test(query-core/queryObserver): add test for rejecting promise when 'experimental_prefetchInRender' is disabled - #10249

test(query-core/queryObserver): add test for rejecting promise when 'experimental_prefetchInRender' is disabled#10249
TkDodo merged 1 commit into
TanStack:mainfrom
sukvvon:test/query-core-queryObserver-reject-promise-without-prefetchInRender

sukvvon commented Mar 6, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

changeset-botBot commented Mar 6, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented Mar 6, 2026•
edited
Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloudBot commented Mar 6, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Mar 6, 2026•
edited
Loading

Uh oh!

coderabbitaiBot left a comment

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

sukvvon commented Mar 6, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-botBot commented Mar 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitaiBot commented Mar 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

nx-cloudBot commented Mar 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Mar 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Mar 6, 2026•
edited by coderabbitai Bot
Loading

changeset-botBot commented Mar 6, 2026•
edited
Loading

coderabbitaiBot commented Mar 6, 2026•
edited
Loading

nx-cloudBot commented Mar 6, 2026•
edited
Loading

pkg-pr-newBot commented Mar 6, 2026•
edited
Loading