Skip to content

refactor: solid v2 pre-release for solid-query v6 - #10272

Merged
birkskyum merged 36 commits into
TanStack:solid-query-v6-prefrom
brenelz:solid-v2-2
Mar 19, 2026
Merged

refactor: solid v2 pre-release for solid-query v6#10272
birkskyum merged 36 commits into
TanStack:solid-query-v6-prefrom
brenelz:solid-v2-2

Conversation

@brenelz

@brenelzbrenelz commented Mar 14, 2026

Copy link
Copy Markdown
Contributor

🎯 Changes

Update solid-query to support v2 of Solid

@changeset-bot

changeset-botBot commented Mar 14, 2026•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e7415f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Mar 14, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4382e0d7-726e-4037-af6e-1441c737f8a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud

nx-cloudBot commented Mar 14, 2026•
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 81961a5

CommandStatusDurationResult
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 42sView ↗
nx affected --targets=test:sherif,test:knip,tes...✅ Succeeded3m 33sView ↗

☁️ Nx Cloud last updated this comment at 2026-03-19 21:17:19 UTC

@pkg-pr-new

pkg-pr-newBot commented Mar 15, 2026•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10272

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10272

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10272

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10272

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10272

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10272

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10272

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10272

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10272

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10272

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10272

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10272

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10272

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10272

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10272

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10272

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10272

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10272

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10272

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10272

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10272

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10272

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10272

commit: 81961a5

@2wheeh

2wheeh commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Hi, I opened a small PR against your branch brenelz#1, would you be open to this?

birkskyum
birkskyum reviewed Mar 18, 2026
View reviewed changes
Comment threadpackages/solid-query/src/useQueries.ts
birkskyum
birkskyum reviewed Mar 18, 2026
View reviewed changes
Comment threadpackages/solid-query/src/__tests__/useMutation.test.tsx
birkskyum
birkskyum reviewed Mar 18, 2026
View reviewed changes
Comment threadpackages/solid-query/src/__tests__/useMutation.test.tsx
birkskyum
birkskyum reviewed Mar 18, 2026
View reviewed changes
Comment threadpackages/solid-query-persist-client/package.json Outdated
@birkskyumbirkskyum changed the title WIP: Solid v2 2WIP: Solid v2 pre-releaseMar 18, 2026
2wheeh
2wheeh reviewed Mar 19, 2026
View reviewed changes
Comment threadpackages/solid-query/src/__tests__/mutationOptions.test.tsx
</QueryClientProvider>
))

await Promise.resolve()

@2wheeh2wheehMar 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flush() ?

@brenelzbrenelzMar 19, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works too

@birkskyum
birkskyum changed the base branch from main to solid-query-v6-preMarch 19, 2026 19:32
@birkskyumbirkskyum changed the title WIP: Solid v2 pre-releasefeat: solid v2 pre-release for solid-query v6Mar 19, 2026
@birkskyumbirkskyum changed the title feat: solid v2 pre-release for solid-query v6refactor: solid v2 pre-release for solid-query v6Mar 19, 2026
@birkskyum
birkskyum marked this pull request as ready for review March 19, 2026 21:08
@birkskyum
birkskyum merged commit 4a27c6c into TanStack:solid-query-v6-preMar 19, 2026
7 of 8 checks passed
@ryansolidryansolid mentioned this pull request Aug 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birkskyumbirkskyumbirkskyum left review comments
+1 more reviewer
@2wheeh2wheeh2wheeh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: solid-querypackage: solid-query-devtoolspackage: solid-query-persist-client

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brenelz@2wheeh@birkskyum@lachlancollins