test(svelte-query/createQueries): switch to fake timers, replace 'vi.waitFor' with 'vi.advanceTimersByTimeAsync', and move 'queryClient' to 'beforeEach' by sukvvon · Pull Request #10388 · TanStack/query

sukvvon · 2026-04-05T07:47:26Z

🎯 Changes

Add vi.useFakeTimers() to beforeEach and vi.useRealTimers() to afterEach
Move queryClient creation from describe-level const to beforeEach for per-test isolation
Replace all vi.waitFor with vi.advanceTimersByTimeAsync(0) for deterministic timer control
Remove redundant vi.useFakeTimers() / vi.useRealTimers() from individual isRestoring tests

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Improved test infrastructure and timing mechanisms for better test reliability and consistency.

Note: This release contains internal testing improvements only. No user-facing features, bug fixes, or API changes included.

…waitFor' with 'vi.advanceTimersByTimeAsync', and move 'queryClient' to 'beforeEach'

coderabbitai · 2026-04-05T07:47:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3ece5c49-a969-4804-b0a5-dfeb11dcdb28

📥 Commits

Reviewing files that changed from the base of the PR and between 4b2cd73 and ddeef27.

📒 Files selected for processing (1)

packages/svelte-query/tests/createQueries/createQueries.svelte.test.ts

📝 Walkthrough

Walkthrough

Test setup refactored in createQueries.svelte.test.ts to consolidate fake timer and QueryClient lifecycle management via beforeEach/afterEach hooks, while replacing synchronous vi.waitFor() polling-based assertions with vi.advanceTimersByTimeAsync(0) timer-flush patterns.

Changes

Cohort / File(s)	Summary
Test Lifecycle & Timer Refactoring `packages/svelte-query/tests/createQueries/createQueries.svelte.test.ts`	Centralized fake timer initialization (`vi.useFakeTimers()`) and QueryClient creation/cleanup in `beforeEach`/`afterEach` hooks; replaced `vi.waitFor()` polling assertions with `vi.advanceTimersByTimeAsync(0)` for deterministic timer flushing; removed redundant per-test timer setup code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

test(react-query-persist-client/use-queries-with-persist): switch to fake timers, replace 'waitFor' with 'vi.advanceTimersByTimeAsync', and replace 'setTimeout' with 'sleep' #9850 — Applies the same vitest fake timer refactoring pattern (switching from waitFor polling to vi.advanceTimersByTimeAsync) across other test files.

Poem

🐰 Timers tick in harmony,
No more polling, wild and free,
Setup once, then flush away,
Tests now swift, hooray, hooray! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically describes the main changes: switching to fake timers, replacing vi.waitFor calls, and moving queryClient to beforeEach hook.
Description check	✅ Passed	The description follows the template structure with detailed changes, completed checklist items, and clear release impact assessment.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/svelte-query-createQueries-fake-timers

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-05T07:47:55Z

View your CI Pipeline Execution ↗ for commit ddeef27

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	57s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-05 07:50:47 UTC

github-actions · 2026-04-05T07:48:14Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-05T07:50:09Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10388

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10388

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10388

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10388

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10388

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10388

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10388

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10388

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10388

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10388

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10388

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10388

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10388

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10388

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10388

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10388

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10388

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10388

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10388

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10388

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10388

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10388

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10388

commit: ddeef27

github-actions · 2026-04-05T07:50:17Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

test(svelte-query/createQueries): switch to fake timers, replace 'vi.…
4c698fa
…waitFor' with 'vi.advanceTimersByTimeAsync', and move 'queryClient' to 'beforeEach'

github-actionsBot added the package: svelte-query label Apr 5, 2026

sukvvon self-assigned this Apr 5, 2026

ci: apply automated fixes
ddeef27

sukvvon merged commit 7781a3e into mainApr 5, 2026
8 checks passed

sukvvon deleted the test/svelte-query-createQueries-fake-timers branch April 5, 2026 07:55

coderabbitaiBot mentioned this pull request Apr 5, 2026
test(svelte-query/createQuery): switch to fake timers, replace 'vi.waitFor' with 'vi.advanceTimersByTimeAsync', and move 'queryClient' to 'beforeEach' #10390
Merged
4 tasks

Navigation Menu

Uh oh!

Uh oh!

test(svelte-query/createQueries): switch to fake timers, replace 'vi.waitFor' with 'vi.advanceTimersByTimeAsync', and move 'queryClient' to 'beforeEach' - #10388

test(svelte-query/createQueries): switch to fake timers, replace 'vi.waitFor' with 'vi.advanceTimersByTimeAsync', and move 'queryClient' to 'beforeEach'#10388
sukvvon merged 2 commits into
mainfrom
test/svelte-query-createQueries-fake-timers

sukvvon commented Apr 5, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Apr 5, 2026•
edited
Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloudBot commented Apr 5, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 5, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Apr 5, 2026

Uh oh!

github-actionsBot commented Apr 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Apr 5, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Apr 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloudBot commented Apr 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Apr 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-newBot commented Apr 5, 2026

Uh oh!

github-actionsBot commented Apr 5, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 5, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Apr 5, 2026•
edited
Loading

nx-cloudBot commented Apr 5, 2026•
edited
Loading

github-actionsBot commented Apr 5, 2026•
edited
Loading