test(preact-query): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' by sukvvon · Pull Request #10400 · TanStack/query

sukvvon · 2026-04-06T05:41:56Z

🎯 Changes

Replace async () => { await sleep(N); return value } with () => sleep(N).then(() => value) in test queryFn and mutationFn
Applied to useQuery.test.tsx, useQueries.test.tsx, useMutation.test.tsx, usePrefetchQuery.test.tsx, useSuspenseQueries.test.tsx, and fine-grained-persister.test.tsx

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Refactored test implementations to use promise chaining patterns. No user-facing changes.

… in test 'queryFn' and 'mutationFn'

coderabbitai · 2026-04-06T05:42:12Z

📝 Walkthrough

Walkthrough

This PR converts test implementations across multiple test files from async/await syntax to promise chaining with .then(). All changes are test-only, affecting queryFn and mutationFn mock implementations while preserving timing and resolved values.

Changes

Cohort / File(s)	Summary
Query Test Function Refactors `packages/preact-query/src/__tests__/useQuery.test.tsx`, `packages/preact-query/src/__tests__/useQueries.test.tsx`, `packages/preact-query/src/__tests__/usePrefetchQuery.test.tsx`, `packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx`	Converted multiple `queryFn` implementations from `async () => { await sleep(...); return X }` to `() => sleep(...).then(() => X)`, preserving promise timing and resolved values across all query-related test cases.
Mutation Test Function Refactors `packages/preact-query/src/__tests__/useMutation.test.tsx`	Converted `mutationFn` implementations from `async (text) => { await sleep(...); return text }` to `(text) => sleep(...).then(() => text)` patterns, maintaining async behavior through direct promise chaining.
Mock Spy Refactors `packages/preact-query/src/__tests__/fine-grained-persister.test.tsx`	Changed test spy mock from `async` function with `await sleep(5)` to direct promise chain `sleep(5).then(() => 'Works from queryFn')`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

test(svelte-query): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' #10397: Applies the same async/await-to-promise-chaining refactor across corresponding query and mutation test implementations.
test(react-query): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' #10399: Implements identical test-level replacements of async/await sleep patterns with sleep().then() across the test suite.

Poem

🐰 Async hops have found a chain,
Where .then() flows without the await refrain,
Same timing, same promise delight,
Just syntax tweaks—the logic's still right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: replacing async/await sleep patterns with promise chaining in test queryFn and mutationFn implementations across multiple test files.
Description check	✅ Passed	The description follows the template structure with completed 🎯 Changes and 🚀 Release Impact sections, clearly documenting what was changed and marking it as dev-only with appropriate checklist items.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/preact-query-replace-async-await-sleep-with-then-chaining

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-06T05:42:23Z

View your CI Pipeline Execution ↗ for commit d2d2362

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 50s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-06 05:46:17 UTC

github-actions · 2026-04-06T05:42:43Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-06T05:45:10Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10400

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10400

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10400

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10400

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10400

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10400

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10400

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10400

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10400

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10400

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10400

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10400

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10400

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10400

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10400

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10400

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10400

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10400

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10400

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10400

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10400

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10400

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10400

commit: d2d2362

github-actions · 2026-04-06T05:45:19Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

coderabbitai

🧹 Nitpick comments (1)

packages/preact-query/src/__tests__/useMutation.test.tsx (1)
161-163: Redundant Promise.resolve inside .then() callback.
The .then() callback automatically wraps the returned value in a Promise, making Promise.resolve(value) unnecessary. This should just return value directly for consistency with the other changes in this PR.
Suggested fix
- mutateFn.mockImplementation((value) =>- sleep(10).then(() => Promise.resolve(value)),- )+ mutateFn.mockImplementation((value) => sleep(10).then(() => value))
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/preact-query/src/__tests__/useMutation.test.tsx` around lines 161 -
163, The mock implementation for mutateFn uses Promise.resolve inside a .then
callback which is redundant; update mutateFn.mockImplementation((value) =>
sleep(10).then(() => Promise.resolve(value))) to simply return the value from
the .then callback (i.e., .then(() => value)) so the promise resolves the same
way and matches the style of other tests; locate and change the
mutateFn.mockImplementation call in useMutation.test.tsx.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/preact-query/src/__tests__/useMutation.test.tsx`:
- Around line 161-163: The mock implementation for mutateFn uses Promise.resolve
inside a .then callback which is redundant; update
mutateFn.mockImplementation((value) => sleep(10).then(() =>
Promise.resolve(value))) to simply return the value from the .then callback
(i.e., .then(() => value)) so the promise resolves the same way and matches the
style of other tests; locate and change the mutateFn.mockImplementation call in
useMutation.test.tsx.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2f567c03-2339-478d-8002-dc10b8ce68b1

📥 Commits

Reviewing files that changed from the base of the PR and between 7d7a21c and d2d2362.

📒 Files selected for processing (6)

packages/preact-query/src/__tests__/fine-grained-persister.test.tsx
packages/preact-query/src/__tests__/useMutation.test.tsx
packages/preact-query/src/__tests__/usePrefetchQuery.test.tsx
packages/preact-query/src/__tests__/useQueries.test.tsx
packages/preact-query/src/__tests__/useQuery.test.tsx
packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx

test(preact-query): replace 'async/await sleep' with 'sleep().then()'…
aa15f2c
… in test 'queryFn' and 'mutationFn'

github-actionsBot added the package: preact-query label Apr 6, 2026

sukvvon self-assigned this Apr 6, 2026

ci: apply automated fixes
d2d2362

coderabbitaiBot reviewed Apr 6, 2026
View reviewed changes

sukvvon merged commit eac62b8 into mainApr 6, 2026
8 checks passed

sukvvon deleted the test/preact-query-replace-async-await-sleep-with-then-chaining branch April 6, 2026 06:25

coderabbitaiBot mentioned this pull request Apr 9, 2026
test(query-core): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' #10435
Merged
4 tasks

Navigation Menu

Uh oh!

Uh oh!

test(preact-query): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn' - #10400

test(preact-query): replace 'async/await sleep' with 'sleep().then()' in test 'queryFn' and 'mutationFn'#10400
sukvvon merged 2 commits into
mainfrom
test/preact-query-replace-async-await-sleep-with-then-chaining

sukvvon commented Apr 6, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Apr 6, 2026•
edited
Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloudBot commented Apr 6, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 6, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Apr 6, 2026

Uh oh!

github-actionsBot commented Apr 6, 2026

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Apr 6, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Apr 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloudBot commented Apr 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Apr 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-newBot commented Apr 6, 2026

Uh oh!

github-actionsBot commented Apr 6, 2026

size-limit report 📦

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 6, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Apr 6, 2026•
edited
Loading

nx-cloudBot commented Apr 6, 2026•
edited
Loading

github-actionsBot commented Apr 6, 2026•
edited
Loading