test({solid,svelte}-query/mutationOptions): replace 'toStrictEqual' with 'toBe' for identity check by sukvvon · Pull Request #10407 · TanStack/query

sukvvon · 2026-04-06T12:58:37Z

🎯 Changes

Replace toStrictEqual with toBe in mutationOptions identity tests for solid-query and svelte-query
toBe uses === reference equality which is the correct assertion for identity functions that return the same object
Aligns with react-query, preact-query, and all queryOptions/infiniteQueryOptions tests which already use toBe

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated test assertions for mutation options validation across Solid Query and Svelte Query packages.

…ion with 'as const'

coderabbitai · 2026-04-06T12:58:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5cfb5086-2917-4621-9815-c0a0cfb5de6b

📥 Commits

Reviewing files that changed from the base of the PR and between 2bb0029 and 0fb91e6.

📒 Files selected for processing (2)

packages/solid-query/src/__tests__/mutationOptions.test.tsx
packages/svelte-query/tests/mutationOptions/mutationOptions.svelte.test.ts

✅ Files skipped from review due to trivial changes (1)

packages/solid-query/src/tests/mutationOptions.test.tsx

📝 Walkthrough

Walkthrough

Test assertions in solid-query and svelte-query mutationOptions tests were updated to verify referential equality (toBe) instead of deep structural equality (toStrictEqual) when comparing returned options objects against their input parameters.

Changes

Cohort / File(s)	Summary
Mutation Options Test Assertions `packages/solid-query/src/__tests__/mutationOptions.test.tsx`, `packages/svelte-query/tests/mutationOptions/mutationOptions.svelte.test.ts`	Updated test expectations from `toStrictEqual(object)` to `toBe(object)` for asserting that `mutationOptions()` returns the same object reference, not just an equivalent copy.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

test({react,preact,angular}-query/{queryOptions,infiniteQueryOptions,mutationOptions}): replace 'toStrictEqual' with 'toBe' and add type annotations #10192: Directly related—modifies mutationOptions test assertions to use referential equality instead of deep equality in the same test suites.

Poem

🐰 A little tweak, so small but fine,
From deep equals to reference align,
The bunny hops with glee and cheer,
Same object, same reference, crystal clear!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: replacing toStrictEqual with toBe for identity checks in mutationOptions tests across solid-query and svelte-query packages.
Description check	✅ Passed	The description covers the key aspects: what was changed, the rationale behind the change (toBe for reference equality), and alignment with existing patterns in other packages. It properly follows the template structure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/react-preact-query-infiniteQueryOptions-use-as-const

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-06T12:59:13Z

View your CI Pipeline Execution ↗ for commit 0fb91e6

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 52s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-06 13:39:49 UTC

github-actions · 2026-04-06T12:59:30Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-06T13:01:00Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10407

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10407

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10407

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10407

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10407

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10407

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10407

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10407

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10407

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10407

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10407

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10407

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10407

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10407

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10407

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10407

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10407

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10407

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10407

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10407

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10407

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10407

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10407

commit: 0fb91e6

github-actions · 2026-04-06T13:01:11Z

size-limit report 📦

Path	Size
react full	11.98 KB (0%)
react minimal	9.01 KB (0%)

… annotation with 'as const'" This reverts commit 2bb0029.

…ith 'toBe' for identity check

test({react,preact}-query/infiniteQueryOptions): replace type annotat…
2bb0029
…ion with 'as const'

github-actionsBot added package: react-query package: preact-query labels Apr 6, 2026

sukvvon self-assigned this Apr 6, 2026

sukvvon marked this pull request as draft April 6, 2026 13:24

sukvvon added 2 commits April 6, 2026 22:33

Revert "test({react,preact}-query/infiniteQueryOptions): replace type…
8b86951
… annotation with 'as const'" This reverts commit 2bb0029.

test({solid,svelte}-query/mutationOptions): replace 'toStrictEqual' w…
0fb91e6
…ith 'toBe' for identity check

github-actionsBot added package: solid-query package: svelte-query labels Apr 6, 2026

sukvvon removed package: react-query package: preact-query labels Apr 6, 2026

sukvvon changed the title ~~test({react,preact}-query/infiniteQueryOptions): replace type annotation with 'as const'~~test({solid,svelte}-query/mutationOptions): replace 'toStrictEqual' with 'toBe' for identity checkApr 6, 2026

sukvvon marked this pull request as ready for review April 6, 2026 13:38

sukvvon merged commit 36fc645 into mainApr 6, 2026
8 checks passed

sukvvon deleted the test/react-preact-query-infiniteQueryOptions-use-as-const branch April 6, 2026 13:43

sukvvon mentioned this pull request Jul 11, 2026
test(query-core/utils,vue-query/mutationOptions): assert reference identity with 'toBe' #11048
Merged
3 tasks

Navigation Menu

Uh oh!

Uh oh!

test({solid,svelte}-query/mutationOptions): replace 'toStrictEqual' with 'toBe' for identity check - #10407

test({solid,svelte}-query/mutationOptions): replace 'toStrictEqual' with 'toBe' for identity check#10407
sukvvon merged 3 commits into
mainfrom
test/react-preact-query-infiniteQueryOptions-use-as-const

sukvvon commented Apr 6, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Apr 6, 2026•
edited
Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloudBot commented Apr 6, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 6, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Apr 6, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 6, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Apr 6, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Apr 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloudBot commented Apr 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Apr 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

pkg-pr-newBot commented Apr 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Apr 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Apr 6, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Apr 6, 2026•
edited
Loading

nx-cloudBot commented Apr 6, 2026•
edited
Loading

github-actionsBot commented Apr 6, 2026•
edited
Loading

pkg-pr-newBot commented Apr 6, 2026•
edited
Loading

github-actionsBot commented Apr 6, 2026•
edited
Loading