test(svelte-query/createQuery): add test for not fetching when 'isRestoring' is true by sukvvon · Pull Request #10440 · TanStack/query

sukvvon · 2026-04-10T02:31:02Z

🎯 Changes

Add test to verify that createQuery does not fetch queries during the restoring period when isRestoring is true
Add IsRestoringExample.svelte component that sets isRestoring context via setIsRestoringContext
Matches the existing createQueries test pattern from test(svelte-query/createQueries): add test for not fetching when 'isRestoring' is true #10382

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added test coverage for the isRestoring behavior in query creation.

…toring' is true

coderabbitai · 2026-04-10T02:31:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1bd3b03f-59c8-417e-8c6b-2170dfaa1124

📥 Commits

Reviewing files that changed from the base of the PR and between 125067c and 70b83bf.

📒 Files selected for processing (2)

packages/svelte-query/tests/createQuery/IsRestoringExample.svelte
packages/svelte-query/tests/createQuery/createQuery.svelte.test.ts

📝 Walkthrough

Walkthrough

This PR introduces test infrastructure for the isRestoring context behavior in svelte-query. It adds a test component and corresponding test suite that verify queries remain idle during restoration periods, ensuring queryFn is not called while isRestoring is active.

Changes

Cohort / File(s)	Summary
isRestoring Test Component `packages/svelte-query/tests/createQuery/IsRestoringExample.svelte`	New test component that initializes a QueryClient with `isRestoring` context set to true, creates a query with a provided `queryFn`, and renders query state (`status`, `fetchStatus`, `data`) for test assertions.
isRestoring Test Suite `packages/svelte-query/tests/createQuery/createQuery.svelte.test.ts`	New test file using fake timers to verify that `queryFn` is not invoked and query state remains `pending`/`idle` when `isRestoring` is active, both immediately and after timer advancement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

test(preact-query/useQuery): add test for not fetching during restoring period when 'isRestoring' is true #10180: Adds framework-specific tests (Svelte and Preact) that exercise the same isRestoring behavior to prevent fetching during restoration.
test(svelte-query/createQueries): add test for not fetching queries with different durations when 'isRestoring' is true #10387: Adds svelte-query tests that verify queries are not fetched while isRestoring is true for multiple query scenarios.
test(svelte-query/createQueries): add test for not fetching when 'isRestoring' is true #10382: Adds Svelte tests setting the isRestoring context and asserting no fetching occurs during restore across different query creation patterns.

Suggested labels

package: svelte-query

Poem

🐰 A rabbit's tale of queries at rest,
When restoring, they take a test,
No fetch calls ring while timers fly,
State stays idle, data shy! 🧪✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically describes the main change: adding a test for createQuery's isRestoring behavior to prevent fetching.
Description check	✅ Passed	The description covers all required template sections with clear details about changes, follows the checklist format, and correctly marks the change as dev-only with no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/svelte-query-createQuery-isRestoring

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-10T02:31:36Z

View your CI Pipeline Execution ↗ for commit 70b83bf

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	51s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-10 02:33:11 UTC

github-actions · 2026-04-10T02:32:01Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-04-10T02:32:33Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10440

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10440

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10440

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10440

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10440

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10440

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10440

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10440

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10440

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10440

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10440

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10440

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10440

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10440

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10440

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10440

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10440

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10440

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10440

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10440

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10440

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10440

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10440

commit: 70b83bf

github-actions · 2026-04-10T02:32:41Z

size-limit report 📦

Path	Size
react full	11.99 KB (0%)
react minimal	9.02 KB (0%)

test(svelte-query/createQuery): add test for not fetching when 'isRes…
70b83bf
…toring' is true

github-actionsBot added the package: svelte-query label Apr 10, 2026

sukvvon self-assigned this Apr 10, 2026

sukvvon merged commit d45ec4d into mainApr 10, 2026
10 checks passed

sukvvon deleted the test/svelte-query-createQuery-isRestoring branch April 10, 2026 02:54

sukvvon mentioned this pull request Apr 10, 2026
test(svelte-query/createQuery): move test files into 'createQuery' directory #10441
Merged
4 tasks

Ari4ka approved these changes Apr 10, 2026
View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

test(svelte-query/createQuery): add test for not fetching when 'isRestoring' is true - #10440

test(svelte-query/createQuery): add test for not fetching when 'isRestoring' is true#10440
sukvvon merged 1 commit into
mainfrom
test/svelte-query-createQuery-isRestoring

sukvvon commented Apr 10, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Apr 10, 2026•
edited
Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloudBot commented Apr 10, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Apr 10, 2026

Uh oh!

pkg-pr-newBot commented Apr 10, 2026

Uh oh!

github-actionsBot commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

sukvvon commented Apr 10, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Apr 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloudBot commented Apr 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Apr 10, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-newBot commented Apr 10, 2026

Uh oh!

github-actionsBot commented Apr 10, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Apr 10, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Apr 10, 2026•
edited
Loading

nx-cloudBot commented Apr 10, 2026•
edited
Loading