chore: enforce pnpm 11 by Sheraff · Pull Request #10749 · TanStack/query

Sheraff · 2026-05-21T21:12:24Z

Adds engines.pnpm >=11.0.0 to TanStack/query.

Scenario	Result
`pnpm@11+ install`	Allowed
`pnpm@11+ run ...`	Allowed
`pnpm@9 install`	Blocked by `engines.pnpm`
`pnpm@9 run ...`	Blocked by `engines.pnpm`
`pnpm@10 install` with default pnpm version management	Usually hands off to `packageManager` and runs as the declared pnpm version
`pnpm@10 run ...` with default pnpm version management	Usually hands off to `packageManager` and runs as the declared pnpm version
`pnpm@10 install` with version handoff disabled	Blocked by `engines.pnpm`
`pnpm@10 run ...` with version handoff disabled	Blocked by `engines.pnpm`
`pnpm@9/10 list`	Not blocked
`pnpm@9/10 exec ...`	Not blocked

Field	What It Does
`packageManager`	Helps tools/newer pnpm select or hand off to the declared pnpm version
`engines.pnpm: \">=11.0.0\"`	Fails important project workflows when an older pnpm is actually executing them
`engines.pnpm`	Does not intercept every pnpm subcommand

Summary by CodeRabbit

Chores
- Updated package manager requirement to pnpm >= 11.0.0.
- No other package metadata, scripts, dependencies, or configuration were changed.

coderabbitai · 2026-05-21T21:12:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc919012-f39d-4f96-84b5-0bd033774770

📥 Commits

Reviewing files that changed from the base of the PR and between f33186c and bb0ead4.

📒 Files selected for processing (1)

package.json

✅ Files skipped from review due to trivial changes (1)

package.json

📝 Walkthrough

Walkthrough

Root package.json now enforces a minimum pnpm version of >=11.0.0 via an engines field. No other package metadata, scripts, or dependencies changed.

Changes

Minimum pnpm version requirement

Layer / File(s)	Summary
Add pnpm version requirement `package.json`	New `engines` field specifies `pnpm >=11.0.0` as the minimum required package manager version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped through JSON, neat and spry,
I nudged a version to eleven high.
A tiny line to set the bar,
pnpm sings — we've raised the spar.
📦✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description provides detailed explanation of the change and its effects, but is missing the required checklist items and release impact sections from the template.	Complete the description by adding the checklist (Contributing guide, testing confirmation) and Release Impact section to match the repository template requirements.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: enforce pnpm 11' accurately and concisely describes the main change: adding an engines constraint to enforce pnpm version 11 or higher.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-05-21T21:13:05Z

View your CI Pipeline Execution ↗ for commit bb0ead4

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 57s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	9s	View ↗

☁️ Nx Cloud last updated this comment at 2026-05-22 16:31:33 UTC

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 8-11: The package.json has a mismatch between packageManager
("packageManager") set to "pnpm@10.24.0" and the engines constraint
("engines.pnpm") requiring ">=11.0.0"; update the packageManager entry to a pnpm
11.x pin (for example "pnpm@11.0.0" or an appropriate 11.x version) so both
packageManager and engines.pnpm align, or alternatively relax engines.pnpm to
allow 10.24.0—change the packageManager field to match the engines.pnpm
requirement to resolve the contradiction.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 43e05f84-48aa-4947-97da-e0136824cbe4

📥 Commits

Reviewing files that changed from the base of the PR and between c00ea27 and f33186c.

📒 Files selected for processing (1)

package.json

TkDodo · 2026-05-22T10:08:57Z

hmm setup tools fails:

Run pnpm install --frozen-lockfile
ERR_PNPM_UNSUPPORTED_ENGINE Unsupported environment (bad pnpm and/or Node.js version)
Your pnpm version is incompatible with "/home/runner/work/query/query".
Expected version: >=11.0.0
Got: 10.24.0

Sheraff · 2026-05-22T10:43:25Z

hmm setup tools fails:

Run pnpm install --frozen-lockfile
ERR_PNPM_UNSUPPORTED_ENGINE Unsupported environment (bad pnpm and/or Node.js version)
Your pnpm version is incompatible with "/home/runner/work/query/query".
Expected version: >=11.0.0
Got: 10.24.0

Ah yeah sorry I thought this one had been merged #10699

TkDodo · 2026-05-22T15:57:59Z

Ah yeah sorry I thought this one had been merged #10699

merged it now

pkg-pr-new · 2026-05-22T16:01:02Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10749

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10749

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@10749

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10749

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10749

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10749

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10749

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10749

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10749

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10749

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10749

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10749

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10749

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10749

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10749

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10749

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10749

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10749

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10749

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10749

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10749

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10749

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10749

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10749

commit: bb0ead4

chore: enforce pnpm 11
923a02e

Merge branch 'main' into opencode/enforce-pnpm-11
f33186c

coderabbitaiBot reviewed May 22, 2026
View reviewed changes

Comment threadpackage.json Outdated

Merge branch 'main' into opencode/enforce-pnpm-11
bb0ead4

TkDodo closed this May 22, 2026

TkDodo reopened this May 22, 2026

TkDodo approved these changes May 22, 2026
View reviewed changes

TkDodo merged commit c066ab8 into TanStack:mainMay 22, 2026
18 checks passed

coderabbitaiBot mentioned this pull request May 25, 2026
chore(deps): update all non-major dependencies #10780
Closed

coderabbitaiBot mentioned this pull request Jun 24, 2026
chore: update pnpm to 11.9.0 #10978
Merged

coderabbitaiBot mentioned this pull request Jul 15, 2026
docs(CONTRIBUTING): update pnpm version from 'v10' to 'v11' #11066
Merged

Navigation Menu

Uh oh!

Uh oh!

chore: enforce pnpm 11 - #10749

chore: enforce pnpm 11#10749
TkDodo merged 3 commits into
TanStack:mainfrom
Sheraff:opencode/enforce-pnpm-11

Sheraff commented May 21, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented May 21, 2026•
edited
Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

nx-cloudBot commented May 21, 2026•
edited
Loading

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

TkDodo commented May 22, 2026

Uh oh!

Sheraff commented May 22, 2026•
edited
Loading

Uh oh!

TkDodo commented May 22, 2026

Uh oh!

pkg-pr-newBot commented May 22, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Sheraff commented May 21, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented May 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

nx-cloudBot commented May 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TkDodo commented May 22, 2026

Uh oh!

Sheraff commented May 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TkDodo commented May 22, 2026

Uh oh!

pkg-pr-newBot commented May 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sheraff commented May 21, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented May 21, 2026•
edited
Loading

nx-cloudBot commented May 21, 2026•
edited
Loading

Sheraff commented May 22, 2026•
edited
Loading

pkg-pr-newBot commented May 22, 2026•
edited
Loading