fix(query-core): reset isPlaceholderData when select throws on placeholder data by chatman-media · Pull Request #11011 · TanStack/query

chatman-media · 2026-06-30T22:20:34Z

When a query has placeholderData set and is still pending, createResult() applies the placeholder and sets isPlaceholderData = true. If select then throws on that placeholder value, the catch block recomputes error/data/status for the error state but never resets isPlaceholderData, so it stays true. You end up with { isError: true, isPlaceholderData: true }, a combination the QueryObserverResult discriminated union in types.ts says can't happen — every error variant hard-codes isPlaceholderData: false.

Fix is just setting isPlaceholderData = false alongside the other fields in that block. Added a regression test next to the existing "selector throws" tests, asserting via getCurrentResult() right after construction (that's where the bad state is actually observable, since it gets masked on subsequent renders by the placeholder memoization shortcut).

Summary by CodeRabbit

Bug Fixes
- Fixed an issue where results could be incorrectly labeled as placeholder data when selection failed.
- Error states now consistently clear placeholder-data indicators and return no data when selection throws.
Tests
- Added coverage for selection errors involving placeholder data.

…older data

coderabbitai · 2026-06-30T22:21:24Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 45f44522-7527-4a55-8203-a7e0d13c477b

📥 Commits

Reviewing files that changed from the base of the PR and between 18c1c1e and 026dcd1.

📒 Files selected for processing (3)

.changeset/fix-placeholder-data-select-error.md
packages/query-core/src/__tests__/queryObserver.test.tsx
packages/query-core/src/queryObserver.ts

🚧 Files skipped from review as they are similar to previous changes (3)

.changeset/fix-placeholder-data-select-error.md
packages/query-core/src/queryObserver.ts
packages/query-core/src/tests/queryObserver.test.tsx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

This PR resets isPlaceholderData when QueryObserver selection throws, adds regression coverage for the error result, and records the fix in a changeset.

Changes

Placeholder Data Error Fix

Layer / File(s)	Summary
Reset placeholder state on select error `packages/query-core/src/queryObserver.ts`, `packages/query-core/src/__tests__/queryObserver.test.tsx`, `.changeset/fix-placeholder-data-select-error.md`	`isPlaceholderData` is cleared when `select` throws. The test verifies the error result has `isPlaceholderData: false` and `data: undefined`. A patch changeset records the fix.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk:⚪ Minimal · up to 026dc

This narrowly resets placeholder-state metadata when selector processing produces an error, with a regression test covering the affected result. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description clearly explains the bug, fix, and regression test, but it omits the required Changes, Checklist, and Release Impact headings and checklist entries.	Use the repository template headings and complete the checklist, including the testing status and confirmation that the changeset was generated.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the query-core bug fix for resetting isPlaceholderData when select throws.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai · 2026-08-18T08:33:34Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

nx-cloud · 2026-08-18T08:34:02Z

View your CI Pipeline Execution ↗ for commit 026dcd1

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	7m 51s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 50s	View ↗

☁️ Nx Cloud last updated this comment at 2026-08-18 08:42:42 UTC

pkg-pr-new · 2026-08-18T08:37:28Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11011

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11011

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11011

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11011

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11011

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11011

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11011

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11011

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11011

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11011

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11011

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11011

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11011

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11011

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11011

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11011

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11011

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11011

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11011

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11011

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11011

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11011

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11011

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11011

commit: 026dcd1

fix(query-core): reset isPlaceholderData when select throws on placeh…
8567c49
…older data

coderabbitaiBot mentioned this pull request Jul 13, 2026
[FEAT] 타이머, 타임박스 API 연동 (재생/연장/완료/종료) Team-Timo/Timo-client#184
Merged
10 tasks

This was referenced Jul 21, 2026
[FEAT] mock data를 활용해 임시 UI 구성 koscom-team01/koslink-fe#4
Merged
fix(web): search workbooks server-side in the attach picker Jan-IngenHousz-Institute/open-jii#1846
Merged

Merge branch 'main' into fix/placeholder-data-select-error
e0e7191

coderabbitaiBot mentioned this pull request Aug 5, 2026
feat(query-core): pass a context object to the placeholderData function #11141
Closed

This was referenced Aug 9, 2026
Stale select error from a previous query leaks into the next query's pending result #11160
Closed
fix(query-core): clear stale select error when observer switches to a query without data #11161
Merged

coderabbitaiBot mentioned this pull request Aug 10, 2026
refactor(web): prevent query failures from forcing 500 redirects QuantumNous/new-api#6762
Draft
11 tasks

TkDodo approved these changes Aug 18, 2026
View reviewed changes

Merge branch 'main' into fix/placeholder-data-select-error
026dcd1

TkDodo merged commit ba4650c into TanStack:mainAug 18, 2026
9 checks passed

github-actionsBot mentioned this pull request Aug 18, 2026
ci: Version Packages #11206
Open

Navigation Menu

Uh oh!

Uh oh!

fix(query-core): reset isPlaceholderData when select throws on placeholder data - #11011

fix(query-core): reset isPlaceholderData when select throws on placeholder data#11011
TkDodo merged 3 commits into
TanStack:mainfrom
chatman-media:fix/placeholder-data-select-error

chatman-media commented Jun 30, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Jun 30, 2026•
edited
Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitaiBot commented Aug 18, 2026

Uh oh!

nx-cloudBot commented Aug 18, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

chatman-media commented Jun 30, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Jun 30, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitaiBot commented Aug 18, 2026

Uh oh!

nx-cloudBot commented Aug 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chatman-media commented Jun 30, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jun 30, 2026•
edited
Loading

nx-cloudBot commented Aug 18, 2026•
edited
Loading