test(query-core/utils): add tests for 'undefined' key properties and 'isValidTimeout' validation by whizzkid1452 · Pull Request #11013 · TanStack/query

whizzkid1452 · 2026-07-01T05:48:10Z

🎯 Changes

Adds tests for query-core utils behavior that was executed but never asserted:

hashKey / partialMatchKey: query key objects with undefined-valued properties are treated the same as objects without those properties.
isValidTimeout: accepts finite non-negative numbers and rejects -1, NaN, Infinity, non-numbers and undefined. This function gates staleTime, gcTime and refetchInterval, but had no direct test coverage.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Clarify isValidTimeout with Number.isFinite, add regression tests for undefined query-key object properties, and fix TanStack branding in community resources.

coderabbitai · 2026-07-01T05:48:52Z

📝 Walkthrough

Walkthrough

Updates isValidTimeout to require finite non-negative numbers, adds tests for timeout and query-key utility behavior, and corrects the capitalization of the Query Visualizer documentation entry.

Changes

isValidTimeout Validation Update

Layer / File(s)	Summary
Finite timeout validation and query-key tests `packages/query-core/src/utils.ts`, `packages/query-core/src/__tests__/utils.test.tsx`	`isValidTimeout` now requires finite non-negative values, with tests covering valid and invalid inputs plus undefined-property behavior in `hashKey` and `partialMatchKey`.

Documentation Fix

Layer / File(s)	Summary
Community resources title fix `docs/community-resources.md`	Corrected “Tanstack Query Visualizer” to “TanStack Query Visualizer”.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly describes the added query-core tests and timeout validation change, though it omits the minor docs-only capitalization fix.
Description check	✅ Passed	The description matches the template with Changes, Checklist, and Release Impact sections, and the key fields are filled in.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-07-17T03:24:05Z

View your CI Pipeline Execution ↗ for commit a1c97b2

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	8m 5s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 54s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-17 03:33:02 UTC

pkg-pr-new · 2026-07-17T03:27:26Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11013

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11013

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11013

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11013

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11013

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11013

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11013

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11013

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11013

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11013

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11013

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11013

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11013

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11013

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11013

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11013

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11013

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11013

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11013

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11013

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11013

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11013

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11013

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11013

commit: a1c97b2

test(query-core): cover query key undefined and timeout validation
c2fbdd2
Clarify isValidTimeout with Number.isFinite, add regression tests for undefined query-key object properties, and fix TanStack branding in community resources.

Merge branch 'main' into feature/query-key-timeout-test-coverage
8cbfe1e

sukvvon reviewed Jul 17, 2026
View reviewed changes

Comment threaddocs/community-resources.md Outdated

Update docs/community-resources.md
5c4c761

sukvvon reviewed Jul 17, 2026
View reviewed changes

Comment threadpackages/query-core/src/utils.ts Outdated

Update packages/query-core/src/utils.ts
a1c97b2

sukvvon changed the title ~~test(query-core): cover query key undefined and timeout validation~~test(query-core/utils): add tests for 'undefined' object properties in 'hashKey'/'partialMatchKey' and 'isValidTimeout'Jul 17, 2026

sukvvon changed the title ~~test(query-core/utils): add tests for 'undefined' object properties in 'hashKey'/'partialMatchKey' and 'isValidTimeout'~~test(query-core/utils): add tests for 'undefined' key properties and 'isValidTimeout' validationJul 17, 2026

sukvvon approved these changes Jul 17, 2026
View reviewed changes

sukvvon merged commit a9aa23f into TanStack:mainJul 17, 2026
9 checks passed

coderabbitaiBot mentioned this pull request Jul 17, 2026
test(query-core/utils): split 'isValidTimeout' rejection cases into separate 'it' blocks #11071
Merged
4 tasks

whizzkid1452 deleted the feature/query-key-timeout-test-coverage branch July 21, 2026 08:44

Navigation Menu

Uh oh!

Uh oh!

test(query-core/utils): add tests for 'undefined' key properties and 'isValidTimeout' validation - #11013

test(query-core/utils): add tests for 'undefined' key properties and 'isValidTimeout' validation#11013
sukvvon merged 4 commits into
TanStack:mainfrom
whizzkid1452:feature/query-key-timeout-test-coverage

whizzkid1452 commented Jul 1, 2026•
edited by sukvvon
Loading

Uh oh!

coderabbitaiBot commented Jul 1, 2026•
edited
Loading

Walkthrough

Changes

Uh oh!

Uh oh!

Uh oh!

nx-cloudBot commented Jul 17, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Jul 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

whizzkid1452 commented Jul 1, 2026• edited by sukvvon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

coderabbitaiBot commented Jul 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Uh oh!

Uh oh!

nx-cloudBot commented Jul 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Jul 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

whizzkid1452 commented Jul 1, 2026•
edited by sukvvon
Loading

coderabbitaiBot commented Jul 1, 2026•
edited
Loading

nx-cloudBot commented Jul 17, 2026•
edited
Loading