test({react,preact}-query): use the '.then()' convention consistently by sukvvon · Pull Request #11085 · TanStack/query

sukvvon · 2026-07-20T01:04:18Z

🎯 Changes

Several queryFn/mutationFn implementations were left as async/await even though the surrounding tests in each file overwhelmingly use the .then() convention. This PR converts the remaining cases where a side effect (counter increment, .push(), throw) happens strictly after await sleep(...), so it can be expressed as sleep(...).then(() => { ... }) without changing execution order.

Cases where a side effect happens beforesleep(...) are intentionally left as async/await, since converting them would require pulling the side effect out of the .then() callback and wouldn't shorten or clarify the code.

useInfiniteQuery: converted 2 queryFns in both react-query and preact-query
useMutation: converted several mutationFns (removed unnecessary async on already-.then()-based functions, converted sleep-then-effect cases) in both packages
useQueries: converted queryFns with post-sleep side effects, removed unnecessary async on functions with no await
useQuery (+ useQuery.promise, useSuspenseQuery in react-query): converted queryFns with post-sleep side effects/throws

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated asynchronous test scenarios across query, mutation, infinite query, suspense, and multi-query behavior.
- Preserved coverage for refetching, retries, error handling, pagination, promise combinations, and rendering behavior.
- Standardized test promise handling without changing expected results or assertions.

…tion consistently

…consistently

…onsistently

…sistently

github-actions · 2026-07-20T01:05:31Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-07-20T01:09:47Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11085

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11085

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11085

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11085

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11085

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11085

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11085

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11085

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11085

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11085

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11085

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11085

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11085

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11085

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11085

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11085

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11085

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11085

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11085

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11085

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11085

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11085

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11085

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11085

commit: 79c2287

github-actions · 2026-07-20T01:10:49Z

size-limit report 📦

Path	Size
react full	12.13 KB (0%)
react minimal	9.08 KB (0%)

nx-cloud · 2026-07-20T01:10:50Z

View your CI Pipeline Execution ↗ for commit 79c2287

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 34s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-20 01:20:55 UTC

coderabbitai · 2026-07-20T01:31:31Z

📝 Walkthrough

Walkthrough

Test-only refactors replace async/await query and mutation functions with explicit sleep(...).then(...) Promise chains across React and Preact packages, preserving existing return values, delays, counters, pagination, retries, and rejection behavior.

Changes

Promise-chain test fixture refactor

Layer / File(s)	Summary
Preact query fixture conversions `packages/preact-query/src/__tests__/useInfiniteQuery.test.tsx`, `useQueries.test.tsx`, `useQuery.test.tsx`	Query functions now return Promise chains while preserving query results, pagination fields, counters, refetch behavior, and error paths.
Preact mutation fixture conversions `packages/preact-query/src/__tests__/useMutation.test.tsx`	Mutation fixtures use Promise chains for callback errors, retries, conditional outcomes, custom clients, and Promise combinators.
React query fixture conversions `packages/react-query/src/__tests__/useInfiniteQuery.test.tsx`, `useQueries.test.tsx`, `useQuery.promise.test.tsx`, `useQuery.test.tsx`, `useSuspenseQuery.test.tsx`	Query and suspense fixtures remove async wrappers while retaining existing results, errors, timing, and state-transition scenarios.
React mutation fixture conversions `packages/react-query/src/__tests__/useMutation.test.tsx`	Mutation fixtures preserve callback, retry, error, custom-client, and parallel mutation behavior through explicit Promise chains.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

TanStack/query#10948: Modifies overlapping mutation callback and success/error coverage.
TanStack/query#11082: Modifies the same infinite-query pagination/refetch fixture.
TanStack/query#11088: Applies the same async/await-to-Promise-chain test refactor.

Suggested labels:package: react-query, package: preact-query

Suggested reviewers:tkdodo

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main change: standardizing test functions to use the .then() style.
Description check	✅ Passed	The description matches the template and covers changes, checklist, and release impact with clear detail.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/react-preact-query-then-convention

_{Comment @coderabbitai help to get the list of available commands.}

sukvvon added 4 commits July 20, 2026 10:03

test({react,preact}-query/useInfiniteQuery): use the '.then()' conven…
574b9f2
…tion consistently

test({react,preact}-query/useMutation): use the '.then()' convention …
7f905b5
…consistently

test({react,preact}-query/useQueries): use the '.then()' convention c…
1bf2f9b
…onsistently

test({react,preact}-query/useQuery): use the '.then()' convention con…
79c2287
…sistently

sukvvon self-assigned this Jul 20, 2026

sukvvon merged commit 6d55b07 into mainJul 20, 2026
11 of 12 checks passed

sukvvon deleted the test/react-preact-query-then-convention branch July 20, 2026 10:38

coderabbitaiBot mentioned this pull request Jul 21, 2026
test({react,preact}-query/usePrefetchQuery): use the '.then()' convention consistently #11091
Merged
4 tasks

Navigation Menu

Uh oh!

Uh oh!

test({react,preact}-query): use the '.then()' convention consistently - #11085

test({react,preact}-query): use the '.then()' convention consistently#11085
sukvvon merged 4 commits into
mainfrom
test/react-preact-query-then-convention

sukvvon commented Jul 20, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

github-actionsBot commented Jul 20, 2026

Uh oh!

pkg-pr-newBot commented Jul 20, 2026

Uh oh!

github-actionsBot commented Jul 20, 2026

Uh oh!

nx-cloudBot commented Jul 20, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented Jul 20, 2026•
edited
Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Jul 20, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

github-actionsBot commented Jul 20, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-newBot commented Jul 20, 2026

Uh oh!

github-actionsBot commented Jul 20, 2026

size-limit report 📦

Uh oh!

nx-cloudBot commented Jul 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitaiBot commented Jul 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Jul 20, 2026•
edited by coderabbitai Bot
Loading

nx-cloudBot commented Jul 20, 2026•
edited
Loading

coderabbitaiBot commented Jul 20, 2026•
edited
Loading