Skip to content

test(lit-query): replace 'toBeDefined'/'toBeGreaterThan' with exact-value assertions#11122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 1 commit into from
Jul 26, 2026
+13 −10
Merged

test(lit-query): replace 'toBeDefined'/'toBeGreaterThan' with exact-value assertions #11122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/lit-query/src/tests/counters-and-state.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -272,8 +272,9 @@ describe('useIsFetching/useIsMutating/useMutationState', () => {
await waitFor(() => consumer.isMutating() === 0)

expect(
explicitClient.getQueryCache().find({ queryKey: consumer.queryKey }),
).toBeDefined()
explicitClient.getQueryCache().find({ queryKey: consumer.queryKey })
?.state.data,
).toBe('query-ok')
expect(
providerClient.getQueryCache().find({ queryKey: consumer.queryKey }),
).toBeUndefined()
Expand Down
5 changes: 3 additions & 2 deletions packages/lit-query/src/tests/infinite-and-options.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -118,8 +118,9 @@ describe('createInfiniteQueryController', () => {
await waitFor(() => consumer.infinite().isSuccess)
expect(consumer.infinite().data?.pages).toEqual([0])
expect(
explicitClient.getQueryCache().find({ queryKey: consumer.queryKey }),
).toBeDefined()
explicitClient.getQueryCache().find({ queryKey: consumer.queryKey })
?.state.data,
).toEqual({ pages: [0], pageParams: [0] })
expect(
providerClient.getQueryCache().find({ queryKey: consumer.queryKey }),
).toBeUndefined()
Expand Down
5 changes: 3 additions & 2 deletions packages/lit-query/src/tests/queries-controller.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,8 +179,9 @@ describe('createQueriesController', () => {
)

expect(
explicitClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! }),
).toBeDefined()
explicitClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! })
?.state.data,
).toBe('alpha')
expect(
providerClient.getQueryCache().find({ queryKey: consumer.queryKeys[0]! }),
).toBeUndefined()
Expand Down
8 changes: 4 additions & 4 deletions packages/lit-query/src/tests/query-controller.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1154,7 +1154,7 @@ describe('createQueryController', () => {
await waitFor(() => query().isSuccess)

const cacheQuery = client.getQueryCache().find({ queryKey })
expect(cacheQuery).toBeDefined()
expect(cacheQuery?.state.data).toEqual(['a', 'b'])
expect(cacheQuery?.getObserversCount()).toBe(1)

host.disconnect()
Expand DownExpand Up@@ -1196,8 +1196,8 @@ describe('createQueryController', () => {
await consumer.updateComplete

await waitFor(() => consumer.query().isSuccess)
expect(consumer.query().data).toBeDefined()
expect(consumer.queryCalls).toBeGreaterThan(0)
expect(consumer.queryCalls).toBe(1)
expect(consumer.query().data).toBe('value-1')

consumer.query.destroy()
provider.remove()
Expand DownExpand Up@@ -1232,7 +1232,7 @@ describe('createQueryController', () => {
await consumer.updateComplete
await waitFor(() => consumer.query().isSuccess)

expect(consumer.query().data).toBeDefined()
expect(consumer.query().data).toBe('value-1')

consumer.query.destroy()
provider.remove()
Expand Down
Loading