Skip to content

Add useMemo() to useQueries() to avoid constant rerendering - #2992

Merged
TkDodo merged 3 commits into
TanStack:masterfrom
alecf:alecf-useQueries-caching
Nov 24, 2021
Merged

Add useMemo() to useQueries() to avoid constant rerendering#2992
TkDodo merged 3 commits into
TanStack:masterfrom
alecf:alecf-useQueries-caching

Conversation

@alecf

Copy link
Copy Markdown
Contributor

fixes#2991

@vercel

vercelBot commented Nov 19, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/CT1UyzGmyEjfCcyFn97c1CSZqGE4
✅ Preview: https://react-query-git-fork-alecf-alecf-usequeries-caching-tanstack.vercel.app

@codesandbox-ci

codesandbox-ciBot commented Nov 19, 2021

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11ae1f1:

SandboxSource
tannerlinsley/react-queryConfiguration
tannerlinsley/react-query: basic-typescriptConfiguration

@codecov

codecovBot commented Nov 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2992 (11ae1f1) into master (7948e7a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #2992 +/- ##
==========================================
+ Coverage 96.41% 96.42% +0.01% 
==========================================
Files 45 45 Lines 2229 2238 +9 Branches 638 641 +3 ==========================================
+ Hits 2149 2158 +9 
Misses 77 77 Partials 3 3 
Impacted FilesCoverage Δ
src/react/useQueries.ts100.00% <100.00%> (ø)
src/core/query.ts100.00% <0.00%> (ø)
src/core/queryObserver.ts100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2727c1...11ae1f1. Read the comment docs.

@TkDodo
TkDodo merged commit c6906b3 into TanStack:masterNov 24, 2021
@tannerlinsley

Copy link
Copy Markdown
Member

🎉 This PR is included in version 3.33.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alecf
alecf deleted the alecf-useQueries-caching branch July 1, 2022 23:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useQueries causes constant rerenders

3 participants

@alecf@tannerlinsley@TkDodo