Skip to content

nonce for devtools style - #3506

Merged
TkDodo merged 4 commits into
TanStack:masterfrom
New-Future:master
Apr 21, 2022
Merged

nonce for devtools style#3506
TkDodo merged 4 commits into
TanStack:masterfrom
New-Future:master

Conversation

@NewFuture

@NewFutureNewFuture commented Apr 14, 2022

Copy link
Copy Markdown
Contributor
  • pass nonce to devtools
  • webpack__nonce
  • set style scoped

fix#3495

@vercel

vercelBot commented Apr 14, 2022•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/AizfZdDpUCrSufKYmZ6wEMznRYFE
✅ Preview: https://react-query-git-fork-newfuture-master-tanstack.vercel.app

@NewFutureNewFuture mentioned this pull request Apr 14, 2022
Closed
@codesandbox-ci

codesandbox-ciBot commented Apr 14, 2022•
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3496c14:

SandboxSource
tannerlinsley/react-queryConfiguration
tannerlinsley/react-query: basic-typescriptConfiguration
cocky-hugle-iuwrngIssue #3495

@codecov

codecovBot commented Apr 14, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3506 (3496c14) into master (70e3d47) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@ Coverage Diff @@## master #3506 +/- ##
==========================================
- Coverage 96.41% 96.36% -0.05% 
==========================================
Files 45 45 Lines 2286 2286 Branches 642 642 ==========================================
- Hits 2204 2203 -1 - Misses 79 80 +1 
Partials 3 3
Impacted FilesCoverage Δ
src/devtools/devtools.tsx78.68% <50.00%> (-0.41%)⬇️
src/react/Hydrate.tsx100.00% <0.00%> (ø)
src/react/tests/utils.tsx97.14% <0.00%> (ø)
src/react/QueryClientProvider.tsx100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4ef9b...3496c14. Read the comment docs.

TkDodo
TkDodo requested changes Apr 15, 2022
View reviewed changes
Comment threadsrc/devtools/devtools.tsx Outdated
Comment threadsrc/devtools/devtools.tsx Outdated
@vercel

vercelBot commented Apr 18, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
react-query✅ Ready (Inspect)Visit PreviewApr 21, 2022 at 0:17AM (UTC)

@NewFuture

NewFuture commented Apr 20, 2022

Copy link
Copy Markdown
ContributorAuthor

@TkDodo help review 😸

TkDodo
TkDodo reviewed Apr 21, 2022
View reviewed changes
Comment threadsrc/devtools/devtools.tsx Outdated
TkDodo
TkDodo reviewed Apr 21, 2022
View reviewed changes
Comment threadsrc/devtools/tests/devtools.test.tsx Outdated
@TkDodo
TkDodo merged commit b7a07c2 into TanStack:masterApr 21, 2022
@tannerlinsley

tannerlinsley commented Apr 21, 2022

Copy link
Copy Markdown
Member

🎉 This PR is included in version 3.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley

tannerlinsley commented Apr 21, 2022

Copy link
Copy Markdown
Member

🎉 This PR is included in version 4.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@icf-mrankinicf-mrankin mentioned this pull request Nov 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees

No one assigned

Labels

released on @betareleased

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CSP enabled DevTool show errors (insert inline style)

3 participants

@NewFuture@tannerlinsley@TkDodo