feat(devtools): enable setting loading/error via devtools - #4352

Merged
TkDodo merged 41 commits into
TanStack:mainfrom
paul-sachs:error--and-loading-devtools
Mar 15, 2023
Merged

feat(devtools): enable setting loading/error via devtools#4352
TkDodo merged 41 commits into
TanStack:mainfrom
paul-sachs:error--and-loading-devtools

Conversation

@paul-sachs

@paul-sachspaul-sachs commented Oct 21, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Allows the devtools to toggle loading and errors states (at least until the next fetch is triggered).

Things to do:

  • Make sure onError get's triggered
Screen.Recording.2022-10-21.at.10.41.06.AM.mov

@codesandbox-ci

codesandbox-ciBot commented Oct 21, 2022•
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a4ff17e:

SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration

@TkDodo
TkDodo marked this pull request as ready for review January 23, 2023 12:10
@codecov-commenter

codecov-commenter commented Jan 23, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Base: 91.84% // Head: 92.16% // Increases project coverage by +0.31% 🎉

Coverage data is based on head (356e26e) compared to base (48e806b).
Patch coverage: 97.56% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## main #4352 +/- ##
==========================================
+ Coverage 91.84% 92.16% +0.31% 
==========================================
Files 111 111 Lines 4146 4187 +41 Branches 1072 1087 +15 ==========================================
+ Hits 3808 3859 +51 + Misses 317 307 -10 
Partials 21 21
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts92.85% <ø> (ø)
packages/react-query-devtools/src/devtools.tsx89.09% <97.56%> (+5.16%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo

TkDodo commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator

@paul-sachs thanks for this PR, and sorry that it went unnoticed for a while. I've fixed some issues and did a bit of refactoring.

What would be missing from my perspective would be:

  • some tests of the new behaviour
  • a way to make the loading state revert back when clicking the button a second time, and maybe some visual feedback that we are now in loading state (similar to what the offline toggle button does)

would you like to continue contributing this?

@paul-sachs

paul-sachs commented Jan 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @TkDodo I'll take a look for sure. I'll need to familiarize myself with the testing setup but that should be fine. Storing the previous state is a little tricky if I remember correctly. I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.

@TkDodo

TkDodo commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator

I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.

That's fine - I like the resetQueries approach that you've already taken for the error state. But the only way to get out of the loading state right now is to click refetch, and I think it would be good if the button behaved like a toggle. Alternatively, we could keep the last state in a ref before overwriting it and then restore it maybe?

@paul-sachs

paul-sachs commented Jan 23, 2023

Copy link
Copy Markdown
ContributorAuthor

I'd worry what would happen if something toggles loading state during loading. I'm not sure how setState works internally, don't know if it will abort the on going promise. Feels a little like reset is our safest bet. Either way really, the toggle behaviour makes sense.

@paul-sachs

paul-sachs commented Jan 23, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

So I've fixed the toggle state, however this approach doesn't seem to work in suspense mode since the setState doesn't trigger a promise... This will need something else to work through that issue.

@paul-sachs

paul-sachs commented Jan 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Was hoping to do something like:

activeQuery.fetch({queryFn: ()=>newPromise((resolve,reject)=>{}),cacheTime: -1,})

But i don't think that's replacing the queryFn like I thought it would. It triggers a refetch of the existing queryFn...

@paul-sachs

paul-sachs commented Jan 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Ah no, i was incorrect. It is using the updated queryFn. At least, I think it is. The problem is trying to store the previous queryFn so I can restore it...

@paul-sachs

paul-sachs commented Jan 23, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Alright, managed to get suspense working. Had to store some query state inside queryMeta so not sure I feel great about that, but it does keep query state all together. Maybe there's a better place to store it?

Next, I'll take a look at the testing infrastructure to figure out how to write some tests.

@paul-sachs

paul-sachs commented Jan 23, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@TkDodo Tests are up and green. I've represented the current state of the query in the buttons themselves but let me know if you want a totally different direction.

@vercel

vercelBot commented Jan 26, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 15, 2023 at 8:09AM (UTC)

@paul-sachs

paul-sachs commented Feb 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Alright, finally got to fixing prettier + lint issues.

@TkDodoTkDodo mentioned this pull request Mar 14, 2023
Closed
9 tasks
TkDodoand others added 25 commits March 15, 2023 09:07
@TkDodo
chore: releases should run on alpha/beta as well
bef1f52
@TkDodo
chore: extract package validation to an extra script (TanStack#5039)
7d3e61d
* chore: extract package validation to an extra script
and run it during CI
* chore: add missing `build:types` script to solid-query
@cseas@TkDodo
docs: update link for v2 docs (TanStack#5044)
30ba660
* docs: update link for v2 docs
* Update README.md
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.12
590dba2
@janinegygax@TkDodo
fix(react-query-devtools): do not stretch query status label (TanStac…
f38b567
…k#5063)
Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view.
@tannerlinsley@TkDodo
release: v4.24.13
82a6377
@yousoumar@TkDodo
fix(react-query-devtools): add 'use client' directive to disable SSR (T…
8db407f
…anStack#5041)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.14
9561549
@remolueoend@TkDodo
feat(core): re-export matchQuery from utils (TanStack#5070)
5abe521
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.25.0
a2c0c05
@TkDodo
feat(query-core): Add global onSettled callbacks for QueryCache and M…
f57e25c
…utationCache (TanStack#5075)
* feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache
* test: tests for query onSettled callback
* test: tests for mutation onSettled callback
* docs: onSettled callbacks
@tannerlinsley@TkDodo
release: v4.26.0
761e312
@TkDodo
fix(core): make sure mutations get updated options (TanStack#5085)
93ecbc8
this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure
@tannerlinsley@TkDodo
release: v4.26.1
fca67f6
@Newbie012@TkDodo
fix(eslint-plugin): improve object property checks (TanStack#5079)
7a8654f
* fix(eslint-plugin): improve object property checks
* prettier
@tannerlinsley@TkDodo
release: v4.26.2
1be904a
@DamianOsipiuk@TkDodo
docs: add adapter dropdown to issue template (TanStack#5108)
c28f64c
@leon-fong@TkDodo
docs(queries): renamesuccess(TanStack#5110)
9ac386b
@ZackDeRose@TkDodo
chore:test:libtask-caching w/ Nx (TanStack#5116)
c372c2e
* adding quick caching test
* reverting workflow change
* updating pr yml to test nx speed
* fixing yml on property
* fixing yml on property
* fixing target name
* upping to running4 in parallel
* upping to running 5 in parallel
* upping to running 6 in parallel
* upping to running 7 in parallel
* upping to running 8 in parallel
* upping to running 9 in parallel
* upping to running 10 in parallel
* opting for --parallel=5
* cleaning up nx.json
* revert touching of ci.yml file
* reverting on property of pr.yml file
* updating root pacakge.json test:lib command
* fixing frozen lockfile error in ci
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@TkDodo
chore: fix missing dependencies (TanStack#5127)
dae70a8
* chore: include scripts directory in linting
and fix issues
* chore: add missing dependencies chalk and semver
@ZackDeRose@TkDodo
chore: turning off Nx daemon in CI (TanStack#5128)
7d9878f
@TkDodo
chore: downgrade chalk to v4 because v5 is ESM only (TanStack#5130)
e9c61f1
see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module
@Newbie012@TkDodo
fix(eslint-plugin): ignore internal properties (TanStack#5119)
9f043a0
@TkDodo
chore: resolve merge conflicts
3ad2ba3
@TkDodo
Merge branch 'main' into error--and-loading-devtools
a4ff17e
@TkDodo
TkDodo merged commit b7089d1 into TanStack:mainMar 15, 2023
@paul-sachs

paul-sachs commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

@TkDodo My apologies for letting this drop off. I'll submit a follow on PR with the suggested changes. Thanks so much for merging this, it'll make modifying loading states so much easier!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@paul-sachs@codecov-commenter@TkDodo@cseas@tannerlinsley@janinegygax@yousoumar@remolueoend@Newbie012@DamianOsipiuk@leon-fong@ZackDeRose
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(devtools): enable setting loading/error via devtools - #4352
Merged
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Mar 15, 2023
Merged
feat(devtools): enable setting loading/error via devtools#4352
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Conversation
@paul-sachs
@paul-sachspaul-sachs
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Allows the devtools to toggle loading and errors states (at least until the next fetch is triggered).
Things to do:
  •  Make sure onError get's triggered
Screen.Recording.2022-10-21.at.10.41.06.AM.mov
@codesandbox-ci
codesandbox-ciBot
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a4ff17e:
SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration
@TkDodo
TkDodo
marked this pull request as ready for review
January 23, 2023 12:10
@codecov-commenter
codecov-commenter
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.84% // Head: 92.16% // Increases project coverage by +0.31% 🎉
Coverage data is based on head (356e26e) compared to base (48e806b).

Patch coverage: 97.56% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #4352 +/- ##
==========================================
+ Coverage 91.84% 92.16% +0.31% 
==========================================
Files 111 111 Lines 4146 4187 +41 Branches 1072 1087 +15 ==========================================
+ Hits 3808 3859 +51 + Misses 317 307 -10 
Partials 21 21 
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts92.85% <ø> (ø)
packages/react-query-devtools/src/devtools.tsx89.09% <97.56%> (+5.16%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
@paul-sachs thanks for this PR, and sorry that it went unnoticed for a while. I've fixed some issues and did a bit of refactoring.
What would be missing from my perspective would be:
  • some tests of the new behaviour
  • a way to make the loading state revert back when clicking the button a second time, and maybe some visual feedback that we are now in loading state (similar to what the offline toggle button does)
would you like to continue contributing this?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Hi @TkDodo I'll take a look for sure. I'll need to familiarize myself with the testing setup but that should be fine. Storing the previous state is a little tricky if I remember correctly. I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
That's fine - I like the resetQueries approach that you've already taken for the error state. But the only way to get out of the loading state right now is to click refetch, and I think it would be good if the button behaved like a toggle. Alternatively, we could keep the last state in a ref before overwriting it and then restore it maybe?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
I'd worry what would happen if something toggles loading state during loading. I'm not sure how setState works internally, don't know if it will abort the on going promise. Feels a little like reset is our safest bet. Either way really, the toggle behaviour makes sense.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So I've fixed the toggle state, however this approach doesn't seem to work in suspense mode since the setState doesn't trigger a promise... This will need something else to work through that issue.
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Was hoping to do something like:
activeQuery.fetch({queryFn: ()=>newPromise((resolve,reject)=>{}),cacheTime: -1,})
But i don't think that's replacing the queryFn like I thought it would. It triggers a refetch of the existing queryFn...
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Ah no, i was incorrect. It is using the updated queryFn. At least, I think it is. The problem is trying to store the previous queryFn so I can restore it...
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Alright, managed to get suspense working. Had to store some query state inside queryMeta so not sure I feel great about that, but it does keep query state all together. Maybe there's a better place to store it?
Next, I'll take a look at the testing infrastructure to figure out how to write some tests.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@TkDodo Tests are up and green. I've represented the current state of the query in the buttons themselves but let me know if you want a totally different direction.
@vercel
vercelBot
commented
Jan 26, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 15, 2023 at 8:09AM (UTC)
@paul-sachs
paul-sachs
commented
Feb 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Alright, finally got to fixing prettier + lint issues.
@TkDodoTkDodo
mentioned this pull request
Mar 14, 2023
 Closed

9 tasks
TkDodoand others
added 25 commits
March 15, 2023 09:07
@TkDodo
chore: releases should run on alpha/beta as well
bef1f52
@TkDodo
chore: extract package validation to an extra script (TanStack#5039)
7d3e61d
* chore: extract package validation to an extra script
and run it during CI
* chore: add missing `build:types` script to solid-query
@cseas@TkDodo
docs: update link for v2 docs (TanStack#5044)
30ba660
* docs: update link for v2 docs
* Update README.md
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.12
590dba2
@janinegygax@TkDodo
fix(react-query-devtools): do not stretch query status label (TanStac…
f38b567
…k#5063)
Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view.
@tannerlinsley@TkDodo
release: v4.24.13
82a6377
@yousoumar@TkDodo
fix(react-query-devtools): add 'use client' directive to disable SSR (T…
8db407f
…anStack#5041)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.14
9561549
@remolueoend@TkDodo
feat(core): re-export matchQuery from utils (TanStack#5070)
5abe521
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.25.0
a2c0c05
@TkDodo
feat(query-core): Add global onSettled callbacks for QueryCache and M…
f57e25c
…utationCache (TanStack#5075)
* feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache
* test: tests for query onSettled callback
* test: tests for mutation onSettled callback
* docs: onSettled callbacks
@tannerlinsley@TkDodo
release: v4.26.0
761e312
@TkDodo
fix(core): make sure mutations get updated options (TanStack#5085)
93ecbc8
this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure
@tannerlinsley@TkDodo
release: v4.26.1
fca67f6
@Newbie012@TkDodo
fix(eslint-plugin): improve object property checks (TanStack#5079)
7a8654f
* fix(eslint-plugin): improve object property checks
* prettier
@tannerlinsley@TkDodo
release: v4.26.2
1be904a
@DamianOsipiuk@TkDodo
docs: add adapter dropdown to issue template (TanStack#5108)
c28f64c
@leon-fong@TkDodo
docs(queries): renamesuccess(TanStack#5110)
9ac386b
@ZackDeRose@TkDodo
chore:test:libtask-caching w/ Nx (TanStack#5116)
c372c2e
* adding quick caching test
* reverting workflow change
* updating pr yml to test nx speed
* fixing yml on property
* fixing yml on property
* fixing target name
* upping to running4 in parallel
* upping to running 5 in parallel
* upping to running 6 in parallel
* upping to running 7 in parallel
* upping to running 8 in parallel
* upping to running 9 in parallel
* upping to running 10 in parallel
* opting for --parallel=5
* cleaning up nx.json
* revert touching of ci.yml file
* reverting on property of pr.yml file
* updating root pacakge.json test:lib command
* fixing frozen lockfile error in ci
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@TkDodo
chore: fix missing dependencies (TanStack#5127)
dae70a8
* chore: include scripts directory in linting
and fix issues
* chore: add missing dependencies chalk and semver
@ZackDeRose@TkDodo
chore: turning off Nx daemon in CI (TanStack#5128)
7d9878f
@TkDodo
chore: downgrade chalk to v4 because v5 is ESM only (TanStack#5130)
e9c61f1
see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module
@Newbie012@TkDodo
fix(eslint-plugin): ignore internal properties (TanStack#5119)
9f043a0
@TkDodo
chore: resolve merge conflicts
3ad2ba3
@TkDodo
Merge branch 'main' into error--and-loading-devtools
a4ff17e
@TkDodo
TkDodo
merged commit b7089d1
into
TanStack:mainMar 15, 2023
@paul-sachs
paul-sachs
commented
Mar 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@TkDodo My apologies for letting this drop off. I'll submit a follow on PR with the suggested changes. Thanks so much for merging this, it'll make modifying loading states so much easier!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

12 participants

@paul-sachs@codecov-commenter@TkDodo@cseas@tannerlinsley@janinegygax@yousoumar@remolueoend@Newbie012@DamianOsipiuk@leon-fong@ZackDeRose

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(devtools): enable setting loading/error via devtools - #4352
Merged
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Mar 15, 2023
Merged
feat(devtools): enable setting loading/error via devtools#4352
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Conversation
@paul-sachs
@paul-sachspaul-sachs
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Allows the devtools to toggle loading and errors states (at least until the next fetch is triggered).
Things to do:
  •  Make sure onError get's triggered
Screen.Recording.2022-10-21.at.10.41.06.AM.mov
@codesandbox-ci
codesandbox-ciBot
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a4ff17e:
SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration
@TkDodo
TkDodo
marked this pull request as ready for review
January 23, 2023 12:10
@codecov-commenter
codecov-commenter
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.84% // Head: 92.16% // Increases project coverage by +0.31% 🎉
Coverage data is based on head (356e26e) compared to base (48e806b).

Patch coverage: 97.56% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #4352 +/- ##
==========================================
+ Coverage 91.84% 92.16% +0.31% 
==========================================
Files 111 111 Lines 4146 4187 +41 Branches 1072 1087 +15 ==========================================
+ Hits 3808 3859 +51 + Misses 317 307 -10 
Partials 21 21 
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts92.85% <ø> (ø)
packages/react-query-devtools/src/devtools.tsx89.09% <97.56%> (+5.16%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
@paul-sachs thanks for this PR, and sorry that it went unnoticed for a while. I've fixed some issues and did a bit of refactoring.
What would be missing from my perspective would be:
  • some tests of the new behaviour
  • a way to make the loading state revert back when clicking the button a second time, and maybe some visual feedback that we are now in loading state (similar to what the offline toggle button does)
would you like to continue contributing this?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Hi @TkDodo I'll take a look for sure. I'll need to familiarize myself with the testing setup but that should be fine. Storing the previous state is a little tricky if I remember correctly. I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
That's fine - I like the resetQueries approach that you've already taken for the error state. But the only way to get out of the loading state right now is to click refetch, and I think it would be good if the button behaved like a toggle. Alternatively, we could keep the last state in a ref before overwriting it and then restore it maybe?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
I'd worry what would happen if something toggles loading state during loading. I'm not sure how setState works internally, don't know if it will abort the on going promise. Feels a little like reset is our safest bet. Either way really, the toggle behaviour makes sense.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So I've fixed the toggle state, however this approach doesn't seem to work in suspense mode since the setState doesn't trigger a promise... This will need something else to work through that issue.
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Was hoping to do something like:
activeQuery.fetch({queryFn: ()=>newPromise((resolve,reject)=>{}),cacheTime: -1,})
But i don't think that's replacing the queryFn like I thought it would. It triggers a refetch of the existing queryFn...
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Ah no, i was incorrect. It is using the updated queryFn. At least, I think it is. The problem is trying to store the previous queryFn so I can restore it...
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Alright, managed to get suspense working. Had to store some query state inside queryMeta so not sure I feel great about that, but it does keep query state all together. Maybe there's a better place to store it?
Next, I'll take a look at the testing infrastructure to figure out how to write some tests.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@TkDodo Tests are up and green. I've represented the current state of the query in the buttons themselves but let me know if you want a totally different direction.
@vercel
vercelBot
commented
Jan 26, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 15, 2023 at 8:09AM (UTC)
@paul-sachs
paul-sachs
commented
Feb 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Alright, finally got to fixing prettier + lint issues.
@TkDodoTkDodo
mentioned this pull request
Mar 14, 2023
 Closed

9 tasks
TkDodoand others
added 25 commits
March 15, 2023 09:07
@TkDodo
chore: releases should run on alpha/beta as well
bef1f52
@TkDodo
chore: extract package validation to an extra script (TanStack#5039)
7d3e61d
* chore: extract package validation to an extra script
and run it during CI
* chore: add missing `build:types` script to solid-query
@cseas@TkDodo
docs: update link for v2 docs (TanStack#5044)
30ba660
* docs: update link for v2 docs
* Update README.md
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.12
590dba2
@janinegygax@TkDodo
fix(react-query-devtools): do not stretch query status label (TanStac…
f38b567
…k#5063)
Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view.
@tannerlinsley@TkDodo
release: v4.24.13
82a6377
@yousoumar@TkDodo
fix(react-query-devtools): add 'use client' directive to disable SSR (T…
8db407f
…anStack#5041)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.14
9561549
@remolueoend@TkDodo
feat(core): re-export matchQuery from utils (TanStack#5070)
5abe521
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.25.0
a2c0c05
@TkDodo
feat(query-core): Add global onSettled callbacks for QueryCache and M…
f57e25c
…utationCache (TanStack#5075)
* feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache
* test: tests for query onSettled callback
* test: tests for mutation onSettled callback
* docs: onSettled callbacks
@tannerlinsley@TkDodo
release: v4.26.0
761e312
@TkDodo
fix(core): make sure mutations get updated options (TanStack#5085)
93ecbc8
this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure
@tannerlinsley@TkDodo
release: v4.26.1
fca67f6
@Newbie012@TkDodo
fix(eslint-plugin): improve object property checks (TanStack#5079)
7a8654f
* fix(eslint-plugin): improve object property checks
* prettier
@tannerlinsley@TkDodo
release: v4.26.2
1be904a
@DamianOsipiuk@TkDodo
docs: add adapter dropdown to issue template (TanStack#5108)
c28f64c
@leon-fong@TkDodo
docs(queries): renamesuccess(TanStack#5110)
9ac386b
@ZackDeRose@TkDodo
chore:test:libtask-caching w/ Nx (TanStack#5116)
c372c2e
* adding quick caching test
* reverting workflow change
* updating pr yml to test nx speed
* fixing yml on property
* fixing yml on property
* fixing target name
* upping to running4 in parallel
* upping to running 5 in parallel
* upping to running 6 in parallel
* upping to running 7 in parallel
* upping to running 8 in parallel
* upping to running 9 in parallel
* upping to running 10 in parallel
* opting for --parallel=5
* cleaning up nx.json
* revert touching of ci.yml file
* reverting on property of pr.yml file
* updating root pacakge.json test:lib command
* fixing frozen lockfile error in ci
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@TkDodo
chore: fix missing dependencies (TanStack#5127)
dae70a8
* chore: include scripts directory in linting
and fix issues
* chore: add missing dependencies chalk and semver
@ZackDeRose@TkDodo
chore: turning off Nx daemon in CI (TanStack#5128)
7d9878f
@TkDodo
chore: downgrade chalk to v4 because v5 is ESM only (TanStack#5130)
e9c61f1
see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module
@Newbie012@TkDodo
fix(eslint-plugin): ignore internal properties (TanStack#5119)
9f043a0
@TkDodo
chore: resolve merge conflicts
3ad2ba3
@TkDodo
Merge branch 'main' into error--and-loading-devtools
a4ff17e
@TkDodo
TkDodo
merged commit b7089d1
into
TanStack:mainMar 15, 2023
@paul-sachs
paul-sachs
commented
Mar 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@TkDodo My apologies for letting this drop off. I'll submit a follow on PR with the suggested changes. Thanks so much for merging this, it'll make modifying loading states so much easier!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

12 participants

@paul-sachs@codecov-commenter@TkDodo@cseas@tannerlinsley@janinegygax@yousoumar@remolueoend@Newbie012@DamianOsipiuk@leon-fong@ZackDeRose

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(devtools): enable setting loading/error via devtools - #4352
Merged
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Mar 15, 2023
Merged
feat(devtools): enable setting loading/error via devtools#4352
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Conversation
@paul-sachs
@paul-sachspaul-sachs
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Allows the devtools to toggle loading and errors states (at least until the next fetch is triggered).
Things to do:
  •  Make sure onError get's triggered
Screen.Recording.2022-10-21.at.10.41.06.AM.mov
@codesandbox-ci
codesandbox-ciBot
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a4ff17e:
SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration
@TkDodo
TkDodo
marked this pull request as ready for review
January 23, 2023 12:10
@codecov-commenter
codecov-commenter
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.84% // Head: 92.16% // Increases project coverage by +0.31% 🎉
Coverage data is based on head (356e26e) compared to base (48e806b).

Patch coverage: 97.56% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #4352 +/- ##
==========================================
+ Coverage 91.84% 92.16% +0.31% 
==========================================
Files 111 111 Lines 4146 4187 +41 Branches 1072 1087 +15 ==========================================
+ Hits 3808 3859 +51 + Misses 317 307 -10 
Partials 21 21 
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts92.85% <ø> (ø)
packages/react-query-devtools/src/devtools.tsx89.09% <97.56%> (+5.16%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
@paul-sachs thanks for this PR, and sorry that it went unnoticed for a while. I've fixed some issues and did a bit of refactoring.
What would be missing from my perspective would be:
  • some tests of the new behaviour
  • a way to make the loading state revert back when clicking the button a second time, and maybe some visual feedback that we are now in loading state (similar to what the offline toggle button does)
would you like to continue contributing this?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Hi @TkDodo I'll take a look for sure. I'll need to familiarize myself with the testing setup but that should be fine. Storing the previous state is a little tricky if I remember correctly. I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
That's fine - I like the resetQueries approach that you've already taken for the error state. But the only way to get out of the loading state right now is to click refetch, and I think it would be good if the button behaved like a toggle. Alternatively, we could keep the last state in a ref before overwriting it and then restore it maybe?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
I'd worry what would happen if something toggles loading state during loading. I'm not sure how setState works internally, don't know if it will abort the on going promise. Feels a little like reset is our safest bet. Either way really, the toggle behaviour makes sense.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So I've fixed the toggle state, however this approach doesn't seem to work in suspense mode since the setState doesn't trigger a promise... This will need something else to work through that issue.
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Was hoping to do something like:
activeQuery.fetch({queryFn: ()=>newPromise((resolve,reject)=>{}),cacheTime: -1,})
But i don't think that's replacing the queryFn like I thought it would. It triggers a refetch of the existing queryFn...
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Ah no, i was incorrect. It is using the updated queryFn. At least, I think it is. The problem is trying to store the previous queryFn so I can restore it...
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Alright, managed to get suspense working. Had to store some query state inside queryMeta so not sure I feel great about that, but it does keep query state all together. Maybe there's a better place to store it?
Next, I'll take a look at the testing infrastructure to figure out how to write some tests.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@TkDodo Tests are up and green. I've represented the current state of the query in the buttons themselves but let me know if you want a totally different direction.
@vercel
vercelBot
commented
Jan 26, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 15, 2023 at 8:09AM (UTC)
@paul-sachs
paul-sachs
commented
Feb 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Alright, finally got to fixing prettier + lint issues.
@TkDodoTkDodo
mentioned this pull request
Mar 14, 2023
 Closed

9 tasks
TkDodoand others
added 25 commits
March 15, 2023 09:07
@TkDodo
chore: releases should run on alpha/beta as well
bef1f52
@TkDodo
chore: extract package validation to an extra script (TanStack#5039)
7d3e61d
* chore: extract package validation to an extra script
and run it during CI
* chore: add missing `build:types` script to solid-query
@cseas@TkDodo
docs: update link for v2 docs (TanStack#5044)
30ba660
* docs: update link for v2 docs
* Update README.md
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.12
590dba2
@janinegygax@TkDodo
fix(react-query-devtools): do not stretch query status label (TanStac…
f38b567
…k#5063)
Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view.
@tannerlinsley@TkDodo
release: v4.24.13
82a6377
@yousoumar@TkDodo
fix(react-query-devtools): add 'use client' directive to disable SSR (T…
8db407f
…anStack#5041)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.14
9561549
@remolueoend@TkDodo
feat(core): re-export matchQuery from utils (TanStack#5070)
5abe521
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.25.0
a2c0c05
@TkDodo
feat(query-core): Add global onSettled callbacks for QueryCache and M…
f57e25c
…utationCache (TanStack#5075)
* feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache
* test: tests for query onSettled callback
* test: tests for mutation onSettled callback
* docs: onSettled callbacks
@tannerlinsley@TkDodo
release: v4.26.0
761e312
@TkDodo
fix(core): make sure mutations get updated options (TanStack#5085)
93ecbc8
this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure
@tannerlinsley@TkDodo
release: v4.26.1
fca67f6
@Newbie012@TkDodo
fix(eslint-plugin): improve object property checks (TanStack#5079)
7a8654f
* fix(eslint-plugin): improve object property checks
* prettier
@tannerlinsley@TkDodo
release: v4.26.2
1be904a
@DamianOsipiuk@TkDodo
docs: add adapter dropdown to issue template (TanStack#5108)
c28f64c
@leon-fong@TkDodo
docs(queries): renamesuccess(TanStack#5110)
9ac386b
@ZackDeRose@TkDodo
chore:test:libtask-caching w/ Nx (TanStack#5116)
c372c2e
* adding quick caching test
* reverting workflow change
* updating pr yml to test nx speed
* fixing yml on property
* fixing yml on property
* fixing target name
* upping to running4 in parallel
* upping to running 5 in parallel
* upping to running 6 in parallel
* upping to running 7 in parallel
* upping to running 8 in parallel
* upping to running 9 in parallel
* upping to running 10 in parallel
* opting for --parallel=5
* cleaning up nx.json
* revert touching of ci.yml file
* reverting on property of pr.yml file
* updating root pacakge.json test:lib command
* fixing frozen lockfile error in ci
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@TkDodo
chore: fix missing dependencies (TanStack#5127)
dae70a8
* chore: include scripts directory in linting
and fix issues
* chore: add missing dependencies chalk and semver
@ZackDeRose@TkDodo
chore: turning off Nx daemon in CI (TanStack#5128)
7d9878f
@TkDodo
chore: downgrade chalk to v4 because v5 is ESM only (TanStack#5130)
e9c61f1
see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module
@Newbie012@TkDodo
fix(eslint-plugin): ignore internal properties (TanStack#5119)
9f043a0
@TkDodo
chore: resolve merge conflicts
3ad2ba3
@TkDodo
Merge branch 'main' into error--and-loading-devtools
a4ff17e
@TkDodo
TkDodo
merged commit b7089d1
into
TanStack:mainMar 15, 2023
@paul-sachs
paul-sachs
commented
Mar 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@TkDodo My apologies for letting this drop off. I'll submit a follow on PR with the suggested changes. Thanks so much for merging this, it'll make modifying loading states so much easier!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

12 participants

@paul-sachs@codecov-commenter@TkDodo@cseas@tannerlinsley@janinegygax@yousoumar@remolueoend@Newbie012@DamianOsipiuk@leon-fong@ZackDeRose

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(devtools): enable setting loading/error via devtools - #4352
Merged
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Mar 15, 2023
Merged
feat(devtools): enable setting loading/error via devtools#4352
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Conversation
@paul-sachs
@paul-sachspaul-sachs
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Allows the devtools to toggle loading and errors states (at least until the next fetch is triggered).
Things to do:
  •  Make sure onError get's triggered
Screen.Recording.2022-10-21.at.10.41.06.AM.mov
@codesandbox-ci
codesandbox-ciBot
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a4ff17e:
SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration
@TkDodo
TkDodo
marked this pull request as ready for review
January 23, 2023 12:10
@codecov-commenter
codecov-commenter
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.84% // Head: 92.16% // Increases project coverage by +0.31% 🎉
Coverage data is based on head (356e26e) compared to base (48e806b).

Patch coverage: 97.56% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #4352 +/- ##
==========================================
+ Coverage 91.84% 92.16% +0.31% 
==========================================
Files 111 111 Lines 4146 4187 +41 Branches 1072 1087 +15 ==========================================
+ Hits 3808 3859 +51 + Misses 317 307 -10 
Partials 21 21 
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts92.85% <ø> (ø)
packages/react-query-devtools/src/devtools.tsx89.09% <97.56%> (+5.16%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
@paul-sachs thanks for this PR, and sorry that it went unnoticed for a while. I've fixed some issues and did a bit of refactoring.
What would be missing from my perspective would be:
  • some tests of the new behaviour
  • a way to make the loading state revert back when clicking the button a second time, and maybe some visual feedback that we are now in loading state (similar to what the offline toggle button does)
would you like to continue contributing this?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Hi @TkDodo I'll take a look for sure. I'll need to familiarize myself with the testing setup but that should be fine. Storing the previous state is a little tricky if I remember correctly. I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
That's fine - I like the resetQueries approach that you've already taken for the error state. But the only way to get out of the loading state right now is to click refetch, and I think it would be good if the button behaved like a toggle. Alternatively, we could keep the last state in a ref before overwriting it and then restore it maybe?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
I'd worry what would happen if something toggles loading state during loading. I'm not sure how setState works internally, don't know if it will abort the on going promise. Feels a little like reset is our safest bet. Either way really, the toggle behaviour makes sense.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So I've fixed the toggle state, however this approach doesn't seem to work in suspense mode since the setState doesn't trigger a promise... This will need something else to work through that issue.
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Was hoping to do something like:
activeQuery.fetch({queryFn: ()=>newPromise((resolve,reject)=>{}),cacheTime: -1,})
But i don't think that's replacing the queryFn like I thought it would. It triggers a refetch of the existing queryFn...
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Ah no, i was incorrect. It is using the updated queryFn. At least, I think it is. The problem is trying to store the previous queryFn so I can restore it...
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Alright, managed to get suspense working. Had to store some query state inside queryMeta so not sure I feel great about that, but it does keep query state all together. Maybe there's a better place to store it?
Next, I'll take a look at the testing infrastructure to figure out how to write some tests.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@TkDodo Tests are up and green. I've represented the current state of the query in the buttons themselves but let me know if you want a totally different direction.
@vercel
vercelBot
commented
Jan 26, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 15, 2023 at 8:09AM (UTC)
@paul-sachs
paul-sachs
commented
Feb 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Alright, finally got to fixing prettier + lint issues.
@TkDodoTkDodo
mentioned this pull request
Mar 14, 2023
 Closed

9 tasks
TkDodoand others
added 25 commits
March 15, 2023 09:07
@TkDodo
chore: releases should run on alpha/beta as well
bef1f52
@TkDodo
chore: extract package validation to an extra script (TanStack#5039)
7d3e61d
* chore: extract package validation to an extra script
and run it during CI
* chore: add missing `build:types` script to solid-query
@cseas@TkDodo
docs: update link for v2 docs (TanStack#5044)
30ba660
* docs: update link for v2 docs
* Update README.md
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.12
590dba2
@janinegygax@TkDodo
fix(react-query-devtools): do not stretch query status label (TanStac…
f38b567
…k#5063)
Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view.
@tannerlinsley@TkDodo
release: v4.24.13
82a6377
@yousoumar@TkDodo
fix(react-query-devtools): add 'use client' directive to disable SSR (T…
8db407f
…anStack#5041)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.14
9561549
@remolueoend@TkDodo
feat(core): re-export matchQuery from utils (TanStack#5070)
5abe521
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.25.0
a2c0c05
@TkDodo
feat(query-core): Add global onSettled callbacks for QueryCache and M…
f57e25c
…utationCache (TanStack#5075)
* feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache
* test: tests for query onSettled callback
* test: tests for mutation onSettled callback
* docs: onSettled callbacks
@tannerlinsley@TkDodo
release: v4.26.0
761e312
@TkDodo
fix(core): make sure mutations get updated options (TanStack#5085)
93ecbc8
this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure
@tannerlinsley@TkDodo
release: v4.26.1
fca67f6
@Newbie012@TkDodo
fix(eslint-plugin): improve object property checks (TanStack#5079)
7a8654f
* fix(eslint-plugin): improve object property checks
* prettier
@tannerlinsley@TkDodo
release: v4.26.2
1be904a
@DamianOsipiuk@TkDodo
docs: add adapter dropdown to issue template (TanStack#5108)
c28f64c
@leon-fong@TkDodo
docs(queries): renamesuccess(TanStack#5110)
9ac386b
@ZackDeRose@TkDodo
chore:test:libtask-caching w/ Nx (TanStack#5116)
c372c2e
* adding quick caching test
* reverting workflow change
* updating pr yml to test nx speed
* fixing yml on property
* fixing yml on property
* fixing target name
* upping to running4 in parallel
* upping to running 5 in parallel
* upping to running 6 in parallel
* upping to running 7 in parallel
* upping to running 8 in parallel
* upping to running 9 in parallel
* upping to running 10 in parallel
* opting for --parallel=5
* cleaning up nx.json
* revert touching of ci.yml file
* reverting on property of pr.yml file
* updating root pacakge.json test:lib command
* fixing frozen lockfile error in ci
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@TkDodo
chore: fix missing dependencies (TanStack#5127)
dae70a8
* chore: include scripts directory in linting
and fix issues
* chore: add missing dependencies chalk and semver
@ZackDeRose@TkDodo
chore: turning off Nx daemon in CI (TanStack#5128)
7d9878f
@TkDodo
chore: downgrade chalk to v4 because v5 is ESM only (TanStack#5130)
e9c61f1
see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module
@Newbie012@TkDodo
fix(eslint-plugin): ignore internal properties (TanStack#5119)
9f043a0
@TkDodo
chore: resolve merge conflicts
3ad2ba3
@TkDodo
Merge branch 'main' into error--and-loading-devtools
a4ff17e
@TkDodo
TkDodo
merged commit b7089d1
into
TanStack:mainMar 15, 2023
@paul-sachs
paul-sachs
commented
Mar 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@TkDodo My apologies for letting this drop off. I'll submit a follow on PR with the suggested changes. Thanks so much for merging this, it'll make modifying loading states so much easier!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

12 participants

@paul-sachs@codecov-commenter@TkDodo@cseas@tannerlinsley@janinegygax@yousoumar@remolueoend@Newbie012@DamianOsipiuk@leon-fong@ZackDeRose

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(devtools): enable setting loading/error via devtools - #4352
Merged
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Mar 15, 2023
Merged
feat(devtools): enable setting loading/error via devtools#4352
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Conversation
@paul-sachs
@paul-sachspaul-sachs
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Allows the devtools to toggle loading and errors states (at least until the next fetch is triggered).
Things to do:
  •  Make sure onError get's triggered
Screen.Recording.2022-10-21.at.10.41.06.AM.mov
@codesandbox-ci
codesandbox-ciBot
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a4ff17e:
SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration
@TkDodo
TkDodo
marked this pull request as ready for review
January 23, 2023 12:10
@codecov-commenter
codecov-commenter
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.84% // Head: 92.16% // Increases project coverage by +0.31% 🎉
Coverage data is based on head (356e26e) compared to base (48e806b).

Patch coverage: 97.56% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #4352 +/- ##
==========================================
+ Coverage 91.84% 92.16% +0.31% 
==========================================
Files 111 111 Lines 4146 4187 +41 Branches 1072 1087 +15 ==========================================
+ Hits 3808 3859 +51 + Misses 317 307 -10 
Partials 21 21 
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts92.85% <ø> (ø)
packages/react-query-devtools/src/devtools.tsx89.09% <97.56%> (+5.16%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
@paul-sachs thanks for this PR, and sorry that it went unnoticed for a while. I've fixed some issues and did a bit of refactoring.
What would be missing from my perspective would be:
  • some tests of the new behaviour
  • a way to make the loading state revert back when clicking the button a second time, and maybe some visual feedback that we are now in loading state (similar to what the offline toggle button does)
would you like to continue contributing this?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Hi @TkDodo I'll take a look for sure. I'll need to familiarize myself with the testing setup but that should be fine. Storing the previous state is a little tricky if I remember correctly. I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
That's fine - I like the resetQueries approach that you've already taken for the error state. But the only way to get out of the loading state right now is to click refetch, and I think it would be good if the button behaved like a toggle. Alternatively, we could keep the last state in a ref before overwriting it and then restore it maybe?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
I'd worry what would happen if something toggles loading state during loading. I'm not sure how setState works internally, don't know if it will abort the on going promise. Feels a little like reset is our safest bet. Either way really, the toggle behaviour makes sense.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So I've fixed the toggle state, however this approach doesn't seem to work in suspense mode since the setState doesn't trigger a promise... This will need something else to work through that issue.
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Was hoping to do something like:
activeQuery.fetch({queryFn: ()=>newPromise((resolve,reject)=>{}),cacheTime: -1,})
But i don't think that's replacing the queryFn like I thought it would. It triggers a refetch of the existing queryFn...
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Ah no, i was incorrect. It is using the updated queryFn. At least, I think it is. The problem is trying to store the previous queryFn so I can restore it...
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Alright, managed to get suspense working. Had to store some query state inside queryMeta so not sure I feel great about that, but it does keep query state all together. Maybe there's a better place to store it?
Next, I'll take a look at the testing infrastructure to figure out how to write some tests.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@TkDodo Tests are up and green. I've represented the current state of the query in the buttons themselves but let me know if you want a totally different direction.
@vercel
vercelBot
commented
Jan 26, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 15, 2023 at 8:09AM (UTC)
@paul-sachs
paul-sachs
commented
Feb 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Alright, finally got to fixing prettier + lint issues.
@TkDodoTkDodo
mentioned this pull request
Mar 14, 2023
 Closed

9 tasks
TkDodoand others
added 25 commits
March 15, 2023 09:07
@TkDodo
chore: releases should run on alpha/beta as well
bef1f52
@TkDodo
chore: extract package validation to an extra script (TanStack#5039)
7d3e61d
* chore: extract package validation to an extra script
and run it during CI
* chore: add missing `build:types` script to solid-query
@cseas@TkDodo
docs: update link for v2 docs (TanStack#5044)
30ba660
* docs: update link for v2 docs
* Update README.md
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.12
590dba2
@janinegygax@TkDodo
fix(react-query-devtools): do not stretch query status label (TanStac…
f38b567
…k#5063)
Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view.
@tannerlinsley@TkDodo
release: v4.24.13
82a6377
@yousoumar@TkDodo
fix(react-query-devtools): add 'use client' directive to disable SSR (T…
8db407f
…anStack#5041)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.14
9561549
@remolueoend@TkDodo
feat(core): re-export matchQuery from utils (TanStack#5070)
5abe521
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.25.0
a2c0c05
@TkDodo
feat(query-core): Add global onSettled callbacks for QueryCache and M…
f57e25c
…utationCache (TanStack#5075)
* feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache
* test: tests for query onSettled callback
* test: tests for mutation onSettled callback
* docs: onSettled callbacks
@tannerlinsley@TkDodo
release: v4.26.0
761e312
@TkDodo
fix(core): make sure mutations get updated options (TanStack#5085)
93ecbc8
this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure
@tannerlinsley@TkDodo
release: v4.26.1
fca67f6
@Newbie012@TkDodo
fix(eslint-plugin): improve object property checks (TanStack#5079)
7a8654f
* fix(eslint-plugin): improve object property checks
* prettier
@tannerlinsley@TkDodo
release: v4.26.2
1be904a
@DamianOsipiuk@TkDodo
docs: add adapter dropdown to issue template (TanStack#5108)
c28f64c
@leon-fong@TkDodo
docs(queries): renamesuccess(TanStack#5110)
9ac386b
@ZackDeRose@TkDodo
chore:test:libtask-caching w/ Nx (TanStack#5116)
c372c2e
* adding quick caching test
* reverting workflow change
* updating pr yml to test nx speed
* fixing yml on property
* fixing yml on property
* fixing target name
* upping to running4 in parallel
* upping to running 5 in parallel
* upping to running 6 in parallel
* upping to running 7 in parallel
* upping to running 8 in parallel
* upping to running 9 in parallel
* upping to running 10 in parallel
* opting for --parallel=5
* cleaning up nx.json
* revert touching of ci.yml file
* reverting on property of pr.yml file
* updating root pacakge.json test:lib command
* fixing frozen lockfile error in ci
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@TkDodo
chore: fix missing dependencies (TanStack#5127)
dae70a8
* chore: include scripts directory in linting
and fix issues
* chore: add missing dependencies chalk and semver
@ZackDeRose@TkDodo
chore: turning off Nx daemon in CI (TanStack#5128)
7d9878f
@TkDodo
chore: downgrade chalk to v4 because v5 is ESM only (TanStack#5130)
e9c61f1
see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module
@Newbie012@TkDodo
fix(eslint-plugin): ignore internal properties (TanStack#5119)
9f043a0
@TkDodo
chore: resolve merge conflicts
3ad2ba3
@TkDodo
Merge branch 'main' into error--and-loading-devtools
a4ff17e
@TkDodo
TkDodo
merged commit b7089d1
into
TanStack:mainMar 15, 2023
@paul-sachs
paul-sachs
commented
Mar 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@TkDodo My apologies for letting this drop off. I'll submit a follow on PR with the suggested changes. Thanks so much for merging this, it'll make modifying loading states so much easier!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

12 participants

@paul-sachs@codecov-commenter@TkDodo@cseas@tannerlinsley@janinegygax@yousoumar@remolueoend@Newbie012@DamianOsipiuk@leon-fong@ZackDeRose

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(devtools): enable setting loading/error via devtools - #4352
Merged
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Mar 15, 2023
Merged
feat(devtools): enable setting loading/error via devtools#4352
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Conversation
@paul-sachs
@paul-sachspaul-sachs
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Allows the devtools to toggle loading and errors states (at least until the next fetch is triggered).
Things to do:
  •  Make sure onError get's triggered
Screen.Recording.2022-10-21.at.10.41.06.AM.mov
@codesandbox-ci
codesandbox-ciBot
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a4ff17e:
SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration
@TkDodo
TkDodo
marked this pull request as ready for review
January 23, 2023 12:10
@codecov-commenter
codecov-commenter
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.84% // Head: 92.16% // Increases project coverage by +0.31% 🎉
Coverage data is based on head (356e26e) compared to base (48e806b).

Patch coverage: 97.56% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #4352 +/- ##
==========================================
+ Coverage 91.84% 92.16% +0.31% 
==========================================
Files 111 111 Lines 4146 4187 +41 Branches 1072 1087 +15 ==========================================
+ Hits 3808 3859 +51 + Misses 317 307 -10 
Partials 21 21 
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts92.85% <ø> (ø)
packages/react-query-devtools/src/devtools.tsx89.09% <97.56%> (+5.16%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
@paul-sachs thanks for this PR, and sorry that it went unnoticed for a while. I've fixed some issues and did a bit of refactoring.
What would be missing from my perspective would be:
  • some tests of the new behaviour
  • a way to make the loading state revert back when clicking the button a second time, and maybe some visual feedback that we are now in loading state (similar to what the offline toggle button does)
would you like to continue contributing this?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Hi @TkDodo I'll take a look for sure. I'll need to familiarize myself with the testing setup but that should be fine. Storing the previous state is a little tricky if I remember correctly. I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
That's fine - I like the resetQueries approach that you've already taken for the error state. But the only way to get out of the loading state right now is to click refetch, and I think it would be good if the button behaved like a toggle. Alternatively, we could keep the last state in a ref before overwriting it and then restore it maybe?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
I'd worry what would happen if something toggles loading state during loading. I'm not sure how setState works internally, don't know if it will abort the on going promise. Feels a little like reset is our safest bet. Either way really, the toggle behaviour makes sense.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So I've fixed the toggle state, however this approach doesn't seem to work in suspense mode since the setState doesn't trigger a promise... This will need something else to work through that issue.
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Was hoping to do something like:
activeQuery.fetch({queryFn: ()=>newPromise((resolve,reject)=>{}),cacheTime: -1,})
But i don't think that's replacing the queryFn like I thought it would. It triggers a refetch of the existing queryFn...
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Ah no, i was incorrect. It is using the updated queryFn. At least, I think it is. The problem is trying to store the previous queryFn so I can restore it...
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Alright, managed to get suspense working. Had to store some query state inside queryMeta so not sure I feel great about that, but it does keep query state all together. Maybe there's a better place to store it?
Next, I'll take a look at the testing infrastructure to figure out how to write some tests.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@TkDodo Tests are up and green. I've represented the current state of the query in the buttons themselves but let me know if you want a totally different direction.
@vercel
vercelBot
commented
Jan 26, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 15, 2023 at 8:09AM (UTC)
@paul-sachs
paul-sachs
commented
Feb 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Alright, finally got to fixing prettier + lint issues.
@TkDodoTkDodo
mentioned this pull request
Mar 14, 2023
 Closed

9 tasks
TkDodoand others
added 25 commits
March 15, 2023 09:07
@TkDodo
chore: releases should run on alpha/beta as well
bef1f52
@TkDodo
chore: extract package validation to an extra script (TanStack#5039)
7d3e61d
* chore: extract package validation to an extra script
and run it during CI
* chore: add missing `build:types` script to solid-query
@cseas@TkDodo
docs: update link for v2 docs (TanStack#5044)
30ba660
* docs: update link for v2 docs
* Update README.md
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.12
590dba2
@janinegygax@TkDodo
fix(react-query-devtools): do not stretch query status label (TanStac…
f38b567
…k#5063)
Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view.
@tannerlinsley@TkDodo
release: v4.24.13
82a6377
@yousoumar@TkDodo
fix(react-query-devtools): add 'use client' directive to disable SSR (T…
8db407f
…anStack#5041)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.14
9561549
@remolueoend@TkDodo
feat(core): re-export matchQuery from utils (TanStack#5070)
5abe521
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.25.0
a2c0c05
@TkDodo
feat(query-core): Add global onSettled callbacks for QueryCache and M…
f57e25c
…utationCache (TanStack#5075)
* feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache
* test: tests for query onSettled callback
* test: tests for mutation onSettled callback
* docs: onSettled callbacks
@tannerlinsley@TkDodo
release: v4.26.0
761e312
@TkDodo
fix(core): make sure mutations get updated options (TanStack#5085)
93ecbc8
this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure
@tannerlinsley@TkDodo
release: v4.26.1
fca67f6
@Newbie012@TkDodo
fix(eslint-plugin): improve object property checks (TanStack#5079)
7a8654f
* fix(eslint-plugin): improve object property checks
* prettier
@tannerlinsley@TkDodo
release: v4.26.2
1be904a
@DamianOsipiuk@TkDodo
docs: add adapter dropdown to issue template (TanStack#5108)
c28f64c
@leon-fong@TkDodo
docs(queries): renamesuccess(TanStack#5110)
9ac386b
@ZackDeRose@TkDodo
chore:test:libtask-caching w/ Nx (TanStack#5116)
c372c2e
* adding quick caching test
* reverting workflow change
* updating pr yml to test nx speed
* fixing yml on property
* fixing yml on property
* fixing target name
* upping to running4 in parallel
* upping to running 5 in parallel
* upping to running 6 in parallel
* upping to running 7 in parallel
* upping to running 8 in parallel
* upping to running 9 in parallel
* upping to running 10 in parallel
* opting for --parallel=5
* cleaning up nx.json
* revert touching of ci.yml file
* reverting on property of pr.yml file
* updating root pacakge.json test:lib command
* fixing frozen lockfile error in ci
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@TkDodo
chore: fix missing dependencies (TanStack#5127)
dae70a8
* chore: include scripts directory in linting
and fix issues
* chore: add missing dependencies chalk and semver
@ZackDeRose@TkDodo
chore: turning off Nx daemon in CI (TanStack#5128)
7d9878f
@TkDodo
chore: downgrade chalk to v4 because v5 is ESM only (TanStack#5130)
e9c61f1
see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module
@Newbie012@TkDodo
fix(eslint-plugin): ignore internal properties (TanStack#5119)
9f043a0
@TkDodo
chore: resolve merge conflicts
3ad2ba3
@TkDodo
Merge branch 'main' into error--and-loading-devtools
a4ff17e
@TkDodo
TkDodo
merged commit b7089d1
into
TanStack:mainMar 15, 2023
@paul-sachs
paul-sachs
commented
Mar 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@TkDodo My apologies for letting this drop off. I'll submit a follow on PR with the suggested changes. Thanks so much for merging this, it'll make modifying loading states so much easier!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

12 participants

@paul-sachs@codecov-commenter@TkDodo@cseas@tannerlinsley@janinegygax@yousoumar@remolueoend@Newbie012@DamianOsipiuk@leon-fong@ZackDeRose

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(devtools): enable setting loading/error via devtools - #4352
Merged
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Mar 15, 2023
Merged
feat(devtools): enable setting loading/error via devtools#4352
TkDodo merged 41 commits into
TanStack:mainfrom 
paul-sachs:error--and-loading-devtools
Conversation
@paul-sachs
@paul-sachspaul-sachs
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Allows the devtools to toggle loading and errors states (at least until the next fetch is triggered).
Things to do:
  •  Make sure onError get's triggered
Screen.Recording.2022-10-21.at.10.41.06.AM.mov
@codesandbox-ci
codesandbox-ciBot
commented
Oct 21, 2022•

edited

Loading

Copy link


Copy Markdown

This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a4ff17e:
SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration
@TkDodo
TkDodo
marked this pull request as ready for review
January 23, 2023 12:10
@codecov-commenter
codecov-commenter
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Base: 91.84% // Head: 92.16% // Increases project coverage by +0.31% 🎉
Coverage data is based on head (356e26e) compared to base (48e806b).

Patch coverage: 97.56% of modified lines in pull request are covered.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@## main #4352 +/- ##
==========================================
+ Coverage 91.84% 92.16% +0.31% 
==========================================
Files 111 111 Lines 4146 4187 +41 Branches 1072 1087 +15 ==========================================
+ Hits 3808 3859 +51 + Misses 317 307 -10 
Partials 21 21 
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts92.85% <ø> (ø)
packages/react-query-devtools/src/devtools.tsx89.09% <97.56%> (+5.16%)⬆️
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.

📢 Do you have feedback about the report comment? Let us know in this issue.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
@paul-sachs thanks for this PR, and sorry that it went unnoticed for a while. I've fixed some issues and did a bit of refactoring.
What would be missing from my perspective would be:
  • some tests of the new behaviour
  • a way to make the loading state revert back when clicking the button a second time, and maybe some visual feedback that we are now in loading state (similar to what the offline toggle button does)
would you like to continue contributing this?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Hi @TkDodo I'll take a look for sure. I'll need to familiarize myself with the testing setup but that should be fine. Storing the previous state is a little tricky if I remember correctly. I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
@TkDodo
TkDodo
commented
Jan 23, 2023

Copy link


Copy Markdown

Collaborator
I think we can have it retrigger the query to restore behaviour. Either way, I'll look into it.
That's fine - I like the resetQueries approach that you've already taken for the error state. But the only way to get out of the loading state right now is to click refetch, and I think it would be good if the button behaved like a toggle. Alternatively, we could keep the last state in a ref before overwriting it and then restore it maybe?
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
I'd worry what would happen if something toggles loading state during loading. I'm not sure how setState works internally, don't know if it will abort the on going promise. Feels a little like reset is our safest bet. Either way really, the toggle behaviour makes sense.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
So I've fixed the toggle state, however this approach doesn't seem to work in suspense mode since the setState doesn't trigger a promise... This will need something else to work through that issue.
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Was hoping to do something like:
activeQuery.fetch({queryFn: ()=>newPromise((resolve,reject)=>{}),cacheTime: -1,})
But i don't think that's replacing the queryFn like I thought it would. It triggers a refetch of the existing queryFn...
@paul-sachs
paul-sachs
commented
Jan 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Ah no, i was incorrect. It is using the updated queryFn. At least, I think it is. The problem is trying to store the previous queryFn so I can restore it...
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Alright, managed to get suspense working. Had to store some query state inside queryMeta so not sure I feel great about that, but it does keep query state all together. Maybe there's a better place to store it?
Next, I'll take a look at the testing infrastructure to figure out how to write some tests.
@paul-sachs
paul-sachs
commented
Jan 23, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@TkDodo Tests are up and green. I've represented the current state of the query in the buttons themselves but let me know if you want a totally different direction.
@vercel
vercelBot
commented
Jan 26, 2023•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 15, 2023 at 8:09AM (UTC)
@paul-sachs
paul-sachs
commented
Feb 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Alright, finally got to fixing prettier + lint issues.
@TkDodoTkDodo
mentioned this pull request
Mar 14, 2023
 Closed

9 tasks
TkDodoand others
added 25 commits
March 15, 2023 09:07
@TkDodo
chore: releases should run on alpha/beta as well
bef1f52
@TkDodo
chore: extract package validation to an extra script (TanStack#5039)
7d3e61d
* chore: extract package validation to an extra script
and run it during CI
* chore: add missing `build:types` script to solid-query
@cseas@TkDodo
docs: update link for v2 docs (TanStack#5044)
30ba660
* docs: update link for v2 docs
* Update README.md
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.12
590dba2
@janinegygax@TkDodo
fix(react-query-devtools): do not stretch query status label (TanStac…
f38b567
…k#5063)
Do not stretch query status label (fresh, fetching, paused, stale, inactive) shown on Query Details view.
@tannerlinsley@TkDodo
release: v4.24.13
82a6377
@yousoumar@TkDodo
fix(react-query-devtools): add 'use client' directive to disable SSR (T…
8db407f
…anStack#5041)
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.24.14
9561549
@remolueoend@TkDodo
feat(core): re-export matchQuery from utils (TanStack#5070)
5abe521
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@tannerlinsley@TkDodo
release: v4.25.0
a2c0c05
@TkDodo
feat(query-core): Add global onSettled callbacks for QueryCache and M…
f57e25c
…utationCache (TanStack#5075)
* feat(query-core): Add global onSettled callbacks for QueryCache and MutationCache
* test: tests for query onSettled callback
* test: tests for mutation onSettled callback
* docs: onSettled callbacks
@tannerlinsley@TkDodo
release: v4.26.0
761e312
@TkDodo
fix(core): make sure mutations get updated options (TanStack#5085)
93ecbc8
this fixes an issue around stale closures where callbacks are not updated, thus are called with wrong values in the closure
@tannerlinsley@TkDodo
release: v4.26.1
fca67f6
@Newbie012@TkDodo
fix(eslint-plugin): improve object property checks (TanStack#5079)
7a8654f
* fix(eslint-plugin): improve object property checks
* prettier
@tannerlinsley@TkDodo
release: v4.26.2
1be904a
@DamianOsipiuk@TkDodo
docs: add adapter dropdown to issue template (TanStack#5108)
c28f64c
@leon-fong@TkDodo
docs(queries): renamesuccess(TanStack#5110)
9ac386b
@ZackDeRose@TkDodo
chore:test:libtask-caching w/ Nx (TanStack#5116)
c372c2e
* adding quick caching test
* reverting workflow change
* updating pr yml to test nx speed
* fixing yml on property
* fixing yml on property
* fixing target name
* upping to running4 in parallel
* upping to running 5 in parallel
* upping to running 6 in parallel
* upping to running 7 in parallel
* upping to running 8 in parallel
* upping to running 9 in parallel
* upping to running 10 in parallel
* opting for --parallel=5
* cleaning up nx.json
* revert touching of ci.yml file
* reverting on property of pr.yml file
* updating root pacakge.json test:lib command
* fixing frozen lockfile error in ci
---------
Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
@TkDodo
chore: fix missing dependencies (TanStack#5127)
dae70a8
* chore: include scripts directory in linting
and fix issues
* chore: add missing dependencies chalk and semver
@ZackDeRose@TkDodo
chore: turning off Nx daemon in CI (TanStack#5128)
7d9878f
@TkDodo
chore: downgrade chalk to v4 because v5 is ESM only (TanStack#5130)
e9c61f1
see: https://stackoverflow.com/questions/70309135/chalk-error-err-require-esm-require-of-es-module
@Newbie012@TkDodo
fix(eslint-plugin): ignore internal properties (TanStack#5119)
9f043a0
@TkDodo
chore: resolve merge conflicts
3ad2ba3
@TkDodo
Merge branch 'main' into error--and-loading-devtools
a4ff17e
@TkDodo
TkDodo
merged commit b7089d1
into
TanStack:mainMar 15, 2023
@paul-sachs
paul-sachs
commented
Mar 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@TkDodo My apologies for letting this drop off. I'll submit a follow on PR with the suggested changes. Thanks so much for merging this, it'll make modifying loading states so much easier!
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@TkDodoTkDodoTkDodo approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

12 participants

@paul-sachs@codecov-commenter@TkDodo@cseas@tannerlinsley@janinegygax@yousoumar@remolueoend@Newbie012@DamianOsipiuk@leon-fong@ZackDeRose