Skip to content

feat(svelte-query): use store for reactivity in options - #5050

Merged
lachlancollins merged 6 commits into
TanStack:alphafrom
chrislcs:update-svelte-reactivity
Mar 3, 2023
Merged

feat(svelte-query): use store for reactivity in options#5050
lachlancollins merged 6 commits into
TanStack:alphafrom
chrislcs:update-svelte-reactivity

Conversation

@chrislcs

Copy link
Copy Markdown

New version of the accidentally closed PR: #4995


To fix#4851

This adds the option to use a writable store for the query options, so that svelte query can react appropriately when these options change. The current method of reactivity recreates the entire query each time an option is changed, which causes issues.

@vercel

vercelBot commented Feb 27, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
NameStatusPreviewCommentsUpdated
query⬜️ Ignored (Inspect)Mar 3, 2023 at 9:55PM (UTC)

@codesandbox-ci

codesandbox-ciBot commented Feb 27, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eef9534:

SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration
ecstatic-mayer-7jm2llIssue #4851

@lachlancollinslachlancollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please fix the merge conflict then it'll be right to go!

@chrislcs

Copy link
Copy Markdown
Author

Conflicts should be solved

@codecov-commenter

codecov-commenter commented Mar 3, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 94.64% and project coverage change: -0.08⚠️

Comparison is base (ca2f697) 90.50% compared to head (eef9534) 90.42%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@ Coverage Diff @@## alpha #5050 +/- ##
==========================================
- Coverage 90.50% 90.42% -0.08% 
==========================================
Files 104 105 +1 Lines 3811 3791 -20 Branches 961 952 -9 ==========================================
- Hits 3449 3428 -21 - Misses 329 330 +1 
Partials 33 33 
Impacted FilesCoverage Δ
packages/query-core/src/query.ts99.02% <ø> (ø)
packages/react-query/src/useInfiniteQuery.ts100.00% <ø> (ø)
packages/solid-query/src/createInfiniteQuery.ts100.00% <ø> (ø)
packages/svelte-query/src/createInfiniteQuery.ts0.00% <ø> (ø)
packages/svelte-query/src/createQuery.ts100.00% <ø> (ø)
packages/vue-query/src/queryClient.ts93.22% <ø> (ø)
packages/vue-query/src/useBaseQuery.ts100.00% <ø> (ø)
packages/vue-query/src/useInfiniteQuery.ts100.00% <ø> (ø)
packages/vue-query/src/useQuery.ts100.00% <ø> (ø)
packages/svelte-query/src/createBaseQuery.ts83.33% <81.25%> (+1.51%)⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@chrislcs@codecov-commenter@lachlancollins@TkDodo