Skip to content

docs: deprecate callbacks on useQuery - #5407

Merged
TkDodo merged 1 commit into
TanStack:mainfrom
NMinhNguyen:05-13-feat_deprecate_callbacks_on_useQuery_
May 13, 2023
Merged

docs: deprecate callbacks on useQuery#5407
TkDodo merged 1 commit into
TanStack:mainfrom
NMinhNguyen:05-13-feat_deprecate_callbacks_on_useQuery_

Conversation

@NMinhNguyen

@NMinhNguyenNMinhNguyen commented May 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@vercel

vercelBot commented May 13, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
NameStatusPreviewCommentsUpdated (UTC)
query⬜️ Ignored (Inspect)May 13, 2023 1:56pm

@NMinhNguyen

NMinhNguyen commented May 13, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Wasn't sure if the commit should be feat or something else. Updated to docs because it's JSDoc 🤷‍♂️

@NMinhNguyen
NMinhNguyenforce-pushed the 05-13-feat_deprecate_callbacks_on_useQuery_ branch from 70c21cf to 2c66536CompareMay 13, 2023 13:56
@NMinhNguyenNMinhNguyen changed the title feat: deprecate callbacks on useQuerydocs: deprecate callbacks on useQueryMay 13, 2023
@codesandbox-ci

codesandbox-ciBot commented May 13, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@TkDodo
TkDodo merged commit 5608a04 into TanStack:mainMay 13, 2023
@seiwonparkseiwonpark mentioned this pull request May 16, 2023
Merged
@NMinhNguyen
NMinhNguyen deleted the 05-13-feat_deprecate_callbacks_on_useQuery_ branch May 20, 2023 14:33
@alicenstar

alicenstar commented May 25, 2023

Copy link
Copy Markdown

@NMinhNguyen@TkDodo Can I ask what the reason for deprecating these callbacks is? And if they'll be replaced with something else/what you recommend using instead?

@NMinhNguyen

NMinhNguyen commented May 25, 2023

Copy link
Copy Markdown
ContributorAuthor

@NMinhNguyen@TkDodo Can I ask what the reason for deprecating these callbacks is? And if they'll be replaced with something else/what you recommend using instead?

This should hopefully answer your question: https://tkdodo.eu/blog/breaking-react-querys-api-on-purpose

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NMinhNguyen@alicenstar@TkDodo