Skip to content

chore: More eslint improvements#5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lachlancollins merged 1 commit into from
May 28, 2023
Merged

chore: More eslint improvements #5482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ module.exports = {
extends: [
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'plugin:import/recommended',
'plugin:import/typescript',
'prettier',
],
Expand DownExpand Up@@ -46,7 +47,10 @@ module.exports = {
'@typescript-eslint/no-inferrable-types': [
'error', { ignoreParameters: true },
],
'import/default': 'off',
'import/export': 'off',
'import/no-cycle': 'error',
'import/no-duplicates': 'off',
'import/no-unresolved': ['error', { ignore: ['^@tanstack/'] }],
'import/no-unused-modules': ['off', { unusedExports: true }],
'no-redeclare': 'off',
Expand Down
10 changes: 5 additions & 5 deletions examples/react/algolia/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
{
"extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"],
"rules": {
"react/jsx-uses-react": "off",
"react/react-in-jsx-scope": "off"
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended",
"plugin:@tanstack/eslint-plugin-query/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/basic-graphql-request/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
6 changes: 5 additions & 1 deletion examples/react/basic-typescript/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
{
"extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"]
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended",
"plugin:@tanstack/eslint-plugin-query/recommended"
]
}
6 changes: 5 additions & 1 deletion examples/react/basic/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
{
"extends": ["react-app", "prettier", "plugin:@tanstack/eslint-plugin-query/recommended"]
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended",
"plugin:@tanstack/eslint-plugin-query/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/default-query-function/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/offline/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/playground/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/react-router/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/rick-morty/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/simple/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/star-wars/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
9 changes: 4 additions & 5 deletions examples/react/suspense/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": ["react-app", "prettier"],
"rules": {
// "eqeqeq": 0,
// "jsx-a11y/anchor-is-valid": 0
}
"extends": [
"plugin:react/recommended",
"plugin:react-hooks/recommended"
]
}
7 changes: 1 addition & 6 deletions examples/solid/basic-graphql-request/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
{
"parserOptions": {
"project": "./tsconfig.json",
"sourceType": "module"
},
"rules": {
"react/react-in-jsx-scope": "off",
"jsx-a11y/anchor-is-valid": "off"
"project": "./tsconfig.json"
}
}
7 changes: 1 addition & 6 deletions examples/solid/basic-typescript/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
{
"parserOptions": {
"project": "./tsconfig.json",
"sourceType": "module"
},
"rules": {
"react/react-in-jsx-scope": "off",
"jsx-a11y/anchor-is-valid": "off"
"project": "./tsconfig.json"
}
}
7 changes: 1 addition & 6 deletions examples/solid/default-query-function/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
{
"parserOptions": {
"project": "./tsconfig.json",
"sourceType": "module"
},
"rules": {
"react/react-in-jsx-scope": "off",
"jsx-a11y/anchor-is-valid": "off"
"project": "./tsconfig.json"
}
}
7 changes: 1 addition & 6 deletions examples/solid/simple/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
{
"extends": ["plugin:@tanstack/eslint-plugin-query/recommended"],
"parserOptions": {
"project": "./tsconfig.json",
"sourceType": "module"
},
"rules": {
"react/react-in-jsx-scope": "off",
"jsx-a11y/accessible-emoji": "off",
"project": "./tsconfig.json"
}
}
6 changes: 2 additions & 4 deletions examples/solid/solid-start-streaming/.eslintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
{
"extends": ["../../../.eslintrc"],
"rules": {
"react/react-in-jsx-scope": "off",
"import/no-unresolved": "off"
"parserOptions": {
"project": "./tsconfig.json"
}
}
6 changes: 3 additions & 3 deletions nx.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@
"{workspaceRoot}/tsconfig.base.json",
"{workspaceRoot}/package.json"
],
"globalNonBuildAffectingConfig": ["{workspaceRoot}/.eslintrc"],
"globalNonBuildAffectingConfig": ["{workspaceRoot}/.eslintrc.cjs"],
"default": [
"{projectRoot}/**/*",
"globalBuildAffectingConfig",
Expand All@@ -41,9 +41,9 @@
],
"public": [
"default",
"!{workspaceRoot}/.eslintrc",
"!{workspaceRoot}/.eslintrc.cjs",
"!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)",
"!{projectRoot}/.eslintrc*",
"!{projectRoot}/.eslintrc.cjs",
"!{projectRoot}/tsconfig.eslint.json"
]
},
Expand Down
4 changes: 0 additions & 4 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,12 +65,8 @@
"current-git-branch": "^1.1.0",
"eslint": "^8.34.0",
"eslint-config-prettier": "^8.8.0",
"eslint-config-react-app": "^7.0.1",
"eslint-import-resolver-typescript": "^3.5.5",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-jsx-a11y": "^6.7.1",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react-hooks": "^4.6.0",
"git-log-parser": "^1.2.0",
Expand Down
2 changes: 0 additions & 2 deletions packages/codemods/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/eslint-plugin-query/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/query-async-storage-persister/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/query-broadcast-client-experimental/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/query-core/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/query-devtools/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/query-persist-client-core/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/query-sync-storage-persister/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
6 changes: 4 additions & 2 deletions packages/react-query-devtools/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,10 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs', 'react-app',],
extends: [
'plugin:react/recommended',
'plugin:react-hooks/recommended',
],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
6 changes: 4 additions & 2 deletions packages/react-query-persist-client/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,10 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs', 'react-app',],
extends: [
'plugin:react/recommended',
'plugin:react-hooks/recommended',
],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
6 changes: 4 additions & 2 deletions packages/react-query/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,10 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs', 'react-app',],
extends: [
'plugin:react/recommended',
'plugin:react-hooks/recommended',
],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/solid-query/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
3 changes: 1 addition & 2 deletions packages/svelte-query-devtools/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,7 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs', 'plugin:svelte/recommended'],
extends: ['plugin:svelte/recommended'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.json',
Expand Down
3 changes: 1 addition & 2 deletions packages/svelte-query/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,7 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs', 'plugin:svelte/recommended'],
extends: ['plugin:svelte/recommended'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.json',
Expand Down
2 changes: 0 additions & 2 deletions packages/vue-query/.eslintrc.cjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@

/** @type {import('eslint').Linter.Config} */
const config = {
root: true,
extends: ['../../.eslintrc.cjs'],
parserOptions: {
tsconfigRootDir: __dirname,
project: './tsconfig.eslint.json',
Expand Down
Loading