Skip to content

refactor(vue-query): use shallowRef to improve performance#5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RomainLanz wants to merge 2 commits into from
Closed

refactor(vue-query): use shallowRef to improve performance #5493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b60086
refactor(vue-query): use shallowRef for useQueries
RomainLanz May 30, 2023
fc866bd
Merge branch 'alpha' into feat/vue-shallow-ref
DamianOsipiuk Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/vue-query/src/useQueries.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ import type {
QueryObserverResult,
} from '@tanstack/query-core'
import type { Ref } from 'vue-demi'
import { computed, onScopeDispose, readonly, ref, watch } from 'vue-demi'
import { computed, onScopeDispose, readonly, shallowRef, watch } from 'vue-demi'

import { useQueryClient } from './useQueryClient'
import { cloneDeepUnref } from './utils'
Expand DownExpand Up@@ -180,9 +180,9 @@ export function useQueries<
const [, getCombinedResult] = observer.getOptimisticResult(
defaultedQueries.value,
)
const state = ref(getCombinedResult()) as Ref<TCombinedResult>
const state = shallowRef(getCombinedResult()) as Ref<TCombinedResult>

const unsubscribe = ref(() => {
const unsubscribe = shallowRef(() => {
// noop
})

Expand Down