[Fix-5538]: Assign observer's current Result when optimistic read occurs

[incepter]

fixes#5538

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)			Jun 23, 2023 2:38pm

[TkDodo]

thank you so much 🙌

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2ef9021. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 2 targets

• nx affected --targets=test:lib --base=3643b87c34d86117b150ca845a058991ff132ab0
• nx affected --targets=test:eslint,test:lib,test:types,test:build

---

Sent with 💌 from NxCloud.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ef9021:

Sandbox	Source
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration
wandering-sky-pn3h6l	Issue #5538
dazzling-https-rrsdgh	Issue #5538

[incepter]

Here a codesandbox forked from the issue using the version from this PR, I think it solves it

https://codesandbox.io/s/serene-keller-h34qgm?file=/src/App.js

[TkDodo]

I think we can ship this, but could you please also make the same PR to the alpha branch? I think this would be better than to merge main -> alpha and try to address the conflicts there

[codecov-commenter]

Codecov Report

Patch coverage: 17.64% and project coverage change: -0.70⚠️

Comparison is base (df37d35) 92.19% compared to head (2ef9021) 91.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@ Coverage Diff @@## main #5573 +/- ##
==========================================
- Coverage 92.19% 91.50% -0.70% 
==========================================
Files 112 101 -11 Lines 4294 3921 -373 Branches 1127 989 -138 ==========================================
- Hits 3959 3588 -371 + Misses 314 308 -6 - Partials 21 25 +4 

Impacted Files	Coverage Δ
packages/query-core/src/queryCache.ts	100.00% <ø> (ø)
packages/query-core/src/queryObserver.ts	81.28% <0.00%> (-3.22%)	⬇️
packages/query-core/src/notifyManager.ts	95.12% <100.00%> (+5.12%)	⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[incepter]

I think we can ship this, but could you please also make the same PR to the alpha branch? I think this would be better than to merge main -> alpha and try to address the conflicts there

Yes sure, I ported the changes to alpha branch in this PR.

[TkDodo]

there is one test failing now @incepter:

useQuery › should reuse same data object reference when queryKey changes and placeholderData is present

[incepter]

there is one test failing now @incepter:

Yes indeed @TkDodo , I fixed it. (I was using the same queryKey and same client for both tests, which resulted in them passing individually, then failing in ci.)