Skip to content

refactor: Sort imports with eslint - #5634

Merged
lachlancollins merged 3 commits into
TanStack:mainfrom
lachlancollins:eslint-sort
Jul 16, 2023
Merged

refactor: Sort imports with eslint#5634
lachlancollins merged 3 commits into
TanStack:mainfrom
lachlancollins:eslint-sort

Conversation

@lachlancollins

Copy link
Copy Markdown
Member

I personally find imports sorted in a consistent order easier to approach, just like how prettier formats code in a consistent way. The rules here are totally flexible but would mean all packages follow the same structure.

@vercel

vercelBot commented Jun 27, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
NameStatusPreviewCommentsUpdated (UTC)
query⬜️ Ignored (Inspect)Jul 16, 2023 4:46am

@nx-cloud

nx-cloudBot commented Jun 27, 2023

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0750784. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --targets=test:eslint,test:lib,test:types,test:build
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci

codesandbox-ciBot commented Jun 27, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0750784:

SandboxSource
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration

@codecov-commenter

codecov-commenter commented Jun 27, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ddf6986) 92.29% compared to head (04a2933) 92.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@ Coverage Diff @@## main #5634 +/- ##
=======================================
Coverage 92.29% 92.29% =======================================
Files 112 112 Lines 4283 4283 Branches 1117 1117 =======================================
Hits 3953 3953 Misses 309 309 Partials 21 21 
Impacted FilesCoverage Δ
packages/eslint-plugin-query/src/configs/index.ts100.00% <ø> (ø)
.../src/rules/exhaustive-deps/exhaustive-deps.rule.ts100.00% <ø> (ø)
...src/rules/exhaustive-deps/exhaustive-deps.utils.ts100.00% <ø> (ø)
...-query-object-syntax/prefer-query-object-syntax.ts96.19% <ø> (ø)
...kages/eslint-plugin-query/src/utils/create-rule.ts100.00% <ø> (ø)
packages/query-core/src/mutation.ts94.17% <ø> (ø)
packages/query-core/src/queryCache.ts100.00% <ø> (ø)
packages/query-core/src/tests/utils.ts88.57% <ø> (ø)
...s/query-persist-client-core/src/__tests__/utils.ts89.47% <ø> (ø)
packages/query-sync-storage-persister/src/index.ts85.00% <ø> (ø)
... and 59 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo

Copy link
Copy Markdown
Collaborator

I agree, but it's gonna cause so many conflicts when merging back to alpha 😭

Maybe we should this once v5 is released and we have only one branch to maintain?

@lachlancollins

Copy link
Copy Markdown
MemberAuthor

I agree, but it's gonna cause so many conflicts when merging back to alpha 😭

Maybe we should this once v5 is released and we have only one branch to maintain?

@TkDodo I was just going to merge main into alpha and only keep the changes to .eslintrc.cjs, then re-run eslint fix. I'm hoping this would actually mean there would be fewer conflicts between v4 and v5!

@TkDodo

Copy link
Copy Markdown
Collaborator

okay, let me just ship the fix for 5538 first. It has two PRs - one for main and one for alpha.

@lachlancollins
lachlancollins merged commit 9c721e5 into TanStack:mainJul 16, 2023
@lachlancollins
lachlancollins deleted the eslint-sort branch July 16, 2023 04:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lachlancollins@codecov-commenter@TkDodo