Fix: Infinite render loops in react-query v4.29.22 and up

[Komoszek]

Fixes#5719. Shalow !== would always return true, because https://github.com/TanStack/query/blob/9b8b5f0a81bc68552bbafbc3991e7e89a893ecbe/packages/query-core/src/queryObserver.ts#L243C19-L243C19 AFAIK always gives new object.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)	Visit Preview		Aug 4, 2023 9:36pm

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a3532fb:

Sandbox	Source
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a3532fb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
nx affected --targets=test:eslint,test:lib,test:types,test:build

✅ Successfully ran 1 target

• nx affected --targets=test:lib --base=9b8b5f0a81bc68552bbafbc3991e7e89a893ecbe

---

Sent with 💌 from NxCloud.

[TkDodo]

thanks. codesandbox doesn't work so I can't verify the fix. Can you add the failing reproduction as a test case please?

It was this one: https://codesandbox.io/s/confident-visvesvaraya-t8hzwk?file=/src/App.js

[TkDodo]

@incepter fyi

[TkDodo]

so this does indeed seem to fix the reported reproduction, here's a fork of the reproduction depending on the codesandbox preview build:

https://codesandbox.io/s/keen-fast-rxg5rk?file=/package.json

[Komoszek]

@TkDodo I've added the test case like you've asked