Skip to content

fix(react-query): remove placeholderData from suspense query - #6973

Merged
TkDodo merged 1 commit into
TanStack:mainfrom
HJZzzzz:hjzzzz
Feb 27, 2024
Merged

fix(react-query): remove placeholderData from suspense query#6973
TkDodo merged 1 commit into
TanStack:mainfrom
HJZzzzz:hjzzzz

Conversation

@HJZzzzz

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercelBot commented Feb 25, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
NameStatusPreviewCommentsUpdated (UTC)
query⬜️ Ignored (Inspect)Visit PreviewFeb 27, 2024 6:21am

@codesandbox-ci

codesandbox-ciBot commented Feb 25, 2024

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 567736c:

SandboxSource
@tanstack/query-example-angular-basicConfiguration
@tanstack/query-example-react-basic-typescriptConfiguration
@tanstack/query-example-solid-basic-typescriptConfiguration
@tanstack/query-example-svelte-basicConfiguration
@tanstack/query-example-vue-basicConfiguration

@TkDodoTkDodo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. could you please add a test for your use-case, where placeholderData is set globally ?

@nx-cloud

nx-cloudBot commented Feb 25, 2024

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 567736c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

@HJZzzzz

Copy link
Copy Markdown
ContributorAuthor

thanks. could you please add a test for your use-case, where placeholderData is set globally ?

yeap, added two test cases for suspense query & queries

@TkDodo

Copy link
Copy Markdown
Collaborator

there are some issues on formatting and types

@HJZzzzz

Copy link
Copy Markdown
ContributorAuthor

there are some issues on formatting and types

Fixed the formatting and types.

But the useMutationState test passed in my local.
Idk why it failed in ci.

@TkDodo

Copy link
Copy Markdown
Collaborator

there are still formatting issues

@HJZzzzz

HJZzzzz commented Feb 27, 2024

Copy link
Copy Markdown
ContributorAuthor

there are still formatting issues

Revised again.

But the failing tests(useMutation & useMutationState) are not related with the code i changed. And from what i see the test passed in my local?
Do you have any ideas why its failing in CI?
Screenshot 2024-02-27 at 10 06 36 AM
Screenshot 2024-02-27 at 10 08 39 AM

@TkDodo

Copy link
Copy Markdown
Collaborator

Do you have any ideas why its failing in CI?

flaky tests, ignore it

@HJZzzzz

Copy link
Copy Markdown
ContributorAuthor

Do you have any ideas why its failing in CI?

flaky tests, ignore it

I see. Are there any other things i need to revise?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HJZzzzz@TkDodo@Bruceeeeeee