Uh oh!
There was an error while loading. Please reload this page.
fix(useQueries): make sure we don't lose property tracking - #8295
Merged
Conversation
if we call `combine` with `#this.result`, we don't have a tracked version of it, as tracking happens in useQueries (to avoid tracking internal access)
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 26de921. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #8295 +/- ##
===========================================
+ Coverage 45.84% 62.68% +16.84%
===========================================
Files 199 135 -64 Lines 7499 4800 -2699 Branches 1717 1348 -369 ===========================================
- Hits 3438 3009 -429 + Misses 3683 1549 -2134 + Partials 378 242 -136
|
eriklynd
commented
Nov 18, 2024
After upgrading to this version from v5.59.20, |
TkDodo
commented
Nov 18, 2024
CollaboratorAuthor
potentially. what do you mean by “significantly slower” ? Can you show a reproduction and open a new issue please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if we call
combinewith#this.result, we don't have a tracked version of it, as tracking happens in useQueries (to avoid tracking internal access)