Uh oh!
There was an error while loading. Please reload this page.
feat(types): support typing QueryKey and MutationKey via Register - #8521
Merged
Conversation
View your CI Pipeline Execution ↗ for commit 2b07bbe.
☁️ Nx Cloud last updated this comment at |
Contributor
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
autofix.cineefrehman
commented
Jan 10, 2025
ContributorAuthor
@TkDodo thanks! I've just fixed the failing build, so hopefully a rerun will be green 🤞🏾 |
QueryKey and MutationKey via RegisterCodecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #8521 +/- ##
===========================================
+ Coverage 46.28% 63.04% +16.76%
===========================================
Files 199 135 -64 Lines 7538 4833 -2705 Branches 1722 1354 -368 ===========================================
- Hits 3489 3047 -442 + Misses 3670 1542 -2128 + Partials 379 244 -135
|
TkDodo
commented
Jan 10, 2025
Collaborator
autofix is still failing. please run prettier or allow updates by maintainers so that this can be fixed by the bot! |
neefrehmanforce-pushed
the
feature/typing-query-keys
branch
from
January 10, 2025 15:10
ce6952b to
b4ea0d6Compareneefrehman
commented
Jan 10, 2025
ContributorAuthor
@TkDodo thanks! annoyingly prettier was unable to find any fixes (at least with how I was running it in my Codespace). I've just allowed maintainer edits, and have pushed a new commit |
vaernion pushed a commit
to Arbeidstilsynet/brevgen2
that referenced
this pull request
Dec 3, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@tanstack/react-query](https://tanstack.com/query) ([source](https://github.com/TanStack/query/tree/HEAD/packages/react-query)) | dependencies | minor | [`5.62.16` -> `5.64.0`](https://renovatebot.com/diffs/npm/@tanstack%2freact-query/5.62.16/5.64.0) | | [@tanstack/react-query-devtools](https://tanstack.com/query) ([source](https://github.com/TanStack/query/tree/HEAD/packages/react-query-devtools)) | dependencies | minor | [`5.62.16` -> `5.64.0`](https://renovatebot.com/diffs/npm/@tanstack%2freact-query-devtools/5.62.16/5.64.0) | --- ### Release Notes <details> <summary>TanStack/query (@​tanstack/react-query)</summary> ### [`v5.64.0`](https://github.com/TanStack/query/releases/tag/v5.64.0) [Compare Source](TanStack/query@v5.63.0...v5.64.0) Version 5.64.0 - 1/11/25, 6:59 PM ##### Changes ##### Feat - types: support typing `QueryKey` and `MutationKey` via `Register` ([#​8521](TanStack/query#8521)) ([`fd500a4`](TanStack/query@fd500a4)) by [@​neefrehman](https://github.com/neefrehman) ##### Docs - react-query: highlight per component select pattern for query options ([#​8522](TanStack/query#8522)) ([`8ddebc6`](TanStack/query@8ddebc6)) by [@​DogPawHat](https://github.com/DogPawHat) - react-query: Add import statement with skipToken to the docs ([#​8519](TanStack/query#8519)) ([`690fd2a`](TanStack/query@690fd2a)) by Przemek Maszczynski ##### Packages - [@​tanstack/query-core](https://github.com/tanstack/query-core)[@​5](https://github.com/5).64.0 - [@​tanstack/query-broadcast-client-experimental](https://github.com/tanstack/query-broadcast-client-experimental)[@​5](https://github.com/5).64.0 - [@​tanstack/query-persist-client-core](https://github.com/tanstack/query-persist-client-core)[@​5](https://github.com/5).64.0 - [@​tanstack/query-sync-storage-persister](https://github.com/tanstack/query-sync-storage-persister)[@​5](https://github.com/5).64.0 - [@​tanstack/react-query](https://github.com/tanstack/react-query)[@​5](https://github.com/5).64.0 - [@​tanstack/react-query-devtools](https://github.com/tanstack/react-query-devtools)[@​5](https://github.com/5).64.0 - [@​tanstack/react-query-persist-client](https://github.com/tanstack/react-query-persist-client)[@​5](https://github.com/5).64.0 - [@​tanstack/react-query-next-experimental](https://github.com/tanstack/react-query-next-experimental)[@​5](https://github.com/5).64.0 - [@​tanstack/solid-query](https://github.com/tanstack/solid-query)[@​5](https://github.com/5).64.0 - [@​tanstack/solid-query-devtools](https://github.com/tanstack/solid-...
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on from #8495
This PR extends the use of the
Registerinterface so that it can narrow the type ofQueryKeyandMutationKey, for situations where users of the library want to enforce a hierarchy of keys at the lowest-level possible.