Skip to content

perf(query-core): useQueries have quadratic performance in relation to the number of queries(#8604)#8686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zktm9903 wants to merge 3 commits into from
Closed

perf(query-core): useQueries have quadratic performance in relation to the number of queries(#8604) #8686

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13dcb36
perf(query-core): useQueries have quadratic performance in relation t…
Feb 22, 2025
8defd38
Merge branch 'main' into main
TkDodo Feb 28, 2025
866cf84
Merge branch 'TanStack:main' into main
zktm9903 Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/query-core/src/queriesObserver.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,6 +43,7 @@ export class QueriesObserver<
#lastCombine?: CombineFn<TCombinedResult>
#lastResult?: Array<QueryObserverResult>
#observerMatches: Array<QueryObserverMatch> = []
#observerMap: Map<QueryObserver, number> = new Map()

constructor(
client: QueryClient,
Expand DownExpand Up@@ -81,6 +82,7 @@ export class QueriesObserver<
this.#observers.forEach((observer) => {
observer.destroy()
})
this.#observerMap.clear()
}

setQueries(
Expand DownExpand Up@@ -128,6 +130,11 @@ export class QueriesObserver<
this.#observers = newObservers
this.#result = newResult

this.#observerMap.clear()
newObservers.forEach((observer, index) => {
this.#observerMap.set(observer, index)
})

if (!this.hasListeners()) {
return
}
Expand DownExpand Up@@ -251,8 +258,8 @@ export class QueriesObserver<
}

#onUpdate(observer: QueryObserver, result: QueryObserverResult): void {
const index = this.#observers.indexOf(observer)
if (index !== -1) {
const index = this.#observerMap.get(observer)
if (index !== undefined) {
this.#result = replaceAt(this.#result, index, result)
this.#notify()
}
Expand Down