Skip to content

feat(vue-query): useInfiniteQuery options support maybe ref type - #8956

Merged
DamianOsipiuk merged 3 commits into
TanStack:mainfrom
aa900031:feat/vue-infinite-query-support-mabe-ref
Apr 10, 2025
Merged

feat(vue-query): useInfiniteQuery options support maybe ref type#8956
DamianOsipiuk merged 3 commits into
TanStack:mainfrom
aa900031:feat/vue-infinite-query-support-mabe-ref

Conversation

@aa900031

@aa900031aa900031 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

The useInfiniteQuery can directly use Ref in the runtime, but it's not supported at the Type level.

@nx-cloud

nx-cloudBot commented Apr 4, 2025•
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 6977598.

CommandStatusDurationResult
nx affected --targets=test:sherif,test:knip,tes...✅ Succeeded2m 11sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded23sView ↗

☁️ Nx Cloud last updated this comment at 2025-04-10 14:32:52 UTC

@aa900031aa900031 changed the title feat: useInfiniteQuery options support maybe ref typefeat(vue-query): useInfiniteQuery options support maybe ref typeApr 4, 2025
@pkg-pr-new

pkg-pr-newBot commented Apr 4, 2025•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8956

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8956

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8956

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8956

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8956

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8956

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8956

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8956

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8956

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8956

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8956

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8956

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8956

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8956

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8956

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8956

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8956

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8956

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8956

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8956

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8956

commit: 6977598

@codecov

codecovBot commented Apr 4, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.01%. Comparing base (d2768d3) to head (6977598).
Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## main #8956 +/- ##
===========================================
+ Coverage 44.09% 71.01% +26.91% 
===========================================
Files 201 19 -182 Lines 8025 483 -7542 Branches 1762 136 -1626 ===========================================
- Hits 3539 343 -3196 + Misses 4058 110 -3948 + Partials 428 30 -398
ComponentsCoverage Δ
@tanstack/angular-query-devtools-experimental∅ <ø> (∅)
@tanstack/angular-query-experimental∅ <ø> (∅)
@tanstack/eslint-plugin-query∅ <ø> (∅)
@tanstack/query-async-storage-persister∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental∅ <ø> (∅)
@tanstack/query-codemods∅ <ø> (∅)
@tanstack/query-core∅ <ø> (∅)
@tanstack/query-devtools∅ <ø> (∅)
@tanstack/query-persist-client-core∅ <ø> (∅)
@tanstack/query-sync-storage-persister∅ <ø> (∅)
@tanstack/react-query∅ <ø> (∅)
@tanstack/react-query-devtools∅ <ø> (∅)
@tanstack/react-query-next-experimental∅ <ø> (∅)
@tanstack/react-query-persist-client∅ <ø> (∅)
@tanstack/solid-query∅ <ø> (∅)
@tanstack/solid-query-devtools∅ <ø> (∅)
@tanstack/solid-query-persist-client∅ <ø> (∅)
@tanstack/svelte-query∅ <ø> (∅)
@tanstack/svelte-query-devtools∅ <ø> (∅)
@tanstack/svelte-query-persist-client∅ <ø> (∅)
@tanstack/vue-query71.01% <100.00%> (ø)
@tanstack/vue-query-devtools∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aa900031

aa900031 commented Apr 6, 2025

Copy link
Copy Markdown
ContributorAuthor

@DamianOsipiuk Please review this, thank you

DamianOsipiuk
DamianOsipiuk reviewed Apr 10, 2025
View reviewed changes
Comment threadpackages/vue-query/src/useBaseQuery.ts Outdated
TError,
TData,
TQueryData,
TQueryFnData,

@DamianOsipiukDamianOsipiukApr 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is a proper change. Why this is needed?

@aa900031aa900031Apr 10, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! that's my fault, I'm already fix it

@DamianOsipiuk
DamianOsipiuk merged commit f56a9f2 into TanStack:mainApr 10, 2025
@aa900031
aa900031 deleted the feat/vue-infinite-query-support-mabe-ref branch April 10, 2025 16:37
@fzaninottofzaninotto mentioned this pull request Jul 16, 2025
Merged
6 tasks
@romanspromansp mentioned this pull request Aug 13, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DamianOsipiukDamianOsipiukDamianOsipiuk left review comments

Assignees

No one assigned

Labels

package: vue-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aa900031@DamianOsipiuk