Uh oh!
There was an error while loading. Please reload this page.
feat(eslint): add type-checked configuration for eslint plugin - #8966
Open
Newbie012 wants to merge 6 commits into
Open
feat(eslint): add type-checked configuration for eslint plugin#8966Newbie012 wants to merge 6 commits into
Newbie012 wants to merge 6 commits into
Conversation
Created a new configuration for type-checked rules in the ESLint plugin. Added a `flat/recommendedTypeChecked` config that includes the `no-void-query-fn` rule which requires TypeScript type information. Added an example project demonstrating the type-checked ESLint setup and updated the documentation to explain how to use it.
There was a problem hiding this comment.
Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (5)
- examples/react/eslint-type-checked/.gitignore: Language not supported
- examples/react/eslint-type-checked/index.html: Language not supported
- examples/react/eslint-type-checked/package.json: Language not supported
- examples/react/eslint-type-checked/tsconfig.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/eslint-plugin-query/src/tests/no-void-query-fn.test.ts:11
- [nitpick] The naming of 'ruleTesterTypeChecked' versus the later 'ruleTester' may be confusing. Consider using consistently descriptive names to clearly differentiate tests for type-checked and non-type-checked scenarios.
const ruleTesterTypeChecked = new RuleTester({
examples/react/eslint-type-checked/eslint.config.js:15
- Verify that 'projectService' is the correct parser option to enable type-aware linting, as standard configurations often use the 'project' property. If this is a mistake, updating it may help ensure proper type-checking.
projectService: true,
View your CI Pipeline Execution ↗ for commit 26f5908.
☁️ Nx Cloud last updated this comment at |
Contributor
Sizes for commit 26f5908:
|
Newbie012
commented
Apr 7, 2025
ContributorAuthor
@TkDodo I think something is off with the current nx configuration. It seems like |
TkDodo
commented
Apr 7, 2025
Collaborator
yes, we are aware and working on it. |
TkDodo
commented
Apr 7, 2025
Collaborator
@Newbie012 I’ve temporarily set |
…e-checked-configuration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## main #8966 +/- ##
=======================================
Coverage 44.30% 44.30% =======================================
Files 202 202 Lines 8058 8060 +2 Branches 1784 1776 -8 =======================================
+ Hits 3570 3571 +1 - Misses 4060 4061 +1
Partials 428 428
🚀 New features to boost your workflow:
|
…anStack/query into feat-eslint-type-checked-configuration
4 tasks
4 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## main #8966 +/- ##
=======================================
Coverage 44.30% 44.30% =======================================
Files 202 202 Lines 8058 8060 +2 Branches 1784 1776 -8 =======================================
+ Hits 3570 3571 +1 - Misses 4060 4061 +1
Partials 428 428
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new configuration for type-checked rules in the ESLint plugin. Added a
flat/recommendedTypeCheckedconfig that includes theno-void-query-fnrule which requires TypeScript type information. Added an example project demonstrating the type-checked ESLint setup and updated the documentation to explain how to use it.