Skip to content

fix(angular-query): fix injectInfiniteQuery to narrow type after isSuccess - #9016

Merged
arnoud-dv merged 4 commits into
TanStack:mainfrom
gs18004:bug/8984
Apr 29, 2025
Merged

fix(angular-query): fix injectInfiniteQuery to narrow type after isSuccess#9016
arnoud-dv merged 4 commits into
TanStack:mainfrom
gs18004:bug/8984

Conversation

@gs18004

@gs18004gs18004 commented Apr 14, 2025•
edited by arnoud-dv
Loading

Copy link
Copy Markdown
Contributor

I fixed injectInfiniteQuery to narrow type after isSuccess.
Also, I wrote a test for this case.

constinfiniteQuery=injectInfiniteQuery(()=>({queryKey: ["projects"],queryFn: ({ pageParam })=>{returnPromise.resolve(5);},initialPageParam: 2,getPreviousPageParam: (firstPage)=>1,getNextPageParam: (lastPage)=>3,}));if(infiniteQuery.isSuccess()){// ✅ after checking isSuccess data signal is not possibly undefinedconstdata=infiniteQuery.data();}

@nx-cloud

nx-cloudBot commented Apr 14, 2025•
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 21b32a0.

CommandStatusDurationResult
nx affected --targets=test:sherif,test:knip,tes...✅ Succeeded3m 6sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded12sView ↗

☁️ Nx Cloud last updated this comment at 2025-04-28 16:17:00 UTC

@pkg-pr-new

pkg-pr-newBot commented Apr 14, 2025•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9016

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9016

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9016

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9016

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9016

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9016

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9016

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9016

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9016

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9016

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9016

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9016

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9016

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9016

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9016

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9016

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9016

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9016

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9016

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9016

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9016

commit: 21b32a0

@codecov

codecovBot commented Apr 14, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (b397fba) to head (21b32a0).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## main #9016 +/- ##
===========================================
+ Coverage 44.58% 86.16% +41.58% 
===========================================
Files 203 17 -186 Lines 8104 318 -7786 Branches 1812 70 -1742 ===========================================
- Hits 3613 274 -3339 + Misses 4059 39 -4020 + Partials 432 5 -427
ComponentsCoverage Δ
@tanstack/angular-query-devtools-experimental∅ <ø> (∅)
@tanstack/angular-query-experimental85.23% <ø> (ø)
@tanstack/eslint-plugin-query∅ <ø> (∅)
@tanstack/query-async-storage-persister∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental∅ <ø> (∅)
@tanstack/query-codemods∅ <ø> (∅)
@tanstack/query-core∅ <ø> (∅)
@tanstack/query-devtools∅ <ø> (∅)
@tanstack/query-persist-client-core∅ <ø> (∅)
@tanstack/query-sync-storage-persister∅ <ø> (∅)
@tanstack/react-query∅ <ø> (∅)
@tanstack/react-query-devtools∅ <ø> (∅)
@tanstack/react-query-next-experimental∅ <ø> (∅)
@tanstack/react-query-persist-client∅ <ø> (∅)
@tanstack/solid-query∅ <ø> (∅)
@tanstack/solid-query-devtools∅ <ø> (∅)
@tanstack/solid-query-persist-client∅ <ø> (∅)
@tanstack/svelte-query∅ <ø> (∅)
@tanstack/svelte-query-devtools∅ <ø> (∅)
@tanstack/svelte-query-persist-client∅ <ø> (∅)
@tanstack/vue-query∅ <ø> (∅)
@tanstack/vue-query-devtools∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arnoud-dv

arnoud-dv commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

Merged, but it doesn't fully fix #8984 as it's not just isSuccess() that should support narrowing.

@arnoud-dv
arnoud-dv merged commit aa60c07 into TanStack:mainApr 29, 2025
@mdm317mdm317 mentioned this pull request Sep 14, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: angular-query-experimental

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gs18004@arnoud-dv