Uh oh!
There was an error while loading. Please reload this page.
Make hydrationQueue a derived value - #9247
Merged
Merged
Conversation
…te to a derived value
View your CI Pipeline Execution ↗ for commit 893f377.
☁️ Nx Cloud last updated this comment at |
TkDodo
approved these changes
Jun 4, 2025
TkDodo
left a comment
Collaborator
There was a problem hiding this comment.
awesome, exactly how I imagined it would look
TkDodo
commented
Jun 4, 2025
Collaborator
ah, the eslint disable is still needed it seems: |
Ephem
commented
Jun 4, 2025
CollaboratorAuthor
Yeah, my editor linting was acting up and told me it was safe to remove. 😞 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #9247 +/- ##
===========================================
+ Coverage 45.33% 84.29% +38.95%
===========================================
Files 207 25 -182 Lines 8271 363 -7908 Branches 1860 108 -1752 ===========================================
- Hits 3750 306 -3444 + Misses 4080 48 -4032 + Partials 441 9 -432
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the fixes in:
#9157
#9188
I noticed a version of this bug was still happening: #8677
@TkDodo Pointed out a potential solution, which is to move
hydrationQueuefrom being a state, to being a derived value instead.I think this makes a lot of sense. It should always be safe to recalculate this and there should be no situation where the component rerenders without the effect running where we want to preserve the values.
Tests are passing without changes.