Skip to content

fix(query-core): set options before checking experimental_prefetchInR… - #9412

Closed
birkskyum wants to merge 2 commits into
mainfrom
set-options-before-checking-experimental_prefetchInRender
Closed

fix(query-core): set options before checking experimental_prefetchInR…#9412
birkskyum wants to merge 2 commits into
mainfrom
set-options-before-checking-experimental_prefetchInRender

Conversation

@birkskyum

@birkskyumbirkskyum commented Jul 12, 2025•
edited
Loading

Copy link
Copy Markdown
Member

In this PR

I'm facing the error, in the /e2e/solid-start/basic-solid-query project in the Posts and Users pages:

Cannot read properties of undefined (reading 'experimental_prefetchInRender')

I believe it's because it's checking the property on the options object before setting the options object on the next line.

This swaps that around

@nx-cloud

nx-cloudBot commented Jul 12, 2025•
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 9a4c3a9

CommandStatusDurationResult
nx affected --targets=test:sherif,test:knip,tes...✅ Succeeded1m 7sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded1sView ↗

☁️ Nx Cloud last updated this comment at 2025-07-12 12:22:54 UTC

@pkg-pr-new

pkg-pr-newBot commented Jul 12, 2025•
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9412

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9412

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9412

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9412

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9412

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9412

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9412

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9412

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9412

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9412

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9412

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9412

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9412

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9412

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9412

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9412

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9412

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9412

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9412

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9412

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9412

commit: 9a4c3a9

@github-actions

github-actionsBot commented Jul 12, 2025

Copy link
Copy Markdown
Contributor

Sizes for commit 9a4c3a9:

BranchBundle Size
Main
This PR

@birkskyum

birkskyum commented Jul 12, 2025

Copy link
Copy Markdown
MemberAuthor

The issue appear to be that the client isn't passed to the QueryObserver constructor for solid-query

@birkskyumbirkskyum reopened this Jul 12, 2025
@codecov

codecovBot commented Jul 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.70%. Comparing base (4349e75) to head (9a4c3a9).

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## main #9412 +/- ##
===========================================
+ Coverage 45.39% 59.70% +14.31% 
===========================================
Files 208 137 -71 Lines 8279 5517 -2762 Branches 1865 1477 -388 ===========================================
- Hits 3758 3294 -464 + Misses 4080 1925 -2155 + Partials 441 298 -143
ComponentsCoverage Δ
@tanstack/angular-query-devtools-experimental∅ <ø> (∅)
@tanstack/angular-query-experimental85.00% <ø> (ø)
@tanstack/eslint-plugin-query∅ <ø> (∅)
@tanstack/query-async-storage-persister43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental24.39% <ø> (ø)
@tanstack/query-codemods∅ <ø> (∅)
@tanstack/query-core98.15% <100.00%> (ø)
@tanstack/query-devtools3.55% <ø> (ø)
@tanstack/query-persist-client-core79.47% <ø> (ø)
@tanstack/query-sync-storage-persister84.61% <ø> (ø)
@tanstack/query-test-utils∅ <ø> (∅)
@tanstack/react-query95.95% <ø> (ø)
@tanstack/react-query-devtools10.00% <ø> (ø)
@tanstack/react-query-next-experimental∅ <ø> (∅)
@tanstack/react-query-persist-client100.00% <ø> (ø)
@tanstack/solid-query78.13% <ø> (ø)
@tanstack/solid-query-devtools∅ <ø> (∅)
@tanstack/solid-query-persist-client100.00% <ø> (ø)
@tanstack/svelte-query88.07% <ø> (ø)
@tanstack/svelte-query-devtools∅ <ø> (∅)
@tanstack/svelte-query-persist-client100.00% <ø> (ø)
@tanstack/vue-query71.10% <ø> (ø)
@tanstack/vue-query-devtools∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: query-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@birkskyum