fix(svelte-query): `state_unsafe_mutation` error with `useIs...` by hmnd · Pull Request #9493 · TanStack/query

hmnd · 2025-07-24T22:39:53Z

🎯 Changes

Fixes the bug reported by @frederikhors here.

I thoroughly dug into this issue until I found calls to Observer and MutataionOBserver were wrapped in a $derived(...) in order to make them reactive to the passed in client. This was resulting in unsafe mutation errors, and there was already an $effect.pre(...) used for updating options when they changed, so aside from the client reactivity, the $derived wasn't necessary.

To support reactivity for queryClient, the observer is now a $state and is reassigned whenever the client changes.

The useIsFetching and useIsMutating tests were previously passing because they used a QueryClient local to the component, rather than one from context. I've updated the tests to use a provider instead, in order to properly repro this issue.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

nx-cloud · 2025-07-25T02:40:33Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit 62798d6

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	❌ Failed	1m 17s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	6s	View ↗

☁️ Nx Cloud last updated this comment at 2025-09-27 12:32:45 UTC

pkg-pr-new · 2025-07-25T02:43:26Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9493

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9493

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9493

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9493

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9493

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9493

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9493

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9493

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9493

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9493

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9493

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9493

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9493

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9493

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9493

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9493

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9493

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9493

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9493

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9493

commit: 62798d6

lachlancollins

Hi @hmnd , I don't seem to have permission to sync this with the changes in the svelte-5-adapter. Could you fix the merge conflicts?

changeset-bot · 2025-09-27T05:41:02Z

⚠️ No Changeset found

Latest commit: 62798d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-09-27T05:41:04Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

hmnd · 2025-09-27T05:49:24Z

@lachlancollins should be fixed now :)

lachlancollins

Not sure if it worked, it's still showing all the conflicts

hmnd · 2025-09-27T06:04:34Z

Not sure if it worked, it's still showing all the conflicts

Oh sorry, git fetch only pulled from my fork, not upstream 🤦

One sec

…afe_mutation fixes useIsFetching and useIsMutating in svelte 5 adapter

…est non colocated query

hmnd · 2025-09-27T07:26:49Z


- onDestroy(() => {
- unsubscribe()
+ let result = $derived(observer.getCurrentResult())


@lachlancollins do you think we need to keep the Svelte peer dep pinned to as low as 5.7.0, or could we bump that to at least 5.25.0so that assigning to $derived like this is supported? This was part of eslint --fix, but if we need to stay on the lower version, I'll have to revert this back to a manually managed $state.

I'm happy to bump the peer dependency version!

@hmnd I've updated this on the target branch.

It seems like this change(?) might have caused tests to start failing. It's difficult to know though, as the force pushes have erased the history.

Nevermind, I found the diff in a branch I cloned earlier. Tests are all passing again, so I think I'll merge this! Thanks heaps for your time @hmnd !

Thank you for getting this merged @lachlancollins! Sorry about the force pushes 😅

Replace derived state with direct state and add watchChanges for result updates.

* WIP: Svelte 5 adapter (#6981) * feat(svelte-query): Improve svelte runes API (#8852) * feat: Draft proposal * chore: Improve reactive containers * ci: apply automated fixes * oops * fix: Update API, add a bunch of tests * merge main * fix: use const * more tests * feat: More tests, back to thunks, fixed svelte-query-persist-client * feat: More tests and examples! * lockfile * fixes * Fix current CI errors * More small fixes/tweaks * Remove test.only * ci: apply automated fixes * Fix pnpm-lock, fix import order * update main docs * feat: More tests * ci: apply automated fixes * add back old tests * Cleanup * Fix persist client * Fix useMutationState --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> * Use sleep from query-test-utils * Simplify test reset logic * Fix some merge conflicts * More fixes * A few more fixes * Fix useMutationState * Add changeset * Add migration docs * Replace Set with SvelteSet * Update minimum svelte version * Bump svelte-eslint-parser * Unwrap createQuery test * fix(svelte-query): `state_unsafe_mutation` error with `useIs...` (#9493) * fix(svelte-query): don't wrap observers in derived to avoid state_unsafe_mutation fixes useIsFetching and useIsMutating in svelte 5 adapter * test(svelte-query): wrap (useIs...) tests in QueryClientProvider to test non colocated query * fix(svelte-query): update observers when passed in query client changes * fix(svelte-query): simplify creatMutation sub/unsub * Refactor result handling in createMutation.svelte.ts Replace derived state with direct state and add watchChanges for result updates. --------- Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> * chore(svelte-query): fix eslint config (#9699) * chore(svelte-query): fix eslint config * Use @typescript-eslint/parser directly * ci: apply automated fixes * Fix sherif * Update docs and changeset * Update keywords --------- Co-authored-by: Zhiheng Zhang <55773069+zhihengGet@users.noreply.github.com> Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: David <david@hmnd.io>

* WIP: Svelte 5 adapter (TanStack#6981) * feat(svelte-query): Improve svelte runes API (TanStack#8852) * feat: Draft proposal * chore: Improve reactive containers * ci: apply automated fixes * oops * fix: Update API, add a bunch of tests * merge main * fix: use const * more tests * feat: More tests, back to thunks, fixed svelte-query-persist-client * feat: More tests and examples! * lockfile * fixes * Fix current CI errors * More small fixes/tweaks * Remove test.only * ci: apply automated fixes * Fix pnpm-lock, fix import order * update main docs * feat: More tests * ci: apply automated fixes * add back old tests * Cleanup * Fix persist client * Fix useMutationState --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> * Use sleep from query-test-utils * Simplify test reset logic * Fix some merge conflicts * More fixes * A few more fixes * Fix useMutationState * Add changeset * Add migration docs * Replace Set with SvelteSet * Update minimum svelte version * Bump svelte-eslint-parser * Unwrap createQuery test * fix(svelte-query): `state_unsafe_mutation` error with `useIs...` (TanStack#9493) * fix(svelte-query): don't wrap observers in derived to avoid state_unsafe_mutation fixes useIsFetching and useIsMutating in svelte 5 adapter * test(svelte-query): wrap (useIs...) tests in QueryClientProvider to test non colocated query * fix(svelte-query): update observers when passed in query client changes * fix(svelte-query): simplify creatMutation sub/unsub * Refactor result handling in createMutation.svelte.ts Replace derived state with direct state and add watchChanges for result updates. --------- Co-authored-by: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> * chore(svelte-query): fix eslint config (TanStack#9699) * chore(svelte-query): fix eslint config * Use @typescript-eslint/parser directly * ci: apply automated fixes * Fix sherif * Update docs and changeset * Update keywords --------- Co-authored-by: Zhiheng Zhang <55773069+zhihengGet@users.noreply.github.com> Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: David <david@hmnd.io>

github-actionsBot added the package: svelte-query label Jul 24, 2025

hmnd force-pushed the fix/svelte-query-isfetching branch from dd04604 to e22d61eCompare July 24, 2025 22:46

lachlancollins self-requested a review July 25, 2025 02:40

lachlancollins self-assigned this Sep 22, 2025

lachlancollins requested changes Sep 26, 2025
View reviewed changes

hmnd force-pushed the fix/svelte-query-isfetching branch from 4f57fd5 to ab7e6b4Compare September 27, 2025 05:40

hmnd force-pushed the fix/svelte-query-isfetching branch from ab7e6b4 to 4f57fd5Compare September 27, 2025 05:47

lachlancollins requested changes Sep 27, 2025
View reviewed changes

fix(svelte-query): don't wrap observers in derived to avoid state_uns…
4da7817
…afe_mutation fixes useIsFetching and useIsMutating in svelte 5 adapter

hmnd force-pushed the fix/svelte-query-isfetching branch from 4f57fd5 to f8f22f7Compare September 27, 2025 06:15

hmnd requested a review from lachlancollins September 27, 2025 06:25

lachlancollins requested changes Sep 27, 2025
View reviewed changes

Comment threadpnpm-lock.yaml

hmnd force-pushed the fix/svelte-query-isfetching branch 3 times, most recently from a9c586a to 83143f0Compare September 27, 2025 06:42

lachlancollins requested changes Sep 27, 2025
View reviewed changes

Comment threadpackages/svelte-query/vite.config.ts Outdated

hmnd added 3 commits September 27, 2025 00:15

test(svelte-query): wrap (useIs...) tests in QueryClientProvider to t…
de3a48e
…est non colocated query

fix(svelte-query): update observers when passed in query client changes
f919a0f

fix(svelte-query): simplify creatMutation sub/unsub
ac2afcf

hmnd force-pushed the fix/svelte-query-isfetching branch from 83143f0 to ac2afcfCompare September 27, 2025 07:15

hmnd commented Sep 27, 2025
View reviewed changes

lachlancollins added 2 commits September 27, 2025 17:55

Merge branch 'svelte-5-adapter' into fix/svelte-query-isfetching
000016c

Refactor result handling in createMutation.svelte.ts
62798d6
Replace derived state with direct state and add watchChanges for result updates.

lachlancollins approved these changes Sep 27, 2025
View reviewed changes

lachlancollins merged commit 968d6a8 into TanStack:svelte-5-adapterSep 27, 2025
6 of 7 checks passed

Uh oh!

Uh oh!

Conversation

hmnd commented Jul 24, 2025• edited by lachlancollins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

nx-cloudBot commented Jul 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix Eligible

Uh oh!

pkg-pr-newBot commented Jul 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lachlancollins left a comment

Choose a reason for hiding this comment

Uh oh!

changeset-botBot commented Sep 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitaiBot commented Sep 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

hmnd commented Sep 27, 2025

Uh oh!

lachlancollins left a comment

Choose a reason for hiding this comment

Uh oh!

hmnd commented Sep 27, 2025

Uh oh!

Uh oh!

Uh oh!

hmndSep 27, 2025

Choose a reason for hiding this comment

Uh oh!

lachlancollinsSep 27, 2025

Choose a reason for hiding this comment

Uh oh!

lachlancollinsSep 27, 2025

Choose a reason for hiding this comment

Uh oh!

lachlancollinsSep 27, 2025

Choose a reason for hiding this comment

Uh oh!

lachlancollinsSep 27, 2025

Choose a reason for hiding this comment

Uh oh!

hmndSep 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hmnd commented Jul 24, 2025•
edited by lachlancollins
Loading

nx-cloudBot commented Jul 25, 2025•
edited
Loading

pkg-pr-newBot commented Jul 25, 2025•
edited
Loading

changeset-botBot commented Sep 27, 2025•
edited
Loading

coderabbitaiBot commented Sep 27, 2025•
edited
Loading