Skip to content

test(react-query-persist-client/PersistQueryClientProvider): convert complex 'then' callback to async/await and add delayed assertion for refetch verification#9901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 3 commits into from
Dec 27, 2025
Merged

test(react-query-persist-client/PersistQueryClientProvider): convert complex 'then' callback to async/await and add delayed assertion for refetch verification #9901

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc6a51
test(react-query-persist-client/PersistQueryClientProvider): replace …
sukvvon Nov 23, 2025
94c1dc9
refactor(react-query-persist-client/PersistQueryClientProvider.test):…
sukvvon Dec 17, 2025
fb4071e
Merge branch 'main' into test/react-query-persist-client-improvements
sukvvon Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -384,12 +384,11 @@ describe('PersistQueryClientProvider', () => {
function Page() {
const state = useQuery({
queryKey: key,
queryFn: () =>
sleep(10).then(() => {
fetched = true
return 'fetched'
}),

queryFn: async () => {
await sleep(10)
fetched = true
return 'fetched'
},
Comment on lines +387 to +391

@coderabbitaicoderabbitaiBotDec 17, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent PR description, but changes align with learnings.

The PR title and description claim to "replace 'await sleep' with 'sleep().then()' pattern in restoreClient", but the actual change here is in a queryFn and goes in the opposite direction (from .then() to async/await).

However, the change itself is appropriate: the queryFn has a side effect (fetched = true), so async/await syntax is preferred for clarity.

Based on learnings, please update the PR title and description to accurately reflect the actual changes.

🤖 Prompt for AI Agents
In
packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx
around lines 387 to 391, the PR title/description incorrectly state "replace
'await sleep' with 'sleep().then()' pattern in restoreClient" while the actual
change in this test replaces a .then() style sleep with an async/await queryFn
(which is correct due to the side effect). Update the PR title and description
to accurately describe the change (e.g., "use async/await in queryFn with side
effect in PersistQueryClientProvider tests" or similar) and remove any
references to modifying restoreClient or switching to .then() so they match the
code changes.

staleTime: Infinity,
})

Expand All@@ -415,6 +414,8 @@ describe('PersistQueryClientProvider', () => {
expect(rendered.getByText('data: null')).toBeInTheDocument()
await act(() => vi.advanceTimersByTimeAsync(10))
expect(rendered.getByText('data: hydrated')).toBeInTheDocument()
await act(() => vi.advanceTimersByTimeAsync(11))
expect(rendered.getByText('data: hydrated')).toBeInTheDocument()

expect(states).toHaveLength(2)

Expand Down
Loading